Re: git: adeca21464d2 - main - Add GNU glibc compatible secure_getenv

Warner Losh <imp_at_bsdimp.com> wrote on
Date: Tue, 14 Mar 2023 05:03:33 UTC :

> We need to do a pass to use rfc language.

style(9) looks to have about:

8  "must"s.
11 "may"s.
56 "should"s.

I can not tell for sure if RFC 2119 interpretations
are/were (always) intended or not, especially for
the "should"s. Part of this is the lack of the
capitalization used in the RFC to make the special uses
stand out vs. possible normal english usage also being
present/intended in some places.

For returns statements, "the full implications must be
understood and carefully weighed before choosing a
different course" (a.k.a. "should") likely is too strong
at this point.

For a style guide, the RFC 2119 "Guidance in the use
of these Imperatives" not specific to each word is not
a good fit: "they MUST only be used where it is actually
required for interoperation or to limit behavior which
has potential for causing harm (e.g., limiting
retransmisssions) For example, they must not be used
to try to impose a particular method on implementors
where the method is not required for interoperability"
(the "sparingly" criteria).


===
Mark Millard
marklmi at yahoo.com