From nobody Tue Mar 14 04:30:20 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PbLDG6lbxz3xg17 for ; Tue, 14 Mar 2023 04:30:22 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PbLDG6LCPz47Hr for ; Tue, 14 Mar 2023 04:30:22 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f46.google.com with SMTP id y14so463732wrq.4 for ; Mon, 13 Mar 2023 21:30:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678768221; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y6d3RK1slGsOs+2kDHmx51mrrKXlbgB2DoAmvP8l91Y=; b=HNwQXgxA9aN8B+S+FUbqSxIKVK9UrU7CaShS2RVoJ1fRyDP9QhM/Hc83N0gMrWDgj3 /f8OVEcLC7Ihm28sW9QvnmrNjBVoVoPCokgd9oeg/GOH3jgd9ovBtH0bseVyZkWeeFTx LTD8VgFiNybR+gzWgqZuKsSw9FM6OzlVzFgG0Yg2BsKHpwzvJ9VS5ijjNArB3QISVJxA mua8jtLfcHS5yCCWe/ZByEsRoQQ1MmBh3Q9M1TnDgtn677mRzvsRJaP1KYl2h/jIWE1v fRCoYyKMKAyEwWgDt2WwMLk5wReBBIAmYmm6rdZv5aTBzPvcxYwoYZ8xJdiud37mSs4L x6/Q== X-Gm-Message-State: AO0yUKUfBX0fBioYR7J/MElKr57dkem+C7Ogxu1SWXCTUPjYMbud7PtM NHzc+uEmztjcmj2qldD6pkMNuA== X-Google-Smtp-Source: AK7set/nDCD3o/muQXkrOUM97xomMxjLvxmM6kUTB8X5yJFIG3Hvd+yo+yUeW56HqhfLAHUTjVAHTA== X-Received: by 2002:a5d:4012:0:b0:2c5:532a:98c4 with SMTP id n18-20020a5d4012000000b002c5532a98c4mr9410322wrp.33.1678768221406; Mon, 13 Mar 2023 21:30:21 -0700 (PDT) Received: from smtpclient.apple (global-5-144.n-2.net.cam.ac.uk. [131.111.5.144]) by smtp.gmail.com with ESMTPSA id j5-20020a5d6045000000b002c55306f6edsm1006263wrt.54.2023.03.13.21.30.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Mar 2023 21:30:20 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 15e7fa83ef3c - main - arm64: Hyper-V: Add vPCI and Mellanox driver modules into build From: Jessica Clarke In-Reply-To: Date: Tue, 14 Mar 2023 04:30:20 +0000 Cc: Wei Hu , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <3D6476D5-807E-4D9A-87BC-F5916FBEBE5B@freebsd.org> References: <202303130300.32D30Q0K068420@gitrepo.freebsd.org> <4F72E2FD-6E84-40F1-981D-A18C8DE22FDD@freebsd.org> To: Wei Hu X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Rspamd-Queue-Id: 4PbLDG6LCPz47Hr X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 14 Mar 2023, at 04:22, Wei Hu wrote: >=20 >=20 >=20 >> -----Original Message----- >> From: Jessica Clarke >> Sent: Tuesday, March 14, 2023 12:04 PM >> To: Wei Hu >> Cc: src-committers@freebsd.org; dev-commits-src-all@freebsd.org; dev- >> commits-src-main@freebsd.org >> Subject: Re: git: 15e7fa83ef3c - main - arm64: Hyper-V: Add vPCI and >> Mellanox driver modules into build >>=20 >> On 14 Mar 2023, at 03:57, Jessica Clarke wrote: >>>=20 >>> On 13 Mar 2023, at 03:00, Wei Hu wrote: >>>>=20 >>>> The branch main has been updated by whu: >>>>=20 >>>> URL: >>>>=20 >> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fcgi= >>>>=20 >> t.freebsd.org%2Fsrc%2Fcommit%2F%3Fid%3D15e7fa83ef3cd909e1d1b3b2ca >> da8d >>>>=20 >> 9073f2e22e&data=3D05%7C01%7Cweh%40microsoft.com%7Ce49561fcb0054db >> 78cfc0 >>>>=20 >> 8db244136f1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6381436 >> 34775 >>>>=20 >> 142011%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2 >> luMzIiLC >>>>=20 >> JBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DNe98uGxwYg >> CfWaRPct >>>> 8KCG%2FBEcwSf0HmjmcuW7Rx0FU%3D&reserved=3D0 >>>>=20 >>>> commit 15e7fa83ef3cd909e1d1b3b2cada8d9073f2e22e >>>> Author: Wei Hu >>>> AuthorDate: 2023-03-13 02:55:04 +0000 >>>> Commit: Wei Hu >>>> CommitDate: 2023-03-13 02:55:04 +0000 >>>>=20 >>>> arm64: Hyper-V: Add vPCI and Mellanox driver modules into build >>>=20 >>> What does Mellanox have to do with Hyper-V? I doubt it's being = emulated. >>=20 >> I guess because Azure Accelerated Networking has Mellanox hardware. = In >> which case it doesn't belong in std.hyperv, it belongs in std.azure, = as >> std.hyperv is for things needed for Hyper-V, not platforms that = happen to >> use Hyper-V. >=20 > Hyper-V supports SRIOV devices. For now Mellanox NICs is the only NIC = type supported. So? Hyper-V still isn=E2=80=99t giving you a Mellanox NIC, you have to = go buy one or use a platform (Azure) that has one; Azure is the justification, not Hyper-V. > Mellanox drivers were not included in the ARM64 build. We have tested = it on Hyper-V=20 > during the ARM64 for Hyper-V enablement effort, with Hyper-V VPCI = driver. We have > not tested it on the other ARM64 platforms. It should work not only in = Azure, > but also in on-prem ARM64 Hyper-V hosts.=20 Well it=E2=80=99s in GENERIC now given that includes std.hyperv... > It's better to move Mellanox drivers to more general build location = once they are tested > on more ARM64 platforms. >=20 > Wei >=20 >>=20 >> Jess >>=20 >>>> These changes in conf and std.hyperv files got missed in previous = commit. >>>> Reviewed by: whu >>>> Tested by: whu >>>> Obtained from: Souradeep Chakrabarti >>>> Sponsored by: Microsoft >>>> Differential Revision: >>>>=20 >> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Frev= >>>>=20 >> iews.freebsd.org%2FD38529&data=3D05%7C01%7Cweh%40microsoft.com%7C >> e49561 >>>>=20 >> fcb0054db78cfc08db244136f1%7C72f988bf86f141af91ab2d7cd011db47%7C1% >> 7C0 >>>> %7C638143634775142011%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w >> LjAwMDAiLCJ >>>>=20 >> QIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdat >> a=3DYu% >>>> 2BY%2FyEVCjC6dj8UKY6pYeVy%2BAsgxar5DBC9XQlexYo%3D&reserved=3D0 >>>> --- >>>> sys/arm64/conf/std.hyperv | 12 +++++++++++- >>>> sys/conf/files.arm64 | 1 + >>>> 2 files changed, 12 insertions(+), 1 deletion(-) >>>>=20 >>>> diff --git a/sys/arm64/conf/std.hyperv b/sys/arm64/conf/std.hyperv >>>> index f87082f15c96..b742c75da131 100644 >>>> --- a/sys/arm64/conf/std.hyperv >>>> +++ b/sys/arm64/conf/std.hyperv >>>> @@ -3,4 +3,14 @@ >>>> # >>>>=20 >>>> #hyper-v support >>>> -device hyperv >>>> +device hyperv >>>> + >>>> +options COMPAT_LINUXKPI >>>> +device xz >>>> + >>>> +device mlx5 >>>> +device mlxfw >>>> +device mlx5en >>>> +options RATELIMIT As pointed out on IRC, no other kernel config, aside from LINT ones, enables this. Therefore this seems pretty dubious to add; why does arm64 need it whilst amd64, which does include Mellanox drivers in its GENERIC, doesn=E2=80=99t need it? Jess >>>> +options KERN_TLS >>>> +device firmware >>>> diff --git a/sys/conf/files.arm64 b/sys/conf/files.arm64 index >>>> 684cb8cb23ba..22dd267b2b42 100644 >>>> --- a/sys/conf/files.arm64 >>>> +++ b/sys/conf/files.arm64 >>>> @@ -253,6 +253,7 @@ dev/hyperv/utilities/hv_kvp.c >> optional hyperv acpi >>>> dev/hyperv/netvsc/hn_nvs.c optional hyperv acpi >>>> dev/hyperv/netvsc/hn_rndis.c optional hyperv = acpi >>>> dev/hyperv/netvsc/if_hn.c optional hyperv acpi >>>> +dev/hyperv/pcib/vmbus_pcib.c optional hyperv = pci >> acpi >>>>=20 >>>> dev/ice/if_ice_iflib.c optional ice pci = \ >>>> compile-with "${NORMAL_C} -I$S/dev/ice" >>>=20 >=20