From nobody Thu Mar 09 15:10:16 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PXXgC1wv5z3x2Qv; Thu, 9 Mar 2023 15:10:31 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PXXgB70Wgz3tKj; Thu, 9 Mar 2023 15:10:30 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-f51.google.com with SMTP id r27so2677064lfe.10; Thu, 09 Mar 2023 07:10:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678374629; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PUvgr8tzD6m21hleuStAWquJqM5uDyhxQbIU0z+jxqY=; b=1WkQvRm939f68VYAFJhQSzJBscUYvSW0C60+/m3sxCc7z2WcyHCYknKjR4fsCGf584 fMhh3yEO2ef6k1pDHYH8I52+oqjxJdT8Oaa3xhpd8NLg4ZSIZYKv+0g30Q3YOolGznIp /NUvo68N3m4Lv0qr9YNE9EwEVh5OMpSanEivCbnSpbAVoHw6IEM/tdFwKd37NBaKj6v2 t/+TUtDMCPSlEScTCndeipMih799zSongFbmTdM2ukrjBjyZhich+xVQRRcTCo8rVr5O pJohyV6k6NhtfF0FGJelz/2EwRHY1RoXoyIh+/kfITzOtz9onj/nD2O9jZ1d5V0Nc5uY wDPg== X-Gm-Message-State: AO0yUKUGBKiytOYjwB3yKVNVVwdCLnKH3UJJJ9VMw+PproKeOgD+uSPk AFzxwLc51OjDLAimj+EH/mlYa7oT5tYK82VQJVO0HQwvbKY= X-Google-Smtp-Source: AK7set8EwV1Pj/kS+9sgpps5gHAC8QO9CQhMq9MiiLO6Pt/kXZ8cqH8aOxwT2/y+kXZIZgAaXvI9ijxsH1Idiu0d4rU= X-Received: by 2002:a05:6512:48e:b0:4db:33ed:89eb with SMTP id v14-20020a056512048e00b004db33ed89ebmr7075640lfq.5.1678374628744; Thu, 09 Mar 2023 07:10:28 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202303082331.328NViDn050541@gitrepo.freebsd.org> In-Reply-To: From: Ed Maste Date: Thu, 9 Mar 2023 10:10:16 -0500 Message-ID: Subject: Re: git: c581962414ed - main - src.conf.5: Add some WITH_/WITHOUT_ option descriptions To: Warner Losh Cc: John Baldwin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4PXXgB70Wgz3tKj X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Wed, 8 Mar 2023 at 23:12, Warner Losh wrote: > > Yea, there's no reason to have the description twice... It looks like the ones that have both WITH_ and WITHOUT_ descriptions are: ATM AUTO_OBJ BIND_NOW CLANG CLANG_BOOTSTRAP CLANG_FULL CXGBETOOL DEBUG_FILES EFI FDT GCC GCC_BOOTSTRAP GCOV GDB GH_BC GNU_DIFF GOOGLETEST HYPERV KERNEL_RETPOLINE LIB32 LLD LLD_BOOTSTRAP LLD_IS_LD LLDB LLVM_ASSERTIONS LLVM_COV LLVM_CXXFILT LLVM_TARGET_AARCH64 LLVM_TARGET_ALL LLVM_TARGET_ARM LLVM_TARGET_MIPS LLVM_TARGET_POWERPC LLVM_TARGET_RISCV LLVM_TARGET_SPARC LLVM_TARGET_X86 LOADER_GELI LOADER_KBOOT LOADER_LUA LOADER_OFW LOADER_UBOOT MALLOC_PRODUCTION MLX5TOOL MODULE_DRM MODULE_DRM2 NVME OFED OPENMP OPENSSL_KTLS PIE PROFILE RELRO REPRODUCIBLE_BUILD RETPOLINE SENDMAIL SHARED_TOOLCHAIN SSP STATS SYSTEM_COMPILER SYSTEM_LINKER TCP_WRAPPERS UNIFIED_OBJDIR USB_GADGET_EXAMPLES ZFS although not all of them are used (the ones that default on across all architectures). Looking at src.conf.5 the duplicates I see are: CXGBETOOL EFI FDT HYPERV LIB32 LLDB LOADER_GELI LOADER_KBOOT LOADER_LUA LOADER_OFW LOADER_UBOOT MLX5TOOL NVME OFED OPENMP OPENSSL_KTLS PIE ZFS Perhaps for these cases we can just skip the negative sense (WITHOUT_), just listing the architectures it applies to? Something like: WITH_CXGBETOOL Build cxgbetool(8) This is the default setting on amd64/amd64, arm64/aarch64, i386/i386, powerpc/powerpc64 and powerpc/powerpc64le. WITHOUT_CXGBETOOL is the default setting on amd64/amd64, arm64/aarch64, i386/i386, powerpc/powerpc64 and powerpc/powerpc64le.