From nobody Thu Mar 09 02:13:30 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PXCQt2h3Yz3xC4P; Thu, 9 Mar 2023 02:13:42 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PXCQt0LNZz3kL7; Thu, 9 Mar 2023 02:13:42 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lj1-f179.google.com with SMTP id i20so348012lja.11; Wed, 08 Mar 2023 18:13:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678328019; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HETtQSm+kUsiu3TQK3OFmqnaMS9dIuzd8fUVkj8WvYc=; b=bj6PBXLoPV5F94OCAcRRrn0H3enHunfnwl8QOppIgPW0xdSVOy6F5pFiMKdhb9MEE+ y1BHKOMiXeQbp+ZL2C5ua4JnHg0168FfOPHGvipNpUMCboU13r2/xJP+/JcAnI57qA2x GIDEoZusP04DXZqeabv4Y0QRdDSEz7sx4slPx81maduA3di45oRuPL99qM6MlBHMGi9L wIa4gop4f6szJvtk16/R33/XsqCUoWMOHElVuJ+GVM7qAoykpH20+PR3mIw9e68UwRod xVvZT57cSv2EdceawcCw9x1rHxPyWXXySAN+JHrgxJJg3ZbNsCV9f+4RdpvbEz7sF6Nx JM1w== X-Gm-Message-State: AO0yUKWM6xMjvGdyq+Wq5XEgiQ76/2aK3WjSLbJdVYqTYvV89xTzs/qL IBH7fsYFKH2irW7EnVdeTknhdF2U4W7V3gc5hbxIlwVMVp4= X-Google-Smtp-Source: AK7set95XfAyizYIpzNRYtDIUVsqycAIygbPm9uH6n++f+8yIspVTOeqQ0zcn65B4/sd5yl5tNB/8DThlBUEuxGmG7M= X-Received: by 2002:a2e:a268:0:b0:295:a8c7:4b36 with SMTP id k8-20020a2ea268000000b00295a8c74b36mr6357497ljm.8.1678328019402; Wed, 08 Mar 2023 18:13:39 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202303082331.328NViDn050541@gitrepo.freebsd.org> In-Reply-To: From: Ed Maste Date: Wed, 8 Mar 2023 21:13:30 -0500 Message-ID: Subject: Re: git: c581962414ed - main - src.conf.5: Add some WITH_/WITHOUT_ option descriptions To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4PXCQt0LNZz3kL7 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Wed, 8 Mar 2023 at 18:34, John Baldwin wrote: > > On 3/8/23 3:31 PM, Ed Maste wrote: > > The branch main has been updated by emaste: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=c581962414edfc26796319ccc988647b08b03ce1 > > > > commit c581962414edfc26796319ccc988647b08b03ce1 > > Author: Ed Maste > > AuthorDate: 2023-03-07 18:49:23 +0000 > > Commit: Ed Maste > > CommitDate: 2023-03-08 23:30:45 +0000 > > > > src.conf.5: Add some WITH_/WITHOUT_ option descriptions > > > > Reviewed by: markj, brooks > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D38961 > > Hah, I was just working on those, but I noticed that we don't have > duplicate WITH/WITHOUT options for other options so kind of punted. We already had (some) duplicates for options which have different defaults per architecture, like LLDB. These ones (plus WITH_LOADER_VERIEXEC_VECTX) were the only ones missing when running `make makeman`. I think there is some value to providing the list of architectures for WITH_ and WITHOUT_ defaults. Perhaps we could rework makeman to look also for a single option description (without WITH_/WITHOUT_ prefix), producing something like: WITH_LLDB / WITHOUT_LLDB Control building of the LLDB debugger. WITH_LLDB is the default setting on amd64/amd64, arm64/aarch64, i386/i386, powerpc/powerpc and powerpc/powerpc64. WITHOUT_LLDB is the default setting on arm/armv6, arm/armv7, mips/mips, mips/mips64, riscv/riscv64 and riscv/riscv64sf.