From nobody Wed Mar 08 23:38:31 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PX8061s5tz3x2j1 for ; Wed, 8 Mar 2023 23:38:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PX80603zHz3Grf for ; Wed, 8 Mar 2023 23:38:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52a.google.com with SMTP id u9so305312edd.2 for ; Wed, 08 Mar 2023 15:38:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; t=1678318722; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Pycem6pmiBq8l+cEo58DNoHW6ArlOwgwNOenDogrRew=; b=kZxxRkMaodyfqgF58Q5y6w1XIeeIvq9HU+rrjzvfZswq5teI1F+HOHA8w+qWPALsAw EzWtmj0DY2hf5fNtA53TOmsUYhWAhF8fOaWKr8f2vQugtNA+cbOcUd9CR9QYuS5rwSQQ z+Kadao59cUlxynkBh2/aza0T8maX89zZWt+YB7O1KBw37XXpEeDBPWOEUID7VwY2xXC CYNtNpuG+/6HFvGyPwRZ2+BJF9MorUGFTHDznRz1Aov9iuCzAFULFTdic2mrybgfo3lf 6f3XbTalwiUfUbAY5hosWVyU4NI61hCFxC35lMOH/8w5KU9xwFm0929uza3VyTnF76Wf fyKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678318722; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Pycem6pmiBq8l+cEo58DNoHW6ArlOwgwNOenDogrRew=; b=v6MZayWUx2n+HwwNr9pYPNMsbs7k3OPrd7TqWH8u9Tm+q2uZ9iVVkWn1o2tWqRI7mT RO+/Ps58ACiOmjopvIxCriiQwF0h6Blysl4W9EWvND4Z7ZCjZIZxEgP58aqM/ZBZRxGT YDXvqVkwqSOgNoqPxWi7Wkj6/aJxZ9qK0LiJzj85UCfvRbsj9XAlhVttbjUfOb7IyFny Xwu2YfK1TAGLO3X2HyPDlDlTydrYwRU2j+vIPo0xbJAhGRNFGVwfGbWXjCkDGGlGokyj aZzz1qK39K2vwma6xM6NLOmc7YOZ3/geHX4PaZCserIzC03WouHbmbuLwPLIoFrLff3s Or1g== X-Gm-Message-State: AO0yUKW7hdoBsulPIpGhvhKKP1fSrYLo9wtsG4UWgAptJtHKanVe4/zh T/btVA4le9oiutupacsCIxeAUYA7j+PWKRA2ZJHdEw== X-Google-Smtp-Source: AK7set8GbCJdPV2/FLU/C1hnGgDdKnqYNh/YYWndk3tc+sj0Ubw1KqQhrpdSOG9lHQ9p7brD0LIS3dsWvgwQe/VPikE= X-Received: by 2002:a17:906:7056:b0:8e5:1a7b:8ab2 with SMTP id r22-20020a170906705600b008e51a7b8ab2mr10074050ejj.4.1678318722328; Wed, 08 Mar 2023 15:38:42 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202303082331.328NViDn050541@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 8 Mar 2023 15:38:31 -0800 Message-ID: Subject: Re: git: c581962414ed - main - src.conf.5: Add some WITH_/WITHOUT_ option descriptions To: John Baldwin Cc: Ed Maste , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000043bae405f66c0705" X-Rspamd-Queue-Id: 4PX80603zHz3Grf X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --00000000000043bae405f66c0705 Content-Type: text/plain; charset="UTF-8" On Wed, Mar 8, 2023, 3:34 PM John Baldwin wrote: > On 3/8/23 3:31 PM, Ed Maste wrote: > > The branch main has been updated by emaste: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=c581962414edfc26796319ccc988647b08b03ce1 > > > > commit c581962414edfc26796319ccc988647b08b03ce1 > > Author: Ed Maste > > AuthorDate: 2023-03-07 18:49:23 +0000 > > Commit: Ed Maste > > CommitDate: 2023-03-08 23:30:45 +0000 > > > > src.conf.5: Add some WITH_/WITHOUT_ option descriptions > > > > Reviewed by: markj, brooks > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D38961 > > Hah, I was just working on those, but I noticed that we don't have > duplicate WITH/WITHOUT options for other options so kind of punted. > > The description for WITHOUT_OFED can be slightly simplified to use > the "Do not build..." pattern which is the more common idiom btw. > I've always wondered why we need both... can't we just have a generic description? Warner > --00000000000043bae405f66c0705 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Mar 8, 2023, 3:34 PM John Baldwin <jhb@freebsd.org> wrote:
On 3/8/23 3:31 PM, Ed Maste wrote:
> The branch main has been updated by emaste:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc581962414edfc26796319ccc98864= 7b08b03ce1
>
> commit c581962414edfc26796319ccc988647b08b03ce1
> Author:=C2=A0 =C2=A0 =C2=A0Ed Maste <emaste@FreeBSD.org>
> AuthorDate: 2023-03-07 18:49:23 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Ed Maste <emaste@FreeBSD.org>
> CommitDate: 2023-03-08 23:30:45 +0000
>
>=C2=A0 =C2=A0 =C2=A0 src.conf.5: Add some WITH_/WITHOUT_ option descrip= tions
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 markj, brooks
>=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0The FreeBSD Foundation >=C2=A0 =C2=A0 =C2=A0 Differential Revision: https:/= /reviews.freebsd.org/D38961

Hah, I was just working on those, but I noticed that we don't have
duplicate WITH/WITHOUT options for other options so kind of punted.

The description for WITHOUT_OFED can be slightly simplified to use
the "Do not build..." pattern which is the more common idiom btw.=

= I've always wondered why we need both... can't we just have a gener= ic description?

Warner
--00000000000043bae405f66c0705--