From nobody Tue Mar 07 23:25:42 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PWWlW0XSJz3wnSW; Tue, 7 Mar 2023 23:25:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PWWlW00CPz4CSj; Tue, 7 Mar 2023 23:25:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678231543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Sr9ss4uUqtHz2nGIn5LMZ+TZrO5RMrAu943j6v9kzrg=; b=SityspzTmCaRfgTGanJeXJ7Y4k6KJ6jLPh7BEhvO9xyky9RBwreEdePyHUG/HxErUODOht BE2pGqGnZ0BBjLtSIhkRjfZKVk9WeSAvPTnMW4NKG4tcG5i3gTdhdXxGKgLW6eqvKPE+We WDjAWw+2izxzuZ2PpoI+fsc/svNydXmTd1s5qgmY8roJmPbFiYQy403n+jyvYML2ToMEqS zeQcvVYIWh8cIRdZTrhrUhNZ6UVlEhoNoG2TAlGRIt4YUj600LmC1rfGxZauVGhnYPWJPL qzUT+ohrqSncm8I4V6DBZhaVhE9yDsIsaSkNjJyfMExUEzAV42i+UjuKhL9+Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678231543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Sr9ss4uUqtHz2nGIn5LMZ+TZrO5RMrAu943j6v9kzrg=; b=DN1iBU/ctvgpdPUpTiayK8xYkH3RiNnpuYWebBdm5LydlJoeENTEe1035fg5fJeHEEdf6J VH6SOpGmhotfdr14jH+PU9qHTRaoMbGFZR+K7NDaWl/CCZq/tDNGTvBBYRof48kZAsUMrM 03IfhjPMKZBLhCq0Thzf1Se7bca04Vx4mMCxYGImz5WDtYYS1Fq10rb0z4cMS7bSR9HRDQ auTwK0XHYn4zo0Mfg3VSFddNDHoK89wknv7FWNOD5umGjyCprX6BrmH+X1GQc8mJlfCd4E ByLPmtTDEMB1XdBoVeiEQPtfFLqrlAAxTugdtrOyfdom4aGBKGZc+DGAf1tDFQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678231543; a=rsa-sha256; cv=none; b=Tg/R5W6fWkbAd+Hcbv6pXJ/SLI+Aj835+eWrmYBOj15QdVHH5gl7wDkq5IDcEl4q/CMHyC SwSqZVmGNa8teQiploHtdAFe+pGEtJXu04h9GkoeGgjIV7FIuJlrqS71+0G71n/3f1T0mP NCtb1O5UBE3Bj0L8RfCD+/mh0sH2QtNSQVGQnuHybene1gUkSOSPbfF7wzkLqfdYITzPl9 Ez2htj2qvyDtZ/2E+hUbRlDL5Pr9rMtpW2r0HHOftKjbSWxi14Lgljbz1NS533A3cej9jK +JbWcA9+F9H/YDY8UBEApkIQZGnJxAUy+0gZ4VzXZr+m9y+rno/gyk4WeXGPNw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PWWlV68DMz12x9; Tue, 7 Mar 2023 23:25:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 327NPguh064868; Tue, 7 Mar 2023 23:25:42 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 327NPgsl064867; Tue, 7 Mar 2023 23:25:42 GMT (envelope-from git) Date: Tue, 7 Mar 2023 23:25:42 GMT Message-Id: <202303072325.327NPgsl064867@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 109abf744bf7 - main - acpica: do not print warning for missing _ADR List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 109abf744bf76a75e952931f28a4c8a0767d5701 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=109abf744bf76a75e952931f28a4c8a0767d5701 commit 109abf744bf76a75e952931f28a4c8a0767d5701 Author: Yuri AuthorDate: 2023-03-07 23:22:58 +0000 Commit: Warner Losh CommitDate: 2023-03-07 23:25:21 +0000 acpica: do not print warning for missing _ADR Started seeing the following after updating to VMware ESXi 8.0: pcib2: on acpi0 pcib2: could not evaluate _ADR - AE_NOT_FOUND pci2: on pcib2 vmx0: ... The virtual NIC works fine, and the code comment suggests that missing _ADR is not something fatal, skip printing the message if status is AE_NOT_FOUND. Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/682 --- sys/dev/acpica/acpi_pcib_acpi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/dev/acpica/acpi_pcib_acpi.c b/sys/dev/acpica/acpi_pcib_acpi.c index 6a66dfb5012a..59b4c2bf25bf 100644 --- a/sys/dev/acpica/acpi_pcib_acpi.c +++ b/sys/dev/acpica/acpi_pcib_acpi.c @@ -410,8 +410,9 @@ acpi_pcib_acpi_attach(device_t dev) */ status = acpi_GetInteger(sc->ap_handle, "_ADR", &sc->ap_addr); if (ACPI_FAILURE(status)) { - device_printf(dev, "could not evaluate _ADR - %s\n", - AcpiFormatException(status)); + if (status != AE_NOT_FOUND) + device_printf(dev, "could not evaluate _ADR - %s\n", + AcpiFormatException(status)); sc->ap_addr = -1; }