From nobody Mon Mar 06 13:05:26 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PVf2G6nFFz3wtDn; Mon, 6 Mar 2023 13:05:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PVf2G3Qbrz3Gms; Mon, 6 Mar 2023 13:05:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678107926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kuyY2Ucz+psRAgTrO2/a31UERWV7+jfMqwPE7CaEm30=; b=hYkHaWUY4CpXhY0JTctmW+28+mub0be38/c13WozPrhx0gKfmAZxJb1GIxYcssf7Ko3F/P RRqaEVzrEntkhzEH95yWo/Ts2cK+w1KtT4C/XE1fzZl1IEqCEiFC+SZ6MxP4CJsylJcvRQ yKUhXWOq4GSK/18S7LNchUgEVg9UFjh5mpWko5sZQhyfBJuZ1b28T0X+yHE9MZHiDSAaPX raUC9DACQ9JfnV7VfIGqPr+u1XR+pAxY1XVpt37OSVl6omkcGAasM4kSnUJYATE32E5LNd nett939/s3VpACC5+/0pLDPUWUGf6dVJLo3qkpKx8mTJ9Yr2E46RS7YBjrZoDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678107926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kuyY2Ucz+psRAgTrO2/a31UERWV7+jfMqwPE7CaEm30=; b=qwBkCEKh1Na1tpZFAGnnwNDEz+egd6bZZcTeSCxWQJdvkwWODfrKzzJW+CYaWVjg2F9kx4 G4w5dG2mRMU5UVN4DJfViDbFUhEe1lDJbLYA8L54ukbOqJ70/MzXZyRWZSZta9wVMabpT8 R2R4nNRRavjD5BxTGMNNLperyUnf/RDsy5wOYyBjeHJMh/JF1c5K8k9jjieqb7CzuibXHj Gg9SnFLgHRl7Nm1tvflRHYltGSUXAPVUAD96iJJFiyLwhQ0thuZo9rKpZkT0FGKovmLAs6 OQ3FoAIzmDI3ybQTojBWQra+sihxj8PMZv0VTXVbY36OQ7Ylbyc4wEE7sIhKnw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678107926; a=rsa-sha256; cv=none; b=udNI0aHv7O5b55hZKFtFy0e1h/jlnMUUAawN/WaGE6/i2021N5NqjPJ8xEyG4OBLyuPnpT +DCJwuXcOGGMfPPgKJVnSEPF0Jv/aRubxUVmmiXkxY2ro7SNHJnJBFoudMqf5N340YKysc amfIseWhDYfvT13108R0obUknaifziyR02nsAPD2uM1a+tzvkD93U1fb0quUuRLYAOtgGG 2zZm5Oma9W0hJsfYxl2VKCjND51GAXVEpTySw25HV9Z9jeeRuGRvysBlBmC/FCeH4erxXr x1VKhry30AMsCMHsQaeFRt0z1qrNWkbnPWFku0pEZMgkQxUTYztpSVmRTpre6Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PVf2G2VVgz12rd; Mon, 6 Mar 2023 13:05:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 326D5QIw079389; Mon, 6 Mar 2023 13:05:26 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 326D5QlY079388; Mon, 6 Mar 2023 13:05:26 GMT (envelope-from git) Date: Mon, 6 Mar 2023 13:05:26 GMT Message-Id: <202303061305.326D5QlY079388@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: =?utf-8?Q?Corvin=20K=C3=B6hne?= Subject: git: 942525ab47e9 - main - bhyvectl: don't leak nvlist in send_message List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: corvink X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 942525ab47e9cd9277ac426e082366d58d7bbe41 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by corvink: URL: https://cgit.FreeBSD.org/src/commit/?id=942525ab47e9cd9277ac426e082366d58d7bbe41 commit 942525ab47e9cd9277ac426e082366d58d7bbe41 Author: Vitaliy Gusev AuthorDate: 2023-03-06 11:32:17 +0000 Commit: Corvin Köhne CommitDate: 2023-03-06 13:03:58 +0000 bhyvectl: don't leak nvlist in send_message Reviewed by: corvink, markj MFC after: 1 week Sponsored by: vStack Differential Revision: https://reviews.freebsd.org/D38900 --- usr.sbin/bhyvectl/bhyvectl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bhyvectl/bhyvectl.c b/usr.sbin/bhyvectl/bhyvectl.c index 59ecbebdfeae..4aa235e00489 100644 --- a/usr.sbin/bhyvectl/bhyvectl.c +++ b/usr.sbin/bhyvectl/bhyvectl.c @@ -1704,9 +1704,9 @@ send_message(const char *vmname, nvlist_t *nvl) perror("nvlist_send() failed"); err = errno; } +done: nvlist_destroy(nvl); -done: if (socket_fd >= 0) close(socket_fd); return (err);