From nobody Sat Mar 04 06:03:16 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PTDm850wlz3vbdT; Sat, 4 Mar 2023 06:03:20 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PTDm84Mztz3jLQ; Sat, 4 Mar 2023 06:03:20 +0000 (UTC) (envelope-from bapt@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677909800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PeEBVBWVW7CdUhuD0MpFiPJAmRdS0rj+pVxcakykXvo=; b=sVn/Qfvjs+yk9/5NAXBno3lXZeomUgXA1hz7wz2L5KsshAWiQorQLfrZ0Cyd7/7C6jQceF rovKwOaBSkGpKXx67cz4wzEbn+S61gUIuQZrQKgJowQsA03EX22d9pzwc0F6CqBHOISXX7 vBdtLqO7yakVPNxX6iglNej3M0n5drmMuoB7g300rNk+WTrXnS9QWA5DMnYR8HSvtTqWY5 /0tcCdCVDaPbhDMRQjKZ/hn1rz7flCtcWwF6T1y1ZsecBBdVc4AUEgVldzPTJCdBiuqsU8 5PjtBLz1vAYKmIDaeU8ngPXAVmiswWFKmCqJSRBe0c5YXPiyTpCIJwUt/mS94g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677909800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PeEBVBWVW7CdUhuD0MpFiPJAmRdS0rj+pVxcakykXvo=; b=cajBlP5pP3FzqXhaWGwWewnRYyhQ6TMd7jr+8X+a01BaaI1pwtJZjK3TL0Pp0outuR/D4N c0ZZN7E2DiIXRSC63hyFInUiJ3NfWFcmB8VKI2I6x6PfDsys5KpvXmcGHw6JgsyKwQywZv FfZ0q8YnpH8RKlpWsZEyT88tjjKr39zWFXMCkDqesxcfuEwVqVDlyJy0tRqakgK7W8xDm/ KzA6jJwchnOvcP7AlY67cG3zuJuZj5fYlD7FpF+CzlgXIT3AAz06XUOJxJs8RR2gZuSJy8 vAJB3w6d++dVmJq0XOqjUtrd/c4XSNKH6dGRT2RKVElcQ6d7nns/FlEedE/WfQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677909800; a=rsa-sha256; cv=none; b=JgkIofd7nx9GZC34HY4QbzQsqEGYyaVGN0kDkL8UVEzjDZ7UHl29myhq62N4SqMLgKMzJP OVMwsKtuxWa5uXX7LhB85mFsE/6cHXhv+e5a4RME6qfPxE5OY1FKiVDr2DNtI2UuMrmIvp AvppafNeqo6D3MfJuCYEZjdwHQc3K8Wgqw8nMffYxkaVjj4ROOIsravaCLb6ZNC0kEp7cX fKC68JLoJFP+GpxnJ0c2ZbnAzA8XgAuuxitAbLD1fjmRnxIHgsA7YEO4iiEI8QMgYhxkot rlvdWl83uMLNnfS1i/ROhc3lS6lAU4Yw2y/C4zwb74j65opJIn5nR38wfBny7A== Received: from aniel.nours.eu (nours.eu [176.31.115.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PTDm82T5zz1Gh2; Sat, 4 Mar 2023 06:03:20 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from mail.nours.eu (nours.eu [IPv6:2001:41d0:8:3a4d::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aniel.nours.eu (Postfix) with ESMTPSA id E4C181BCEEE; Sat, 4 Mar 2023 07:03:16 +0100 (CET) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Date: Sat, 04 Mar 2023 06:03:16 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: "Baptiste Daroussin" Message-ID: <25c644b8deafb5436c76dbffd48adfd07518f513@freebsd.org> TLS-Required: No Subject: Re: git: a28ccb32bf56 - main - machine-id: generate a compact version of the uuid To: "Mike Karels" , "=?utf-8?B?VMSzbCBDb29zZW1hbnM=?=" Cc: re@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org In-Reply-To: <98A14373-D09C-437D-AAB8-0A140FB46C5E@karels.net> References: <98A14373-D09C-437D-AAB8-0A140FB46C5E@karels.net> <202303011818.321IIXIT067595@gitrepo.freebsd.org> <20230303164028.35766f35@hal.tijl.coosemans.org> X-ThisMailContainsUnwantedMimeParts: N 3 mars 2023 =C3=A0 17:12 "Mike Karels" a =C3=A9crit: >=20 >=20On 3 Mar 2023, at 9:40, T=C4=B3l Coosemans wrote: >=20 >=20>=20 >=20> On Wed, 1 Mar 2023 18:18:33 GMT Baptiste Daroussin wrote: > >=20 >=20> >=20 >=20> > The branch main has been updated by bapt: > > >=20 >=20> > URL:=20 >=20> > https://cgit.freebsd.org/src/commit/?id=3Da28ccb32bf5678fc401f160= 2865ee9b37ca4c990 > > >=20 >=20> > commit a28ccb32bf5678fc401f1602865ee9b37ca4c990 > > >=20 >=20> > Author: Baptiste Daroussin > > >=20 >=20> > AuthorDate: 2023-02-28 10:31:06 +0000 > > >=20 >=20> > Commit: Baptiste Daroussin > > >=20 >=20> > CommitDate: 2023-03-01 18:16:25 +0000 > > >=20 >=20> > machine-id: generate a compact version of the uuid > > >=20 >=20> > dbus and other actually expect an uuid without hyphens > > >=20 >=20> > Reported by: tijl > > >=20 >=20> > MFC After: 3 days > > >=20 >=20> > --- > > >=20 >=20> > libexec/rc/rc.d/machine_id | 2 +- > > >=20 >=20> > 1 file changed, 1 insertion(+), 1 deletion(-) > > >=20 >=20> > diff --git a/libexec/rc/rc.d/machine_id b/libexec/rc/rc.d/machin= e_id > > >=20 >=20> > index 7cfd7b2d92f8..8bf3e41d0603 100644 > > >=20 >=20> > --- a/libexec/rc/rc.d/machine_id > > >=20 >=20> > +++ b/libexec/rc/rc.d/machine_id > > >=20 >=20> > @@ -23,7 +23,7 @@ machine_id_start() > > >=20 >=20> > if [ ! -f ${machine_id_file} ] ; then > > >=20 >=20> > startmsg -n "Creating ${machine_id_file} " > > >=20 >=20> > t=3D$(mktemp -t machine-id) > > >=20 >=20> > - /bin/uuidgen -r -o $t > > >=20 >=20> > + /bin/uuidgen -r -c -o $t > > >=20 >=20> > install -C -o root -g wheel -m ${machine_id_perms} "$t" "${machi= ne_id_file}" > > >=20 >=20> > rm -f "$t" > > >=20 >=20> > startmsg 'done.' > > >=20 >=20>=20 >=20> I really think this file should be defined to contain the same UUI= D as > >=20 >=20> /etc/hostid such that there's one and only one UUID per machine. H= aving > >=20 >=20> two different IDs needlessly complicates things if they end up in = logs > >=20 >=20> etc. > >=20 >=20> It also looks like on Linux virtual machines this file contains th= e > >=20 >=20> SMBIOS UUID just like our /etc/hostid. If /etc/machine-id is suppo= sed > >=20 >=20> to be a portable way to obtain that UUID it should be the same as > >=20 >=20> /etc/hostid. > >=20 >=20 > I agree. I had the same reaction when the machine-id was added, but >=20 >=20thought the requirements were different (in particular, the UUID vers= ion). >=20 >=20If at all possible, the two should be the same except for hyphens. >=20 >=20>=20 >=20> Please have another look at . This > > https://reviews.freebsd.org/D38811 > > file is supposed to remain constant across updates. If we get this > >=20 >=20> wrong in 13.2, applications may have to deal with the complication= s for > >=20 >=20> a very long time. > >=20 >=20 > This should be resolved for 13.2 if at all possible. >=20 >=20 Mike > The requirements are diff=C3=A9rent rfc 422 yes would accept what hostid = format uses still all new uuid should follow rfc422. Best regards Bapt