Re: git: 6b4ef4b16a69 - main - daemon: use braces with 'if' consistently
- In reply to: Alexey Dokuchaev : "Re: git: 6b4ef4b16a69 - main - daemon: use braces with 'if' consistently"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 02 Mar 2023 04:42:49 UTC
On Wed, Mar 1, 2023 at 10:28 PM Alexey Dokuchaev <danfe@freebsd.org> wrote: > > On Thu, Mar 02, 2023 at 03:00:58AM +0000, Kyle Evans wrote: > > commit 6b4ef4b16a6930d91d0d99c4ceb75cd43a7526c1 > > > > daemon: use braces with 'if' consistently > > [...] > > ... > > diff --git a/usr.sbin/daemon/daemon.c b/usr.sbin/daemon/daemon.c > > index edcdf3141fcc..f9c1f73e193c 100644 > > --- a/usr.sbin/daemon/daemon.c > > +++ b/usr.sbin/daemon/daemon.c > > @@ -173,14 +173,16 @@ main(int argc, char *argv[]) > > break; > > case 'l': > > logfac = get_log_mapping(optarg, facilitynames); > > - if (logfac == -1) > > + if (logfac == -1) { > > errx(5, "unrecognized syslog facility"); > > + } > > Not only that I don't quite understand how does this commit really > improve anything, but looks like it's badly formatted as well. > A-ha, thought I had caught all of the style issues but it appears not. Thanks, Kyle Evans