From nobody Fri Jun 30 21:14:17 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qt7PP1VgWz4l5CP; Fri, 30 Jun 2023 21:14:49 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Thawte RSA CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qt7PN5fX0z3qW4; Fri, 30 Jun 2023 21:14:48 +0000 (UTC) (envelope-from sjg@juniper.net) Authentication-Results: mx1.freebsd.org; none Received: from pps.filterd (m0108161.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35UJWP1h008905; Fri, 30 Jun 2023 14:14:47 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=to : cc : subject : in-reply-to : references : from : mime-version : content-type : content-id : date : message-id; s=PPS1017; bh=9+jxShiVyS4w8DshFgqZ/BEl/9GeZ9u3hTiV6nBQHSQ=; b=0oFk29tppYhCkTqyViK8tZMEdLt1YDeEf4tpfMt0ellBJSQsWln8gYmXfTTiv0KOk/GW Chua+S635cIZIZP8pujcNGZnUvzrXBt4M2Vc4lYwzxoQbAKoAAdALFnIMu+0QLA+s/og UQPkeJ8B+ztdE0IIMvjqbHMgpc7/ez5C1Pfe4bXLRfq54SOCvvhHvyz16ZLWgWxMVP0M /lugZWcfEcSGZNkPSkcLCVBdWE15/swVsUjZRfCvQTqLbfGJ3EQXKHNMw+z/t0MqW+yG A7MIHdtV3/5/BY8IWD3oE4y4poeESVyY8b4q3T33FVFxe2kknwMeYxCShr3Wpi+CTsB6 eA== Received: from mw2pr02cu001.outbound.protection.outlook.com (mail-westus2azlp17012023.outbound.protection.outlook.com [40.93.10.23]) by mx0b-00273201.pphosted.com (PPS) with ESMTPS id 3rhscgsvuw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jun 2023 14:14:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WwUohOf9AWYVc8joaPAe7cEqwks85b4tw/We30Vqhl6yLJNlG/q61GyQf+t1ba/VoNjAu5uh1A1VLODCGQgEP/idP5CCwmovm/rRuPoMAz+P94P5Pyx8kJJ3uhSeVzLSLl4lmvJLvauwM39kVa4BReG5Jn5yx8qaYyPuELSlLO/P2ihDjhp0CnEdoJM0vnzbxP4Z/bdRpxMChYJ4kw53UdOATjamj2fXxSpbFc/bfsz/3WdfAlOaEFSbYLXzpgmRhsvtJS9cGkSzRjfo5rxFQgEngd+abxGqZJSP80pxshMC8bQpTmxnKaUoOF+VVfcYobknjZq8Bw6Ec4eU7d7FuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9+jxShiVyS4w8DshFgqZ/BEl/9GeZ9u3hTiV6nBQHSQ=; b=WrQ5Ggy29bwm0wSsZUVTwJ2Qj7hHyLD6W9rvQBs43Rd2vS3ck3Qbrsv6NCUiq52O2TAVD97SVvvVF+vTZiroARQWPzrawv5iMXbqzfBfQVF0wPiCTvhNRRxkibe4srUyyd00ntd8U66qDHMfqD2J8tLcloYSCPx3mAT3y9NA7PRHy/E9wejO+mWP7U7yg8xyHNRJEv4Cefrr5lG4bjy4li8bJpsH8gpYxtphbZdSYCwwENGr/MEqDYwkQcvGVnc8eSc/rpLEIe2AtnwJIekr9oBGbJOrAu6mSMee3UUsetBEl/1S/Ruo6whDGv23wWQ8/72QkZr5oEbf56iOJXkGMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 66.129.239.14) smtp.rcpttodomain=freebsd.org smtp.mailfrom=juniper.net; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=juniper.net; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9+jxShiVyS4w8DshFgqZ/BEl/9GeZ9u3hTiV6nBQHSQ=; b=G3dq3GLc8ytjq87pgzyZE6dV6n0lyyHhO/GX1/1NfTn7fRJnLtbByDYzqO2ZJt6a190qNWQmQAlAtmS2TP5EI0AOteQn+vI+Vk90ogIw7nX634rLljXcCQ0jh2vMlAwmcZ9FNLRWrW8TeAyVnOao0nlGkwPU9Vq6Gk8fKid7dBA= Received: from MW4PR04CA0322.namprd04.prod.outlook.com (2603:10b6:303:82::27) by CY5PR05MB8964.namprd05.prod.outlook.com (2603:10b6:930:2c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.21; Fri, 30 Jun 2023 21:14:45 +0000 Received: from MW2NAM12FT053.eop-nam12.prod.protection.outlook.com (2603:10b6:303:82:cafe::10) by MW4PR04CA0322.outlook.office365.com (2603:10b6:303:82::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.22 via Frontend Transport; Fri, 30 Jun 2023 21:14:45 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 66.129.239.14) smtp.mailfrom=juniper.net; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.14 as permitted sender) Received: from p-exchfe-eqx-01.jnpr.net (66.129.239.14) by MW2NAM12FT053.mail.protection.outlook.com (10.13.181.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.13 via Frontend Transport; Fri, 30 Jun 2023 21:14:45 +0000 Received: from p-exchbe-eqx-02.jnpr.net (10.104.9.15) by p-exchfe-eqx-01.jnpr.net (10.104.9.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.21; Fri, 30 Jun 2023 16:14:44 -0500 Received: from p-mailhub01.juniper.net (10.104.20.6) by p-exchbe-eqx-02.jnpr.net (10.104.9.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.21 via Frontend Transport; Fri, 30 Jun 2023 16:14:44 -0500 Received: from kaos.jnpr.net (kaos.jnpr.net [172.23.255.201]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id 35ULEig7020902; Fri, 30 Jun 2023 14:14:44 -0700 (envelope-from sjg@juniper.net) Received: by kaos.jnpr.net (Postfix, from userid 1377) id 8B5668D794; Fri, 30 Jun 2023 14:14:17 -0700 (PDT) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id 8ACFC8D72D; Fri, 30 Jun 2023 14:14:17 -0700 (PDT) To: Jessica Clarke CC: Mitchell Horne , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Subject: Re: git: 56f3f2d2491e - main - libsecureboot: avoid set but not used errors In-Reply-To: References: <202306300652.35U6qpgP027126@gitrepo.freebsd.org> <667C347E-B7C7-405B-AFEC-F0A0FD0656F6@freebsd.org> <498f3ba2-dc7a-e7d3-626a-76ca68cee5b2@freebsd.org> Comments: In-reply-to: Jessica Clarke message dated "Fri, 30 Jun 2023 18:07:58 +0100." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6+git; nmh 1.7.1; GNU Emacs 28.2 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <76829.1688159657.1@kaos.jnpr.net> Date: Fri, 30 Jun 2023 14:14:17 -0700 Message-ID: <79845.1688159657@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW2NAM12FT053:EE_|CY5PR05MB8964:EE_ X-MS-Office365-Filtering-Correlation-Id: ddccf3f0-03dd-43ca-ffc1-08db79af075a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P4QspvntGycmaFuMnbSZxwBEJzPibLBLDL3ywdWcPra9GJH+BPq8GNWjUAc7iT9e74yxfT/3F0mOIUJ7kWZY9QT4c6JaQRNLVdvPcU6aYSThpRw6oWZOlXVzlegaLOLRGPPKeALaoBOuzxdQJalrIjflht+mQmYoUN+rJGP6w/1s1sS7geuIeSPpVTwF+/izwARXMK/wkVbMFxbHpWK4jug+gO9etxvLOQt19k36HQGH9ivcm27Zdsv2FzyaZM+AtGiU90c7g4fCNJStg8bU7nXwHo93FlrEdvfEVkTYRRkibq++uKQx188tU2xcVTIJLfJIEj4GxhhF4X2boqEF2wyShyHJ4YvurQtf2/PYxXhPjFPucZONMwzO/ZGl5W23jMWR6ad1V11jcTBBu2JdiW4avRM7FW+O/sy1EuPFyzptZjdUyyybG+eUI/KanPjmcFFlMkMMBnWyib4SRZH2xXF5+EDlBmSKXWLXLlNohwlK4Li6ZJbt7dlAel9zctodqsVGhO1qDsSLFRg5mZw4uVOdOs/9Qf7giJgwsF+mSk2Ep5BPR21VgVJ08zWpd359mfO4XY+0zB5lOCSrWAobKXaGC0xmK8WwKvrG9pCsyT0g5ay9tsy7FCSYrlWYVdVX3VyyCdWIXhCGlSY8elGUd56g2+Mc6L1S5C6I2G4316VfkAkpPZT0kIvl5U0UXj6cifX5yzXFIa28Mh3T8t+/RRuhXp06ejAyxjafkMAcIbwwM2ChqJq2hA7H7r+Vl0Y706+adzJrkyyOm7tqN5DTuyv0uBx3064Vy+xFBGGufCPiZKnUmb1aX7CVgdDPlaZY X-Forefront-Antispam-Report: CIP:66.129.239.14;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:p-exchfe-eqx-01.jnpr.net;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(376002)(136003)(396003)(451199021)(40470700004)(36840700001)(46966006)(356005)(81166007)(82310400005)(82740400003)(55016003)(40480700001)(86362001)(107886003)(5660300002)(9686003)(7126003)(6266002)(70586007)(4744005)(186003)(26005)(450100002)(70206006)(6916009)(478600001)(2906002)(8676002)(7696005)(4326008)(316002)(41300700001)(8936002)(66899021)(47076005)(83380400001)(336012)(36860700001)(54906003)(40460700003)(36900700001);DIR:OUT;SFP:1102; X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 21:14:45.2230 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ddccf3f0-03dd-43ca-ffc1-08db79af075a X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4;Ip=[66.129.239.14];Helo=[p-exchfe-eqx-01.jnpr.net] X-MS-Exchange-CrossTenant-AuthSource: MW2NAM12FT053.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR05MB8964 X-Proofpoint-ORIG-GUID: Jzipmdy8BEXSofei7yQ_rjr-uklt1iHR X-Proofpoint-GUID: Jzipmdy8BEXSofei7yQ_rjr-uklt1iHR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-30_12,2023-06-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 phishscore=0 bulkscore=0 malwarescore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 mlxlogscore=261 clxscore=1011 adultscore=0 suspectscore=0 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306300184 X-Rspamd-Queue-Id: 4Qt7PN5fX0z3qW4 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:22843, ipnet:67.231.152.0/24, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Jessica Clarke wrote: > A conditional assignment of the same value that has already been > assigned unconditionally is unidiomatic code generally regarded as a > code smell and should be avoided. In an ideal world that would give a I agree. I've been bitten by __unused recently when porting stuff to linux so was looking to avoid that.