From nobody Tue Jun 20 23:04:08 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qm2JC1Gf0z4gZ6L; Tue, 20 Jun 2023 23:04:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qm2JC0nvvz4MlC; Tue, 20 Jun 2023 23:04:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687302251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+J086pr9kV0lYsRKMeS+F8nEPQ1jmTZs1x7BVcFP5qQ=; b=bILGCUKs1bRVYy3r/e2Z98KtEKHz7ottTHw6+YBl60rr3MdOGHT2L3vMNx1VjavlOIoAQW cbTkqsaNarVsNhyr+elgwmCvsYQYnW+km+wcCYAdc8b2e4YqRwnzaKOfKpQpUJUMCtMpCj DODgVt+3QXJ2DE6iNzsbhfEaTRwmYtIiyfOSUqhb8os8qDyxvewFpJ7qpjki4MIszt2KuV 7c+qgbz51BOy4CWkui9okXcWVd9J6aKCQ5oRqvlY9vXtsIA9UQt8hHz4pmqa740nTNV9H9 Bm3QaJkWhh9PrKP4MTzCuoTadwU5K5uu4vjnbHj+4BOuJ+9yyFmk32cuQWuOyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687302251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+J086pr9kV0lYsRKMeS+F8nEPQ1jmTZs1x7BVcFP5qQ=; b=scCsPU8C5wyQe01Q8+CCOUqm/Zf61EP1c2jKv5dc4sAX52Z60rqOb/5ir2WpG9RkXmW8AL 76n23GT9xZt1ffyAy7HRdsMq3aXdFY71gj5FdamJEGzX0ld5ysTjyqdanrtorGccNBUu7f GgSvEUItVMTd67fD2VrpdfDUThE2cvkFD7WEoedHiK4DPpZ84BA0hWG+gkgd/cdChsx9bw rTO+quztzfmEVgzNMufSo4VZCtzD9RfItESfZPUHwN8pWOqL7Xwqg5cYw/QsUgItME47Al JDeXAWScXXTJI/4s+Hi5mf2MXjPfVDQNqYkDC13t8nL+47RV08xzRrbQmOSwog== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1687302251; a=rsa-sha256; cv=none; b=EHmvCeOadlZzbVtZAmvHJ4QC0yQ0tTr+sdAcxoC7ll1xDGp7YVKUhwFsbCVf1TGhiFT3bO ntTWuDg2sSqKKLGIwso4L4JgOM2A1RFyfWwqOkFd2gMU9XGuSRTBkqY7Mwb5yrvJCcNaxP xWNmE72c97SHdJvz3+4UbRmfGVbtW6KfwT5nkW+sHMwpOdC2fvpmtE+u1uWPCX/z1477Qk u1I67FgWuCKgP/r82g6RqK0tdbqgbpyHSH1btzNWGZ7AfaCPFnZ9QzlMIpR745raIBuHqA Yp2XH1I5mvnopU71SuAcB983wweLHc0+F1EtU4HPGDlQTgpgcE3Q+DPdJVRZMA== Received: from [IPV6:2601:648:8680:16b0:f598:bccf:55da:e3b9] (unknown [IPv6:2601:648:8680:16b0:f598:bccf:55da:e3b9]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Qm2JB3Kbsz1B7N; Tue, 20 Jun 2023 23:04:10 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <86f0e1af-22c6-8b98-fd07-7958094d09ec@FreeBSD.org> Date: Tue, 20 Jun 2023 16:04:08 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: git: 2e2a1c8ecf63 - main - libgssapi: Remove set but unused variable. Content-Language: en-US To: Benjamin Kaduk , Doug Rabson Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202306201629.35KGTDxK044992@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 6/20/23 2:56 PM, Benjamin Kaduk wrote: > On Tue, Jun 20, 2023 at 9:29 AM John Baldwin wrote: > >> The branch main has been updated by jhb: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=2e2a1c8ecf639317f40cdb1c2a0c5b9abe990e58 >> >> commit 2e2a1c8ecf639317f40cdb1c2a0c5b9abe990e58 >> Author: John Baldwin >> AuthorDate: 2023-06-20 16:28:59 +0000 >> Commit: John Baldwin >> CommitDate: 2023-06-20 16:28:59 +0000 >> >> libgssapi: Remove set but unused variable. >> >> Reported by: GCC >> --- >> lib/libgssapi/gss_delete_sec_context.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/lib/libgssapi/gss_delete_sec_context.c >> b/lib/libgssapi/gss_delete_sec_context.c >> index 930f51399cce..b64e32c5dc2c 100644 >> --- a/lib/libgssapi/gss_delete_sec_context.c >> +++ b/lib/libgssapi/gss_delete_sec_context.c >> @@ -41,7 +41,6 @@ gss_delete_sec_context(OM_uint32 *minor_status, >> gss_ctx_id_t *context_handle, >> gss_buffer_t output_token) >> { >> - OM_uint32 major_status; >> struct _gss_context *ctx = (struct _gss_context *) *context_handle; >> >> if (output_token) >> @@ -54,7 +53,7 @@ gss_delete_sec_context(OM_uint32 *minor_status, >> * otherwise fake an empty token. >> */ >> if (ctx->gc_ctx) { >> - major_status = ctx->gc_mech->gm_delete_sec_context( >> + (void) ctx->gc_mech->gm_delete_sec_context( >> > > Looks like gcc was catching a latent bug here -- if we consult the > corresponding heimdal implementation, major_status is initialized to > GSS_S_COMPLETE but this assignment can override it, and the function itself > returns major_status rather than a hardcoded GSS_S_COMPLETE. I'd be more than happy to have this fixed correctly. I've cc'd the original author (Doug) to see what he thinks. -- John Baldwin