From nobody Tue Jun 20 12:33:40 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QlmK05bFYz4fgCT; Tue, 20 Jun 2023 12:33:56 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QlmJz4QsHz4FkK; Tue, 20 Jun 2023 12:33:55 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com; dmarc=none Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2b479d53d48so30378451fa.1; Tue, 20 Jun 2023 05:33:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687264433; x=1689856433; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MkOeBld8ZHrp+Tuu/ED5kXTKQXkWzhtNG57bBt8PWTE=; b=YNmBzNL2ExFyn0zuAM63Ktp0dJ8Fh37zbZAJRdM52b4AKojpk/+NM71RND4zn+G2xK 5F0N3C73lAwhthae9RGkkC7CPrAptCOJdfyCZr/9VR/gIyo04Vk+tuJNhj47/0oFcdWf IEr9SCCHSq3xReVkISYOR/7AMuLsEzNRQ8Ss57drOwKthEDhjt2sNtieXUbSLzW+Ye5C 0vO712l+x6Z8jL585BGl3YOGbV9T2pXGhwQ7Nf9NXUK6h3PJsZcE2BIDM9jqm1YkqZQt ceLIdSMXQLgkJ9X8bjR6KHkAvHOxLgWe2kvctWDCyGFc8lmBZOlzH5LEevUqyQ0noPCP SBDA== X-Gm-Message-State: AC+VfDx8xdfUmkExg4tf2TachS2o3hFQ8PF/ZinuoGIQxqodmABVCcWy 5GLkAIgItTa89e4rQtWzv4lrMJkP8PnVdb7v8sL8nIIi5WA= X-Google-Smtp-Source: ACHHUZ41/Qz4ZAKvsjAnuI+x84VIOTRVq3VSs41ZJTZdE0uw8u5XOVowh09LyOnsIn0nB+PRGEFQ9XaDY/hY8fEB4hg= X-Received: by 2002:a2e:6a13:0:b0:2b4:5fdd:f581 with SMTP id f19-20020a2e6a13000000b002b45fddf581mr5895294ljc.47.1687264432647; Tue, 20 Jun 2023 05:33:52 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202306131816.35DIG90C004375@gitrepo.freebsd.org> In-Reply-To: <202306131816.35DIG90C004375@gitrepo.freebsd.org> From: Ed Maste Date: Tue, 20 Jun 2023 08:33:40 -0400 Message-ID: Subject: Re: git: 21850106fdda - main - libtacplus: Allow additional AV pairs to be configured. To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.93 / 15.00]; NEURAL_HAM_SHORT(-1.00)[-0.997]; NEURAL_HAM_MEDIUM(-0.97)[-0.971]; NEURAL_HAM_LONG(-0.97)[-0.965]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.179:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.179:from]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[carpeddiem]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4QlmJz4QsHz4FkK X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N On Tue, 13 Jun 2023 at 14:16, Dag-Erling Sm=C3=B8rgrav wr= ote: > > The branch main has been updated by des: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D21850106fdda5269bc881f0e62= 839dff3d9edf47 > > commit 21850106fdda5269bc881f0e62839dff3d9edf47 > Author: Dag-Erling Sm=C3=B8rgrav > AuthorDate: 2023-06-13 16:04:22 +0000 > Commit: Dag-Erling Sm=C3=B8rgrav > CommitDate: 2023-06-13 16:08:08 +0000 > > libtacplus: Allow additional AV pairs to be configured. > > * Replace hand-rolled input tokenizer with openpam_readlinev() which = supports line continuations and has better quoting and escaping. > * Simplify string handling by merging struct clnt_str and struct srvr= _str into just struct tac_str. > * Each server entry in the configuration file can now have up to 255 = AV pairs which will be appended to the ones returned by the server in respo= nse to a successful authorization request. > > This allows nss_tacplus(8) to be used with servers which do not provi= de identity information beyond confirming the existence of the user. > > This adds a dependency on libpam, however libtacplus is currently onl= y used by pam_tacplus(8) (which is already always used with libpam) and the= very recently added nss_tacplus(8) (which is extremely niche). In the lon= ger term it might be a good idea to split this out into a separate library. > > MFC after: 1 week > Sponsored by: Klara, Inc. > Reviewed by: pauamma_gundo.com, markj > Differential Revision: https://reviews.freebsd.org/D40285 > Relnotes: yes Cirrus-CI build is failing on occasion, due to a race between libpam and libtacplus -- e.g.: --- libpam.so.6.full --- building shared library libpam.so.6 /usr/local/bin/clang15 -target x86_64-unknown-freebsd14.0 --sysroot=3D/usr/obj/tmp/cirrus-ci-build/amd64.amd64/tmp -B/var/empty -Wl,-zrelro --ld-path=3D/usr/local/bin/ld.lld15 -fstack-protector-strong -shared -Wl,-x -Wl,--fatal-warnings -Wl,--warn-shared-textrel -o libpam.so.6.full -Wl,-soname,libpam.so.6 openpam_asprintf.pico openpam_borrow_cred.pico openpam_check_owner_perms.pico openpam_configure.pico openpam_constants.pico openpam_dispatch.pico openpam_dynamic.pico openpam_features.pico openpam_findenv.pico openpam_free_data.pico openpam_free_envlist.pico openpam_get_feature.pico openpam_get_option.pico openpam_load.pico openpam_log.pico openpam_nullconv.pico openpam_readline.pico openpam_readlinev.pico openpam_readword.pico openpam_restore_cred.pico openpam_set_feature.pico openpam_set_option.pico openpam_straddch.pico openpam_strlcat.pico openpam_strlcpy.pico openpam_strlset.pico openpam_subst.pico openpam_ttyconv.pico openpam_vasprintf.pico pam_acct_mgmt.pico pam_authenticate.pico pam_chauthtok.pico pam_close_session.pico pam_end.pico pam_error.pico pam_get_authtok.pico pam_get_data.pico pam_get_item.pico pam_get_user.pico pam_getenv.pico pam_getenvlist.pico pam_info.pico pam_open_session.pico pam_prompt.pico pam_putenv.pico pam_set_data.pico pam_set_item.pico pam_setcred.pico pam_setenv.pico pam_start.pico pam_strerror.pico pam_verror.pico pam_vinfo.pico pam_vprompt.pico --- lib/libtacplus__L --- ld.lld: error: unable to find library -lpam clang-15: error: linker command failed with exit code 1 (use -v to see invocation)