From nobody Tue Jun 20 04:45:16 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QlYwF4x1gz4gLbB for ; Tue, 20 Jun 2023 04:45:17 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from mail.tarsnap.com (mail.tarsnap.com [54.86.246.204]) by mx1.freebsd.org (Postfix) with SMTP id 4QlYwF3GxPz3Dlm for ; Tue, 20 Jun 2023 04:45:17 +0000 (UTC) (envelope-from cperciva@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: (qmail 20811 invoked from network); 20 Jun 2023 04:45:16 -0000 Received: from unknown (HELO dell7390.daemonology.net) (127.0.0.1) by mail.tarsnap.com with SMTP; 20 Jun 2023 04:45:16 -0000 Received: (qmail 54350 invoked from network); 20 Jun 2023 04:45:16 -0000 Received: from unknown (HELO ?127.0.0.1?) (127.0.0.1) by localhost with SMTP; 20 Jun 2023 04:45:16 -0000 Message-ID: Date: Mon, 19 Jun 2023 21:45:16 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: git: b908f6c45e02 - main - bsd.mkopt.mk: Add REQUIRED_OPTIONS list Content-Language: en-US To: Warner Losh Cc: Ed Maste , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202306200023.35K0NSlA057479@gitrepo.freebsd.org> <60984493-01fd-d02d-496e-1c973cdda2f7@freebsd.org> From: Colin Percival In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4QlYwF3GxPz3Dlm X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:14618, ipnet:54.86.0.0/16, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 6/19/23 20:46, Warner Losh wrote: > On Mon, Jun 19, 2023, 9:14 PM Colin Percival > wrote: > On 6/19/23 18:18, Warner Losh wrote: > > On Mon, Jun 19, 2023, 7:04 PM Ed Maste > > >> wrote: > >     On Mon, 19 Jun 2023 at 20:23, Colin Percival > >     >> wrote: > >      > bsd.mkopt.mk >: Add REQUIRED_OPTIONS list > >      > > >      >     Options on this list will be forced to 'yes'.  This is > intended for use > >      >     as a transitional measure when an option is ceasing to be > optional, > >      >     before all of the associated make logic is removed. > > > >     Should we emit a warning when an option is disabled in src.conf but > >     specified in REQUIRED_OPTIONS? > > > >     e.g. warning: WITHOUT_CAPSICUM option ignored: it is no longer > supported > > > > I asked for this in the review... I didn't approve the review because I > was > > waiting for an answer to the request. > > I'm happy to add such a warning, although I'm not sure how useful it would be > (unless we add a 'sleep 60' afterwards perhaps?), but I don't see any such > comments on the review... did phabricator eat it? > > > People will see it. No sleep needed. People read the logs. > > Maybe I was too subtle since we went down the does := work twice... D40613. -- Colin Percival FreeBSD Deputy Release Engineer & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid