Re: git: b908f6c45e02 - main - bsd.mkopt.mk: Add REQUIRED_OPTIONS list

On Mon, Jun 19, 2023, 9:14 PM Colin Percival <cperciva@freebsd.org> wrote:

> On 6/19/23 18:18, Warner Losh wrote:
> > On Mon, Jun 19, 2023, 7:04 PM Ed Maste <emaste@freebsd.org
> > <mailto:emaste@freebsd.org>> wrote:
> >     On Mon, 19 Jun 2023 at 20:23, Colin Percival <cperciva@freebsd.org
> >     <mailto:cperciva@freebsd.org>> wrote:
> >      > bsd.mkopt.mk <http://bsd.mkopt.mk>: Add REQUIRED_OPTIONS list
> >      >
> >      >     Options on this list will be forced to 'yes'.  This is
> intended for use
> >      >     as a transitional measure when an option is ceasing to be
> optional,
> >      >     before all of the associated make logic is removed.
> >
> >     Should we emit a warning when an option is disabled in src.conf but
> >     specified in REQUIRED_OPTIONS?
> >
> >     e.g. warning: WITHOUT_CAPSICUM option ignored: it is no longer
> supported
> >
> > I asked for this in the review... I didn't approve the review because I
> was
> > waiting for an answer to the request.
>
> I'm happy to add such a warning, although I'm not sure how useful it would
> be
> (unless we add a 'sleep 60' afterwards perhaps?), but I don't see any such
> comments on the review... did phabricator eat it?
>

People will see it. No sleep needed. People read the logs.

Maybe I was too subtle since we went down the does := work twice...

Warner

-- 
> Colin Percival
> FreeBSD Deputy Release Engineer & EC2 platform maintainer
> Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
>