Re: git: b908f6c45e02 - main - bsd.mkopt.mk: Add REQUIRED_OPTIONS list

From: Warner Losh <imp_at_bsdimp.com>
Date: Tue, 20 Jun 2023 01:18:08 UTC
On Mon, Jun 19, 2023, 7:04 PM Ed Maste <emaste@freebsd.org> wrote:

> On Mon, 19 Jun 2023 at 20:23, Colin Percival <cperciva@freebsd.org> wrote:
> >
> > The branch main has been updated by cperciva:
> >
> > URL:
> https://cgit.FreeBSD.org/src/commit/?id=b908f6c45e0202deb86fc9bde1b07212924c05fc
> >
> > commit b908f6c45e0202deb86fc9bde1b07212924c05fc
> > Author:     Colin Percival <cperciva@FreeBSD.org>
> > AuthorDate: 2023-06-17 20:08:37 +0000
> > Commit:     Colin Percival <cperciva@FreeBSD.org>
> > CommitDate: 2023-06-20 00:23:09 +0000
> >
> >     bsd.mkopt.mk: Add REQUIRED_OPTIONS list
> >
> >     Options on this list will be forced to 'yes'.  This is intended for
> use
> >     as a transitional measure when an option is ceasing to be optional,
> >     before all of the associated make logic is removed.
>
> Should we emit a warning when an option is disabled in src.conf but
> specified in REQUIRED_OPTIONS?
>
> e.g. warning: WITHOUT_CAPSICUM option ignored: it is no longer supported
>

I asked for this in the review... I didn't approve the review because I was
waiting for an answer to the request.

Warner

>