From nobody Fri Jun 16 20:05:19 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QjVWj5kG3z4dnC8 for ; Fri, 16 Jun 2023 20:05:21 +0000 (UTC) (envelope-from jrm@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QjVWj5H4Jz4BN4; Fri, 16 Jun 2023 20:05:21 +0000 (UTC) (envelope-from jrm@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686945921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZufTHqITvMXc5JzjoEDex+4hQ+E+FM3FYFXSxy/AXOc=; b=p2MYQZT3Y9tRXwC/bKK6DkglatRMM1701d16ho/bt6wKHCb0BnFtjK2lriAgxGOkVqutwv XsOvf2a30kUpUoanNvDgxZcUi0M0aBD5AXeo/NDD/D+ix8JfDSXLkSFuLspozEX0pWi1Yo sAlf01hw8xNM0IwufPZYGoGPZ6T/dGiXeS2kJgj13iBuMB9cQggkKNnuKLeLfnBNguELyQ ns4HBSxxMozwrLpbIKxgiCjnMPFs63mFdPe5dS6VKd0r1Eyr71AmZnK40wXn7QQTG0o9mw RaBkfXt6KdaXsjaznzcm5DrLs1QQL+AX/6YT1UkkTO5qqZFm/1rY6Y0iIiUWlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686945921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZufTHqITvMXc5JzjoEDex+4hQ+E+FM3FYFXSxy/AXOc=; b=B1ZTsgDqaHn0WISy3FAo/zLkr8YAaTbhi8vo8cY639mvregVUyPmVQwxH44HLQyN5+7zdT RvT/Qlb83RaPxZ+w2gpKsqZHvh4u4bpmtiPFmSMpZdjSCW9rV4ZtvAamF6/wDvcL4JQrOa yMBWkqrhzVN2wGowDciXs5/iru5oHMbUkRe7tSZQ9zHTnHrZvSAWEf6SzAQ2gXVvy0uEwm WXQa8S/K9fExoCseYGTCknvN5Q46ypDa5a4EMfittDdduWC8C3+p6pI9cQEOvWmjNyyipr B7+xJf95nMyU3o7YYMhP6VJ6k6YE/Q1PsbIeJV9EtZ1eAlG8HyBSomxYfyQwjQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686945921; a=rsa-sha256; cv=none; b=YDlhsKTSBR1+62z3hOuL6IP/PQPNNJj7dDSPRFKmLiQ3+NcG3zdAqjN5ra+TMp/gPYSiC7 mCEBZ7fKoIw3vS8Ueg+Dz4au/A1zTwaaEjzjPpH4CEVo5o6htnR/0fUlbW0IP9kryEVenm rAdwbZ0vMROrUCyvEMzYnOLyeJLIiHVFeAvjOH/zGJYULd8t1kVyzTFEOszNT64HeEI/uf WbQm0BxP5g2GbBV4ZgUvAzHTuR8zIMUPyVTG6+gtjqSFglY6c84vJ4KdXw+u2zqr2ySCUD kLCYPNmIVGth1UgbWnCama6Hcdoq5xNE5QI1CibQLdRON1rK88CnRuevvcG6Ew== Received: from phe.ftfl.ca.ftfl.ca (drmons0544w-156-34-187-123.dhcp-dynamic.fibreop.ns.bellaliant.net [156.34.187.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: jrm/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QjVWj2VSWzSS1; Fri, 16 Jun 2023 20:05:21 +0000 (UTC) (envelope-from jrm@freebsd.org) From: Joseph Mingrone To: Gleb Smirnoff Cc: dev-commits-src-main@freebsd.org Subject: Re: git: 171a7bbfc048 - main - tcpdump: fix build with WITHOUT_PF=1 In-Reply-To: (Gleb Smirnoff's message of "Tue, 13 Jun 2023 21:01:16 -0700") References: <202306140359.35E3x4fJ060841@gitrepo.freebsd.org> Date: Fri, 16 Jun 2023 17:05:19 -0300 Message-ID: <865y7np400.fsf@phe.ftfl.ca> User-Agent: Gnus/5.13 (Gnus v5.13) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-ThisMailContainsUnwantedMimeParts: N --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello Gleb, Thanks for reporting. https://reviews.freebsd.org/D40578 Joe On Tue, 2023-06-13 at 21:01, Gleb Smirnoff wrote: > Joseph, > I guess there is also regression with pfsync printing. Didn't check with > real traffic, but: > # grep pfsync_if_print * > grep: cmake: Is a directory > grep: doc: Is a directory > grep: lbl: Is a directory > grep: missing: Is a directory > netdissect.h:extern u_int pfsync_if_print(netdissect_options *, const str= uct pcap_pkthdr *, const u_char *); > print-pfsync.c:pfsync_if_print(netdissect_options *ndo, const struct pcap= _pkthdr *h, > # > Doesn't look used. > On Wed, Jun 14, 2023 at 03:59:04AM +0000, Gleb Smirnoff wrote: > T> The branch main has been updated by glebius: > T>=20 > T> URL: https://cgit.FreeBSD.org/src/commit/?id=3D171a7bbfc04885150401ab6= 4d96793373a8b2061 > T>=20 > T> commit 171a7bbfc04885150401ab64d96793373a8b2061 > T> Author: Gleb Smirnoff > T> AuthorDate: 2023-06-14 03:58:36 +0000 > T> Commit: Gleb Smirnoff > T> CommitDate: 2023-06-14 03:58:36 +0000 > T>=20 > T> tcpdump: fix build with WITHOUT_PF=3D1 > T>=20=20=20=20=20 > T> Fixes: ee67461e56828dd1f8de165947ba83f6d9148a87 > T> --- > T> contrib/tcpdump/print.c | 2 +- > T> 1 file changed, 1 insertion(+), 1 deletion(-) > T>=20 > T> diff --git a/contrib/tcpdump/print.c b/contrib/tcpdump/print.c > T> index 9c0ab8622de1..42a4548e8689 100644 > T> --- a/contrib/tcpdump/print.c > T> +++ b/contrib/tcpdump/print.c > T> @@ -185,7 +185,7 @@ static const struct printer printers[] =3D { > T> #ifdef DLT_LOOP > T> { null_if_print, DLT_LOOP }, > T> #endif > T> -#ifdef DLT_PFLOG > T> +#if defined(DLT_PFLOG) && defined(HAVE_NET_IF_PFLOG_H) > T> { pflog_if_print, DLT_PFLOG }, > T> #endif > T> #ifdef DLT_PKTAP --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKkBAEBCgCOFiEEVbCTpybDiFVxIrrVNqQMg7DW754FAmSMwH9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUQHGpybUBmcmVl YnNkLm9yZwAKCRA2pAyDsNbvnh3vD/0b9g75P0RCKMsYDatgcftCS46NqOpDpxmU wjVmc2CLE59cD0QiHjPe6MXpRvvJEip1iCFUj9W6P5NR71qaVVzNGc2J49UVcz1d 61sSb58AKcmaWM62FfrK6xeYxRL5z5Skag647T5oXWvksp7HPX+NmProseTp4wY7 GI8KsZJgLXwI9YGda3iDK1eJ15OLduq5C6z4c7/8mRUUye1PiTwCgub3NCJkswd2 kZv5o2PERpFR4L2/jq/ep0x+tSjbjDybHBA3v1EOIBrI9I6kzp2m4679UOSxwNXR faadMGW9Eh5phGJt5El4IWEjhgs7w/SEHL0/wzfMMvXrzrK5u13m7jTHHg16LscB Gt73qlQeW9Y1Kx9pNQ1cM631UoiYNP5V5gg/y6cwaVUpqQdVKBaqch7kZ3rLtpLn i4KDZB0zeWbOxf42KkN77rsJDfk6lDt6f+weX2FvyF8s40b5TTnMGZl4YDVnTp33 k3UzibllxmhDHkhnMclMU9mCLkhCXEgcC/kwt7aJVvXceiUfZQgG9jMljEkknfLu sPjmfaHPuUojjXmK7Z6qGJEOQKw57cjaS34+Ul31YsRIM+e+bMRRwHCB44cJoQAq CQpf+7I6paQgeW1AVFTljDU4lCIG0NFtzY1KqWroXBuoP3GTKQKkOCL7WvvD8Rvr ru1aHSKHoQ== =ZgOJ -----END PGP SIGNATURE----- --=-=-=--