Re: git: 1b0d96f3c43a - main - xregs_sig: Finish renaming simd to xregs before adding avx
Date: Sat, 03 Jun 2023 18:57:03 UTC
On 3 Jun 2023, at 19:50, Dmitry Chagin <dchagin@freebsd.org> wrote: > > On Sat, Jun 03, 2023 at 07:05:48PM +0100, Jessica Clarke wrote: >> On 3 Jun 2023, at 18:13, Dmitry Chagin <dchagin@FreeBSD.org> wrote: >>> >>> The branch main has been updated by dchagin: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=1b0d96f3c43a5f997dca120a83a4b06995df345b >>> >>> commit 1b0d96f3c43a5f997dca120a83a4b06995df345b >>> Author: Dmitry Chagin <dchagin@FreeBSD.org> >>> AuthorDate: 2023-06-03 17:11:44 +0000 >>> Commit: Dmitry Chagin <dchagin@FreeBSD.org> >>> CommitDate: 2023-06-03 17:11:44 +0000 >>> >>> xregs_sig: Finish renaming simd to xregs before adding avx >> >> Isn’t this the wrong direction? “xregs” sounds specific to x86’s xmm >> registers; arm64’s q NEON registers are definitely not “xregs”, those >> are the standard GPRs. >> > NEON registers is not GPRs, here xregs is all non GPRs, ie, sse, avx, > neon, etc. But the AArch64 registers are called x0 through x30. They are x registers. So calling the SIMD registers X registers is both incorrect and highly confusing. It is not general, it is specific to x86’s notion of SIMD. Jess >> Jess >> >>> Reviewed by: kib, jhb >>> Differential Revision: https://reviews.freebsd.org/D40382