From nobody Fri Jul 28 00:22:45 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RBpJ75DYzz4plM0 for ; Fri, 28 Jul 2023 00:23:03 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic303-25.consmr.mail.gq1.yahoo.com (sonic303-25.consmr.mail.gq1.yahoo.com [98.137.64.206]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RBpJ627tsz3Cgn for ; Fri, 28 Jul 2023 00:23:02 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=IujQW0Kt; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.64.206 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1690503779; bh=RsiPI1hIbCPClu5iBwFY2mx2/22YS1Pk+2Dr0+ESEvQ=; h=From:Subject:Date:To:References:From:Subject:Reply-To; b=IujQW0Kt9n+m0XZjDdOUGJxXoyKfNiRgq2Va7O50H/hPfRLgeeedVd0uqTPFyIDAPhvjX1i5P7S42MaQtNW3M3oktYB70w1A4qGJiIbU0tZkTOpGRsxdJWhEdPdIMytOGiygCPKLYOemF/wW73KUjQ8sARAKiTJMVxQGjk6EzCQmvPPSDoP9HzVZkv2XP3kDpttX5L1ZdLOBjyMdjtcmkftsUUEf4o4FUUoJ8xQeyRTyKERl27bro4+i46oUk2P5qTOT7gQc5Tp8dFnOqnWpa9vZUeoHoujWUp2GKIbbU0mJLUxoKPbhJTjnDeBrgUkNC2/e+3l4BqurU7geNilzeQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1690503779; bh=iYN5iPdXHXz6VxLqQZu3DP/BNkpuB/oyVvYXXBsfU0S=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=nKZDGajRIogD2EIT34BjzvQnnhm+hRtiBsMZA2Cu6MeUwE0CpF2IQxcmUszmMs/cAT72hiT0Tt6GXXLjGyj4qsEbewhXcIp8VPm+TPL8Sr7s7NZ7t7r9+Yc4h7UITDBrRzBpg5uKzMV/xOv/SLZTEkKHSDwPUU1pXHQhxD5Mi4ZxaE6DWHJt6nPjAHESi11XRPjvWP0JgCykzY/eoXFl8VmQiM0zzb0I1447zrArt/t7j1U/e4PvLaKjhK1v21PYJY5ZG9pLXfNBad81cnw0xBD9HQY6qnl8+JPV1twx9R7GOYGGHrtbn8bKmM/dzh4W3I+Kumu7vFfll5jslNT0ug== X-YMail-OSG: mEHjbyYVM1kJkd2AZIUZ.RUpJO7Ay2XaimrJssNfTHuNkwz8JRpYyd2Ged2lqhC fO.OZFYCOVkpROH1GOVWaKUI0oFzqi2.U9nLICSLEnGOVZp03W8xRtrADenMpLqWYU3isf.EYu_h RPJ5p3.v16IFqIJeZJmuuIJonCr04ZQnzSTJAlhiXEV3l8oyfAGNu7R.T.OGaOliHGKQFNx_yfnr IugY4wWBvCjUvFYOkqFQ5f6LqnQYY0m1rIRvN2nQzRrmU4Jifj0hxmokKk2aME39vO.s9rzwoK7Z LVPwC03HfyErjU.BZwNTabM_kbPd2R0ZDfCi8.g9hTSrwga75WI.RdzESfvBw1MLWHHcq_bR8NfZ 1nebTMuS4t2rmZp_6diawhC6B1hjeDt94spbRGHC9hoYdn7r9CsVyAjJ2g_BOywTx3SyKFUCPrTU JHHVBI1qNA8a6BS97HTeIftIuTqBzHZRjFNOPUERuOhzNJciGJ59fwMowtYU1.9qfLVs4IX49l9M ClgaCp5Dk9sFuJ1zvzboJcJRF.J3_gsppQBLZNFMy0qv2XJwmJupi_jZK9GGfn5Td9Ot6cchWpoV d27ChdCyufirafvVLlAS.eDXERRh9BA2PsSiXsChqLq410mdtziAJj40WJhX7tY1F9KL8DkbGFjR gls.w2xtLxzADvArFte3mCX5XIdUF3YLaphuuIpRyT1XeRFa3UmJu.mw4mfNxihBnV_TrFj0QRcX nLxayUDWiurZbGo4k0lbwgxjwnNhsgAc.sfbfidUfXxUmM5.cQBoulWKIa9e40k5pcECjLvNfpMW BCS.s0PZGQ4wadP9qFP1vvCrKCfZnhMzvydr6oEL4.jB62wf4ZI.p_aWZys.hR06JwUCDzdpagJK kZY6jWFg6uu65JDCaCuukM.0MJFUYRokSnWYWx9038ymdzD2KoZqabimAh1QXl8PK9TF.ZbKNDmy Bms4PRPOv.pVaUiEKndVAJ48i7SibB.L8FUaoPIBCkxcQlW0Q4_y3ApmQZ59qGJxW_ki8DJxVyYF N0pi_kuKmMV6E.AF0j7ZVVxP5_cNgWviR.tdo9Zksgm7.0.OtdoyHsBO0WGdNpgWxZs7N9x9U_VR d1010YlZLwStiLG3312gXyba00_vpyK3aOgCUXyDtJQzSQzr5xXV..tuUl2ZhfcPXJaL6BPGpgFU GZweXWN_Gz67uwt978IDFGsL73yqMo.PeLTLgXMDZ0hBBkH3qdm_i3VzYpWgXBPiQ2Dj6850TA_L iqHWCIbBaDF8xkd5jXcvbCWu0u9oRa6xMmA_JsvCzkJZb71kBjlBJryjSqp.tpviZ7853LiljMwH sUHOGblzoIn4uRqLAC4K3gecsGb2nfhmBrVgn04ztBRh0hz4gPmVJZO_idx0v0KkhkEXfwuxcEuc rRGtNAtaVmU68sjtPx8gDj.4TEgRQnE1dg2VThPHLHVC1KcShXgXdmDvLt7RqRUjnaLC0VrvphRG YoaZy3L.VAK8xBSa2co5dAv7eGiX8hYbkHA9zsjF3KUDKUFroLWVm.8Kq.cMf_OD0_xshVWrYMAm qSagAZmd.0qZphAUQAp8SzS5RTjzBv_7N2iF2f8YWC8l_vBo8ATYPbCJFMivKyl26R8sJYxrqeek mbJLcXuWMSDO0lUs0SE_vaCZaYteuBM3MLRfK3bFNQl3ZEDg8QGejE6WEE.bXsVtHBzP4Ltinxl6 9H8tJlnhi6vdywuwzKUB.6Em0mJN3cOn6ngoHk0dFR7Bkzm2DMquR8IgfCCAKjoD1aj6gyMnBIpU wzNiM6ThSKfEehBUM0DspQ08zr0XJvWh4kVkffT97pp0_9WnbolMzggxwMG9kFZiHehNdqME_gAB yhAzm1tq1Ggw0FBSMtXOqKFihhNUb67_rYuRGXrEvdFr9sTmkrxzn7f3oSRmabFXTc3tGh8WPGHy Ktq1HkLnalx7EIFbpTBps8tLDlwc5HiLjR7I2GNTh5gb316G3CipGQuXnBKHATSz2wDWEG7za4Fi 7yoq2X0sD4FKMF7EUbs8_FFdtxnzwXBzd8ck3W9Zf2EWbd27IHTcYq..EfVn5ijujcsxDkRhOpQJ 6vGFpji0LeLmAekPKFrPYrEiKXkDctejrOfoLevQANSyeWH.Eb8a6m9jpH5KDW5Fqhj1urS.KPFN YHqkzxRadENx1290xw0MrRTXaoyNfftrd_rdHPROF8rxL_vvyiC2zwYMwCPuEaZOOycVS_4QrnHp s2JDQoNcQavKM1tvqI3G6q4YeejTH.SJ.DjjJIsF9NnSJIgs.OK900v_3uyAbW9pgzU4JQHhhOdd _KA-- X-Sonic-MF: X-Sonic-ID: 6874791a-aa24-4685-827e-1a883391ae14 Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.gq1.yahoo.com with HTTP; Fri, 28 Jul 2023 00:22:59 +0000 Received: by hermes--production-ne1-549c7f6c44-c7r4q (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 7d948983f95814ee4b64eed14c06d04f; Fri, 28 Jul 2023 00:22:57 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: RE: git: 831b1ff7913f - main - UFS/FFS: Migrate to modern uintXX_t from u_intXX_t. Message-Id: Date: Thu, 27 Jul 2023 17:22:45 -0700 To: "mckusick@freebsd.org" , dev-commits-src-main@freebsd.org X-Mailer: Apple Mail (2.3731.600.7) References: X-Spamd-Result: default: False [-1.50 / 15.00]; NEURAL_HAM_SHORT(-0.99)[-0.992]; NEURAL_HAM_MEDIUM(-0.94)[-0.943]; NEURAL_SPAM_LONG(0.93)[0.931]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; MV_CASE(0.50)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; RCVD_IN_DNSWL_NONE(0.00)[98.137.64.206:from]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; FREEMAIL_FROM(0.00)[yahoo.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; MIME_TRACE(0.00)[0:+]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.64.206:from] X-Rspamd-Queue-Id: 4RBpJ627tsz3Cgn X-Spamd-Bar: - Kirk McKusick wrote on Date: Thu, 27 Jul 2023 22:27:49 UTC : > The branch main has been updated by mckusick: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D831b1ff7913fb0b317a258a43dce5abe= fee03a31 >=20 > commit 831b1ff7913fb0b317a258a43dce5abefee03a31 > Author: Kirk McKusick > AuthorDate: 2023-07-27 22:26:01 +0000 > Commit: Kirk McKusick > CommitDate: 2023-07-27 22:27:36 +0000 >=20 > UFS/FFS: Migrate to modern uintXX_t from u_intXX_t. >=20 > As per = https://lists.freebsd.org/archives/freebsd-scsi/2023-July/000257.html > move to the modern uintXX_t. While here also migrate u_char to = uint8_t. > Where other kernel interfaces allow, migrate u_long to uint64_t. Looks dangerous to me . . . u_long (a.k.a. unsigned long) on armv7, for example, is 32 bits, not 64. Same for i386, I expect. For reference, from /usr/include/sys/types.h : #if __BSD_VISIBLE typedef unsigned char u_char; typedef unsigned short u_short; typedef unsigned int u_int; typedef unsigned long u_long; #ifndef _KERNEL typedef unsigned short ushort; /* Sys V compatibility */ typedef unsigned int uint; /* Sys V compatibility */ #endif #endif Quoting FreeBSD's man arch: ILP32 int, long, void * types machine representations all have = 4-byte size. LP64 int type machine representation uses 4 bytes, while long = and void * are 8 bytes. armv7 is ILP32, as, likely, i386 would be as well. Note that u_int is 32 bits for both ILP32 and LP64, not 64. But there are a lot of u_int -> uint64_t replacements in the update. > No functional changes intended. It would appear that it would take a bunch of validation to know if the size changes actually make no actual difference on the architectures where some sizes changed. > MFC-after: 1 week > Sponsored-by: The FreeBSD Foundation . . . =3D=3D=3D Mark Millard marklmi at yahoo.com