From nobody Thu Jul 27 22:30:40 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RBlpk01l7z4pNdc for ; Thu, 27 Jul 2023 22:30:54 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RBlpj5SfPz3Pyf for ; Thu, 27 Jul 2023 22:30:53 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3175f17a7baso1557072f8f.0 for ; Thu, 27 Jul 2023 15:30:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690497052; x=1691101852; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X1OBow9p9l+d9i/tYbj153WtCcub7O3HHm/XQnjNeXo=; b=bp9/RNM6zAQLqSCw/TrKoWjpPWGqM71vh3+WjIZF0Zbtep7FH0oF9uR3c8ybESgYkW fodHeynCSv3fI9gsMCcan3YQxeXuttf8h/+DaAR1Hsc2fdsmZUJvX0oaqVX1EEgDXwcF rkkn7QfMp7FbFZ6vSdpfP958fSKpVUeBkmsXSPbWG0G3Gpe3ReNqSztdCG8/wZOeZSrq jEm5WpL2+tXfxYPOWBqdMESLvwWLu9d9VYHDZh2fFFqOpIqwVPprUCYSmZolMftW+CDC 287Gi8eohRrPlm18I9fXW10GyqBXNLFKGIy/P+xRmjG8c79SVHEb/xTgif6iNuxHxgJw A05A== X-Gm-Message-State: ABy/qLZ/Wcp0aw0h3HPSsMCakK7cgCIMHlpDlCaxRueMrlNz5dRM/z3/ hM/5zio8kJL4ajgDd0mI20UBBw== X-Google-Smtp-Source: APBJJlFR7OEjB+fyHiv6W80WE6P+dpVdP5NQzh4Qn9CTpcc+phYdXNIpz5lHVNqVadDYl6URII7PnA== X-Received: by 2002:a05:6000:1d0:b0:317:5b32:b2c3 with SMTP id t16-20020a05600001d000b003175b32b2c3mr328244wrx.6.1690497051769; Thu, 27 Jul 2023 15:30:51 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id x7-20020adff647000000b00317731a6e07sm3142662wrp.62.2023.07.27.15.30.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jul 2023 15:30:51 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: git: 831b1ff7913f - main - UFS/FFS: Migrate to modern uintXX_t from u_intXX_t. From: Jessica Clarke In-Reply-To: <202307272227.36RMRnEQ003602@gitrepo.freebsd.org> Date: Thu, 27 Jul 2023 23:30:40 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202307272227.36RMRnEQ003602@gitrepo.freebsd.org> To: Kirk McKusick X-Mailer: Apple Mail (2.3731.600.7) X-Rspamd-Queue-Id: 4RBlpj5SfPz3Pyf X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On 27 Jul 2023, at 23:27, Kirk McKusick wrote: >=20 > The branch main has been updated by mckusick: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D831b1ff7913fb0b317a258a43dce5abe= fee03a31 >=20 > commit 831b1ff7913fb0b317a258a43dce5abefee03a31 > Author: Kirk McKusick > AuthorDate: 2023-07-27 22:26:01 +0000 > Commit: Kirk McKusick > CommitDate: 2023-07-27 22:27:36 +0000 >=20 > UFS/FFS: Migrate to modern uintXX_t from u_intXX_t. >=20 > As per = https://lists.freebsd.org/archives/freebsd-scsi/2023-July/000257.html > move to the modern uintXX_t. While here also migrate u_char to = uint8_t. > Where other kernel interfaces allow, migrate u_long to uint64_t. >=20 > No functional changes intended. >=20 > MFC-after: 1 week > Sponsored-by: The FreeBSD Foundation > --- > sys/ufs/ffs/ffs_alloc.c | 148 = +++++++++++++++++++++++---------------------- > sys/ufs/ffs/ffs_extern.h | 19 +++--- > sys/ufs/ffs/ffs_inode.c | 10 +-- > sys/ufs/ffs/ffs_rawread.c | 4 +- > sys/ufs/ffs/ffs_snapshot.c | 10 +-- > sys/ufs/ffs/ffs_softdep.c | 28 ++++----- > sys/ufs/ffs/ffs_subr.c | 30 ++++----- > sys/ufs/ffs/ffs_tables.c | 6 +- > sys/ufs/ffs/ffs_vfsops.c | 25 ++++---- > sys/ufs/ffs/ffs_vnops.c | 33 +++++----- > sys/ufs/ffs/fs.h | 78 ++++++++++++------------ > sys/ufs/ffs/softdep.h | 4 +- > sys/ufs/ufs/dinode.h | 38 ++++++------ > sys/ufs/ufs/dir.h | 28 ++++----- > sys/ufs/ufs/dirhash.h | 2 +- > sys/ufs/ufs/extattr.h | 2 +- > sys/ufs/ufs/inode.h | 20 +++--- > sys/ufs/ufs/quota.h | 46 +++++++------- > sys/ufs/ufs/ufs_dirhash.c | 6 +- > sys/ufs/ufs/ufs_gjournal.c | 6 +- > sys/ufs/ufs/ufs_lookup.c | 19 +++--- > sys/ufs/ufs/ufs_quota.c | 30 ++++----- > sys/ufs/ufs/ufs_vfsops.c | 2 +- > sys/ufs/ufs/ufs_vnops.c | 14 ++--- > sys/ufs/ufs/ufsmount.h | 20 +++--- > 25 files changed, 316 insertions(+), 312 deletions(-) >=20 > diff --git a/sys/ufs/ffs/ffs_alloc.c b/sys/ufs/ffs/ffs_alloc.c > index 680e4685e44a..c5e2a706a128 100644 > --- a/sys/ufs/ffs/ffs_alloc.c > +++ b/sys/ufs/ffs/ffs_alloc.c > @@ -103,10 +103,11 @@ __FBSDID("$FreeBSD$"); > #include > #include >=20 > -typedef ufs2_daddr_t allocfcn_t(struct inode *ip, u_int cg, = ufs2_daddr_t bpref, > - int size, int rsize); > +typedef ufs2_daddr_t allocfcn_t(struct inode *ip, uint64_t cg, > + ufs2_daddr_t bpref, int size, int rsize); There are a lot of u_int=E2=80=99s being replaced with uint64_t in this = patch, which aren=E2=80=99t equivalent types. Is that intentional? Normally for = these patches they should be non-functional, especially when there=E2=80=99s = nothing calling out this difference in the commit message. Jess