Re: git: a0302c923150 - main - ix, ixv: Update link status with autonegotiated baudrate value

From: Piotr Kubaj <pkubaj_at_anongoth.pl>
Date: Tue, 11 Jul 2023 16:45:33 UTC
On 23-07-11 09:34:08, Navdeep Parhar wrote:
> On 7/11/23 9:19 AM, Piotr Kubaj wrote:
> > The branch main has been updated by pkubaj:
> > 
> > URL: https://cgit.FreeBSD.org/src/commit/?id=a0302c9231502bae8f43edbd5fb8d73132eb8da7
> > 
> > commit a0302c9231502bae8f43edbd5fb8d73132eb8da7
> > Author:     Piotr Pietruszewski <piotr.pietruszewski@intel.com>
> > AuthorDate: 2023-07-11 16:14:26 +0000
> > Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
> > CommitDate: 2023-07-11 16:14:26 +0000
> > 
> >      ix, ixv: Update link status with autonegotiated baudrate value
> >      
> >      Use autonegotiated link speed value while updating link status
> >      to iflib.
> >      
> >      This patch is part of change made in NetBSD kernel
> >      by Masanobu Saitoh, NetBSD maintainer.
> >      
> >      Differential Revision:  https://reviews.freebsd.org/D19176
> >      Approved by:    erj
> > ---
> >   sys/dev/ixgbe/if_ix.c       |  3 ++-
> >   sys/dev/ixgbe/if_ixv.c      |  2 +-
> >   sys/dev/ixgbe/ixgbe.h       |  2 ++
> >   sys/dev/ixgbe/ixgbe_osdep.c | 33 +++++++++++++++++++++++++++++++++
> >   4 files changed, 38 insertions(+), 2 deletions(-)
> > 
> > diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c
> > index 0179c6456de8..09c0a82279ed 100644
> > --- a/sys/dev/ixgbe/if_ix.c
> > +++ b/sys/dev/ixgbe/if_ix.c
> > @@ -3679,7 +3679,8 @@ ixgbe_if_update_admin_status(if_ctx_t ctx)
> >   			/* Update DMA coalescing config */
> >   			ixgbe_config_dmac(sc);
> >   			/* should actually be negotiated value */
> 
> This comment should have been deleted too?
Thanks, fixed now.
> 
> Regards,
> Navdeep
> 
> > -			iflib_link_state_change(ctx, LINK_STATE_UP, IF_Gbps(10));
> > +			iflib_link_state_change(ctx, LINK_STATE_UP,
> > +			    ixgbe_link_speed_to_baudrate(adapter->link_speed));
> >    >   			if (sc->feat_en & IXGBE_FEATURE_SRIOV)
> >   				ixgbe_ping_all_vfs(sc)