From nobody Wed Jul 05 10:11:19 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QwwRn1QKDz4lN0T for ; Wed, 5 Jul 2023 10:11:33 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QwwRm6Nbvz3Hxt for ; Wed, 5 Jul 2023 10:11:32 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-4fafe87c6fbso10116297e87.3 for ; Wed, 05 Jul 2023 03:11:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688551891; x=1691143891; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GeSWi/bz+QFR/UvC2aL7xZP4kMGerH8NBQKHTrW92SU=; b=CFb/XXJNgtEO9onbgjGsUWQdtgEsDV39AlFYs4iIpJRER+Fc/EHSS/4DM32zhkSIvp jCytaqGwNV5Ea7WZ7M+vXEVcPZuPrZvxFIaHQDE7D15DYpN/X7GIxjUp0rqI+YFXt5x2 +eL+wJIMQW/sT4bTbYX+8UaRyXc5cFCtHJgBjMuro7RzMyjanePMMTZsLM2brvOF/7lV xB2Foh8Yp2s6BqSVCIc8aAmx/o7qF3X+pSynV7MA28o+grTw+UqTAlMCQwCDGvLoma39 MkX129FnYjsdk6L8sByFkttNNV4vc2ekZWKHGSDjI9XkiS1W+PbWfcBSbxfHUREfJAZX jWjg== X-Gm-Message-State: ABy/qLbPRORb9JnIuxZdc928flbl+y4gPZZo46xxs18FIOOO4F/uwoGQ AuzOEZhxyFIMVX0hPp7MogurDw== X-Google-Smtp-Source: APBJJlE2il1xEsJUWR4MtluGhmTt6soe74TcaADGdr+pi7ChGTh0Kgq0H2Cu2onVQrCG9lu9mEp77g== X-Received: by 2002:a05:6512:3a8e:b0:4fb:987b:ec3c with SMTP id q14-20020a0565123a8e00b004fb987bec3cmr13767291lfu.56.1688551890822; Wed, 05 Jul 2023 03:11:30 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id c23-20020a05600c0ad700b003fa95890484sm1677491wmr.20.2023.07.05.03.11.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jul 2023 03:11:30 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: git: 55e0aefae688 - main - ping: low-effort fix to make it compilable without inet6 From: Jessica Clarke In-Reply-To: <202307051003.365A3RqR072876@gitrepo.freebsd.org> Date: Wed, 5 Jul 2023 11:11:19 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202307051003.365A3RqR072876@gitrepo.freebsd.org> To: Mateusz Guzik X-Mailer: Apple Mail (2.3731.600.7) X-Rspamd-Queue-Id: 4QwwRm6Nbvz3Hxt X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 5 Jul 2023, at 11:03, Mateusz Guzik wrote: >=20 > The branch main has been updated by mjg: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D55e0aefae688075718e212594e823fe5= fbfba4bf >=20 > commit 55e0aefae688075718e212594e823fe5fbfba4bf > Author: Mateusz Guzik > AuthorDate: 2023-07-05 09:59:40 +0000 > Commit: Mateusz Guzik > CommitDate: 2023-07-05 10:02:32 +0000 >=20 > ping: low-effort fix to make it compilable without inet6 > --- > sbin/ping/Makefile | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/sbin/ping/Makefile b/sbin/ping/Makefile > index 23bac6d62d90..ad5dce03363f 100644 > --- a/sbin/ping/Makefile > +++ b/sbin/ping/Makefile > @@ -34,6 +34,8 @@ CFLAGS+=3D-DWITH_CASPER > CFLAGS+=3D-DIPSEC > LIBADD+=3D ipsec >=20 > +CFLAGS+=3D -Wno-error=3Dunused-but-set-variable > + If we=E2=80=99re going to go with bodges like this should they not at = least be gated on MK_INET6 =3D=3D no or similar? Otherwise the default build = where we are warning-clean today isn=E2=80=99t going to fail when new warnings = are introduced, which is sub-optimal. Jess > HAS_TESTS=3D > SUBDIR.${MK_TESTS}+=3D tests >=20