From nobody Mon Jan 30 22:31:29 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P5NFc14zkz3bJVD for ; Mon, 30 Jan 2023 22:31:32 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P5NFb4ng8z4HYg for ; Mon, 30 Jan 2023 22:31:31 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f42.google.com with SMTP id k16so9098417wms.2 for ; Mon, 30 Jan 2023 14:31:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QdhlSsMuowBGzVZcCNpB7HEbtWTohU7dwkzXvd8Zg0c=; b=28rtLBvNjDtpvBhek8eVGn8xuTdSPRLN/QkDZofep4+J1cg+fv3SRFJ5yiaeR8nknw cgE68kVEyB3fdse5eH0g12KwFhru8XyL19Hbra8k7quMlYLDt0ZLoX//rk0xg373nbkd UJ7Zi5nYiYDNNiy5gm/5ez4XJXMHsJ/oA2KvBDGRsWxWv+kqsxMzKs3Vdynr3a5uNS9o WTipiuCU6/6MzaAB8jR7WM84mvVunTgq8+OGnQJq2Xwy0tSPnosQTh6HX1BG4PSHcN3w fHTlmtXnRMt0fBMXw9duF6rvGVjG+j4lNTY3GJ+Dhb/XRwp1kkB3MxIeVmtTi21RAQMK aBVA== X-Gm-Message-State: AFqh2kqrdjOJeclbIOX4vbOiNQKlYp4L48LQiB7GgPDA06Kx2UiEWdbv CvYIZTSrOF/GKAv0RUIDgYb+2w== X-Google-Smtp-Source: AMrXdXv/vwJmk1ZOi4al7qZyxKJ2VkYiEW0CA6S+nG59f5h9Vy1t9p9P/wZd3fDj5BV/XulVbAf4Dg== X-Received: by 2002:a05:600c:3b9b:b0:3d2:392e:905f with SMTP id n27-20020a05600c3b9b00b003d2392e905fmr49856332wms.24.1675117890059; Mon, 30 Jan 2023 14:31:30 -0800 (PST) Received: from smtpclient.apple (global-5-143.n-2.net.cam.ac.uk. [131.111.5.143]) by smtp.gmail.com with ESMTPSA id c3-20020a1c3503000000b003dc1d668866sm17177471wma.10.2023.01.30.14.31.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2023 14:31:29 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 9dafbd0c69a6 - main - linuxkpi: Add `kmap_local_page_prot()` and `kunmap_local()` From: Jessica Clarke In-Reply-To: <202301302217.30UMHeCx060345@gitrepo.freebsd.org> Date: Mon, 30 Jan 2023 22:31:29 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202301302217.30UMHeCx060345@gitrepo.freebsd.org> To: =?utf-8?Q?Jean-S=C3=A9bastien_P=C3=A9dron?= X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Rspamd-Queue-Id: 4P5NFb4ng8z4HYg X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 30 Jan 2023, at 22:17, Jean-S=C3=A9bastien P=C3=A9dron = wrote: >=20 > The branch main has been updated by dumbbell (ports committer): >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D9dafbd0c69a6aade69b23a649548b6c7= 133f1091 >=20 > commit 9dafbd0c69a6aade69b23a649548b6c7133f1091 > Author: Jean-S=C3=A9bastien P=C3=A9dron > AuthorDate: 2023-01-20 17:52:39 +0000 > Commit: Jean-S=C3=A9bastien P=C3=A9dron > CommitDate: 2023-01-30 22:09:22 +0000 >=20 > linuxkpi: Add `kmap_local_page_prot()` and `kunmap_local()` >=20 > They are synonymous to `kmap_atomic_prot()` and `kunmap_atomic()` > respectively. >=20 > While here, fix several style(9) issues. >=20 > Reviewed by: manu > Approved by: manu > Differential Revision: https://reviews.freebsd.org/D38155 > --- > sys/compat/linuxkpi/common/include/linux/highmem.h | 17 = +++++++++++++++++ > 1 file changed, 17 insertions(+) >=20 > diff --git a/sys/compat/linuxkpi/common/include/linux/highmem.h = b/sys/compat/linuxkpi/common/include/linux/highmem.h > index 53efbec06385..0056b590f239 100644 > --- a/sys/compat/linuxkpi/common/include/linux/highmem.h > +++ b/sys/compat/linuxkpi/common/include/linux/highmem.h > @@ -50,6 +50,7 @@ > static inline vm_page_t > kmap_to_page(void *addr) > { > + These aren=E2=80=99t style(9) issues, this requirement was dropped a = while ago and new code shouldn=E2=80=99t include these blank lines. Jess > return (virt_to_page(addr)); > } >=20 > @@ -88,9 +89,17 @@ kmap_atomic_prot(vm_page_t page, pgprot_t prot) > static inline void * > kmap_atomic(vm_page_t page) > { > + > return (kmap_atomic_prot(page, VM_PROT_ALL)); > } >=20 > +static inline void * > +kmap_local_page_prot(vm_page_t page, pgprot_t prot) > +{ > + > + return (kmap_atomic_prot(page, prot)); > +} > + > static inline void > kunmap(vm_page_t page) > { > @@ -111,8 +120,16 @@ kunmap(vm_page_t page) > static inline void > kunmap_atomic(void *vaddr) > { > + > if (!PMAP_HAS_DMAP) > kunmap(virt_to_page(vaddr)); > } >=20 > +static inline void > +kunmap_local(void *addr) > +{ > + > + kunmap_atomic(addr); > +} > + > #endif /* _LINUXKPI_LINUX_HIGHMEM_H_ */