From nobody Thu Jan 12 08:23:59 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NsyJ12mbnz2sgGG; Thu, 12 Jan 2023 08:24:01 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NsyJ11z83z3svV; Thu, 12 Jan 2023 08:24:01 +0000 (UTC) (envelope-from bapt@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1673511841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mKSjW9Hm58BX3kYujYVQSdHb9VPKcp6gWdNUoOZXPJE=; b=NRjYmPd4VZ+RUpfa+I+O+SR3HisW2jrUcRCOSm6d7RWMhZwzv9nsZN+eyI2HYWfMexGscy mNGSULnSwObicFGUa2F4mup2/FEkOyOfkRMq9MqG8Ia3OkIEjCkE7ss82Gii9os8zwhi2J IB+H3TLHeeSqjWOaJbFQbfPkWBIvdkHPzp8Ql9LrRcxWyUZqIF9us6BIh+SKX/27s5hFPo VBqFaKDu/6+qqHuECNhG1bo2odd456c5tu00+TiG2Z9CwHJB0qjlFhMtg6sCwMisukU6Iw 8MeunsHvOXNjQrSF5aSyXTv85yPD8A+SwTOrN529HpIFGF734hzyOlXFpSuu5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1673511841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mKSjW9Hm58BX3kYujYVQSdHb9VPKcp6gWdNUoOZXPJE=; b=CQrlgziPfSJdzKjgD/sP7VIIvb269NQrJINq06c+GnPPTWedKEq7MgU3Lj/YwWFrcv7mOv E1b6m9CfezOqhL/2h/MZoPGNqgA1BSZPjG9CJcaiS4fd7bUkc1pfmX9mhpPVwmzo3KljSE 5jFgahHlyjQL5CZaR6APHI3TyXDyJNXm+uKqBBRlVSjt5FwwR/1CSHTOYYV+il9KRymw5F dCmMEXFAsm7eQ1q+IrzX5ock+g5k6CFf8EMPNakT/won2ubYxjBpgC5IyD1Yg7PXpP5jpu /U8V44oBf6Cz5qbxEubGXuorCY8sXrg4jGzgyDFofQl9WcD9Air1k0pNIhIy6g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1673511841; a=rsa-sha256; cv=none; b=AJ7rJNYK0UMJPSMT0q8LjlU9nIvxQxU2leqIE/cS4FAta7j0Y9xoYIHxazzYWe4SdafM8T rS03N93X7zIVQnD2pdYu9+5v/fjdZUMAQlKcCbaQ2bzdfLylDZRSahZd2PaZVFgPDqTK4d ypYBUFrL/npQMugkrDM6cR5t7s3h87YkWjOFaSxWSS4MEJ1VSR8Vta9Gzffo1jELFQSImc Nqn8p6IZQ1An5b855VmfXLVwbrIpuiD+aejnWeDc2NQRwiEm0Rqb2I7A/Oe9Y5NdPaGBim ZaVe3EtUeEOpa/9tN+rFzYgsdFQD9oeuV8F4yywJ856W2Zi8/Af0beHWwe9PwA== Received: from aniel.nours.eu (nours.eu [176.31.115.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NsyJ10RVnzlrH; Thu, 12 Jan 2023 08:24:01 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id 8AFE0A6EDD; Thu, 12 Jan 2023 09:23:59 +0100 (CET) Date: Thu, 12 Jan 2023 09:23:59 +0100 From: Baptiste Daroussin To: Rick Macklem Cc: Matteo Riondato , "Tobias C. Berner" , Ronald Klop , dev-commits-src-all@freebsd.org, src-committers@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 62a149bf6219 - main - Add new rc: machine_id to generate /etc/machine-id Message-ID: <20230112082359.dxgbexyhucr4lsv7@aniel.nours.eu> References: <202212231636.2BNGaluc012056@gitrepo.freebsd.org> <876513140.46.1671814393751@mailrelay> <20230109143951.txy43nin5yv3qkym@ubertino.local> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ThisMailContainsUnwantedMimeParts: N On Wed, Jan 11, 2023 at 07:08:39PM -0800, Rick Macklem wrote: > On Mon, Jan 9, 2023 at 6:40 AM Matteo Riondato wrote: > > > > On 2022-12-24 at 03:39 EST, Tobias C. Berner wrote: > > > > >Moin moin > > > > > >I think it tries to solve the same problem of giving the machine a unique id. > > > > > >From the linux man page [1] > > > > > > The machine ID does not change based on local or network > > > configuration or when hardware is replaced. Due to this and its > > > greater length, it is a more useful replacement for the > > > gethostid(3) call that POSIX specifies. > > > > > > > Does this make or should it make hostid obsolete? > I hope not, since the NFSv4 client uses /etc/hostid. > > > If yes, then changes are needed to deorbit hostid. If not, why not? > If this is somehow a better algorithm than the one used by uuidgen(1) > then I would prefer seeing that utility improved instead of a new one > being added. This is exactly what has been done. Here we are speaking a rc script to generate the file expected by userland software (from the ports tree). https://cgit.freebsd.org/src/commit/bin/uuidgen/uuidgen.c?id=f176fe8e7f638e585afcd2f4dd52a522c4648f63 > > If software needs to acquire the host uuid, the code can simply > get the sysctl kern.hostuuid. > > Unless there is a really good reason to have this one in the > system as well as uuidgen(1), I'd suggest you revert this commit. > > rick I don't see why it should be reverted. more and more of the package ecosystem requires this feature (and it what is provided by dbus is not sufficient anymore), this is what those changes (addition to uuidgen(1) and rc script to generate the machine-id file) is addressing. Now can we reuse part of the changes to improve/replace hostid, this is a complerly unrelated study that could (should?) be done by whom is willing to have a look and knowledgeable enough in this area. Best regards, Bapt