From nobody Wed Jan 11 21:29:45 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nsgn54lmDz2sF9Y; Wed, 11 Jan 2023 21:29:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Nsgn54FzJz3p7k; Wed, 11 Jan 2023 21:29:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1673472585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VHF/ZsGL9uITKOfCCfmYVCdM2rY4nQIVbt2levmrJeI=; b=W9L3iJLWakHjA+l4/OeSLNrI3U/HJ2q2gv7ODqZPuGYAOQ6LNpC8mnumH3L4ycrlVVvAIP Zzt4JyERcjF1k4ntM3RGlnjiKAhGGwrpiJXdQNnHIWHjeOQWvHJ9ghbWkkjwBoZ9giUsi2 99ZX8EJA+YCqf+TLf66qAHJh/pBVyl42tJ2A6YFeEnNj78ptMwXl9wBRpqo7q4qnQcapq0 6Q4JtqwdkEaub6kVp4Js/Ywr1CaisAGA9ANlQcaCMz+om13LpDUYpPZXUepgHrg3EJQjV4 wgbNFNHDozNcXvwxhBufw14Hbmykd61eUIy3C+G1HLk3fDlZqG7udP8o9NLDHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1673472585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VHF/ZsGL9uITKOfCCfmYVCdM2rY4nQIVbt2levmrJeI=; b=hJKUfz3nOS/zKK2DJeKVxYLojSzz5dIDXIfZOz52mdfCzw4H9Mno4CXPmyXWBz7FupZdTC 6pMDtfI4z36380aVS+wF8f1fNSlt0SGuNbVe13SwhYL+2vtOSpUUzdj6Vv05BonZvU1yMs O8q5qBvlnap2N+UdlWksjfnyv/2JnFEvjOtccUXTpGeVRu9ZFL3dFb3JLQQV53493os22w SR0JEDussiW+NTs+hwR4PbkxaYDd1XTCunRy5oFYH0+fjRgR2a15xxScE0V8rueGKWxT/Y Zd1rj3emCGRC9cM9JM1mpXOgD9I0IrDfasDzzOLh80uSVhGdxyoyjPtUstONbw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1673472585; a=rsa-sha256; cv=none; b=qLP4ywWDWLXgJ/oPWi1cZ6RVA84wiWR+mXg0Tuds0YjDEoHZWNy1kp+UH03eASjJS7VFow CfdIo8RQFoNmifj631P/+YM0kvsPP13jIG/VlcKy+Rkat92O20F3uSyyBmf/zZ+XSyA1EJ aHGeo7M+bkU8F0fOuQaXau78H9VOmP93Qbfy2FwzxRKvbAo6DemzWWfBAluNESwhtPlVHm UNeP9YmD2tx89WA2dr7SUnRG/E+MerKu8PVQT4iotKrZzO/HmE19cEWZnF+dyl7Tl4KSqO 14K2aHnBf264c726QEKtBzxsVnTdQhki+d0dmTgmGKg5y4zw22tsa0byn5RaHQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Nsgn53K8lz13HM; Wed, 11 Jan 2023 21:29:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30BLTj9U021101; Wed, 11 Jan 2023 21:29:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30BLTjt4021100; Wed, 11 Jan 2023 21:29:45 GMT (envelope-from git) Date: Wed, 11 Jan 2023 21:29:45 GMT Message-Id: <202301112129.30BLTjt4021100@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: 39633fc1731c - main - nfscl: Improve NFSv4 error message for NFSERR_WRONGSEC List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 39633fc1731c3feeed36aa452bbdfb7968a86383 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=39633fc1731c3feeed36aa452bbdfb7968a86383 commit 39633fc1731c3feeed36aa452bbdfb7968a86383 Author: Rick Macklem AuthorDate: 2023-01-11 21:28:44 +0000 Commit: Rick Macklem CommitDate: 2023-01-11 21:28:44 +0000 nfscl: Improve NFSv4 error message for NFSERR_WRONGSEC The usual reason for an NFSv4 server replying NFSERR_WRONGSEC to an operation is that a Kerberos credential is required. This patch replaces a cryptic "err=10016" with a message suggesting that a Kerberos TGT is probably needed. MFC after: 2 weeks --- sys/fs/nfsclient/nfs_clport.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/fs/nfsclient/nfs_clport.c b/sys/fs/nfsclient/nfs_clport.c index fc62783e3965..7f9b18e9970a 100644 --- a/sys/fs/nfsclient/nfs_clport.c +++ b/sys/fs/nfsclient/nfs_clport.c @@ -1194,6 +1194,10 @@ nfscl_maperr(struct thread *td, int error, uid_t uid, gid_t gid) printf("nfsv4 no file handle: usually means the file " "system is not exported on the NFSv4 server\n"); return (EIO); + case NFSERR_WRONGSEC: + tprintf(p, LOG_INFO, "NFSv4 error WrongSec: You probably need a" + " Kerberos TGT\n"); + return (EIO); default: tprintf(p, LOG_INFO, "nfsv4 err=%d\n", error); return (EIO);