git: 7daf96523b37 - main - Add PCIe driver for RK3568 SoC.

From: Ganbold Tsagaankhuu <ganbold_at_FreeBSD.org>
Date: Thu, 05 Jan 2023 04:17:16 UTC
The branch main has been updated by ganbold:

URL: https://cgit.FreeBSD.org/src/commit/?id=7daf96523b378e08a513722bc5354400919ccf2b

commit 7daf96523b378e08a513722bc5354400919ccf2b
Author:     Søren Schmidt <sos@FreeBSD.org>
AuthorDate: 2023-01-05 04:15:56 +0000
Commit:     Ganbold Tsagaankhuu <ganbold@FreeBSD.org>
CommitDate: 2023-01-05 04:15:56 +0000

    Add PCIe driver for RK3568 SoC.
    
    PCIe3 ports work, however PCIe2x1 is not working yet in this case as it depends on Naneng Combo Phy driver.
---
 sys/arm64/rockchip/rk3568_pcie.c    | 394 ++++++++++++++++++++++++++++++++++++
 sys/arm64/rockchip/rk3568_pciephy.c | 227 +++++++++++++++++++++
 sys/conf/files.arm64                |   2 +
 3 files changed, 623 insertions(+)

diff --git a/sys/arm64/rockchip/rk3568_pcie.c b/sys/arm64/rockchip/rk3568_pcie.c
new file mode 100644
index 000000000000..0cca73ff0402
--- /dev/null
+++ b/sys/arm64/rockchip/rk3568_pcie.c
@@ -0,0 +1,394 @@
+/*-
+ * Copyright (c) 2021, 2022 Soren Schmidt <sos@deepcore.dk>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer,
+ *    without modification, immediately at the beginning of the file.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
+ * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
+ * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
+ * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+ * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * $Id: rk3568_pcie.c 893 2022-07-26 09:47:22Z sos $
+ */
+
+#include <sys/cdefs.h>
+#include <sys/param.h>
+#include <sys/systm.h>
+#include <sys/endian.h>
+#include <sys/kernel.h>
+#include <sys/module.h>
+#include <sys/bus.h>
+#include <sys/proc.h>
+#include <sys/rman.h>
+#include <sys/intr.h>
+#include <sys/mutex.h>
+#include <sys/gpio.h>
+
+#include <dev/gpio/gpiobusvar.h>
+#include <dev/ofw/ofw_bus.h>
+#include <dev/ofw/ofw_bus_subr.h>
+#include <dev/ofw/ofw_pci.h>
+#include <dev/ofw/ofwpci.h>
+
+#include <dev/pci/pcivar.h>
+#include <dev/pci/pcireg.h>
+#include <dev/pci/pcib_private.h>
+#include <dev/pci/pci_dw.h>
+
+#include <dev/extres/clk/clk.h>
+#include <dev/extres/phy/phy.h>
+#include <dev/extres/regulator/regulator.h>
+#include <dev/extres/hwreset/hwreset.h>
+
+#include <machine/bus.h>
+#include <machine/intr.h>
+
+#include <vm/vm.h>
+#include <vm/vm_extern.h>
+#include <vm/vm_kern.h>
+#include <vm/pmap.h>
+
+#include "pcib_if.h"
+
+/* APB Registers */
+#define	PCIE_CLIENT_GENERAL_CON		0x0000
+#define	 DEVICE_TYPE_MASK		0x00f0
+#define	 DEVICE_TYPE_RC			(1<<6)
+#define	 LINK_REQ_RST_GRT		(1<<3)
+#define	 LTSSM_ENABLE			(1<<2)
+#define	PCIE_CLIENT_INTR_MASK_MSG_RX	0x0018
+#define	PCIE_CLIENT_INTR_MASK_LEGACY	0x001c
+#define	PCIE_CLIENT_INTR_MASK_ERR	0x0020
+#define	PCIE_CLIENT_INTR_MASK_MISC	0x0024
+#define	PCIE_CLIENT_INTR_MASK_PMC	0x0028
+#define	PCIE_CLIENT_GENERAL_DEBUG_INFO	0x0104
+#define	PCIE_CLIENT_HOT_RESET_CTRL	0x0180
+#define	 APP_LSSTM_ENABLE_ENHANCE	(1<<4)
+#define	PCIE_CLIENT_LTSSM_STATUS	0x0300
+#define	 RDLH_LINK_UP			(1<<17)
+#define	 SMLH_LINK_UP			(1<<16)
+#define	 SMLH_LTSSM_STATE_MASK		0x003f
+#define	 SMLH_LTSSM_STATE_LINK_UP	((1<<4) | (1<<0))
+
+struct rk3568_pcie_softc {
+	struct pci_dw_softc		dw_sc;  /* Must be first */
+	device_t			dev;
+	int				apb_rid;
+	struct resource			*apb_res;
+	int				dbi_rid;
+	struct resource			*dbi_res;
+	int				irq_rid;
+	struct resource			*irq_res;
+	void				*irq_handle;
+	phandle_t			node;
+	struct gpiobus_pin		*reset_gpio;
+	clk_t				aclk_mst, aclk_slv, aclk_dbi, pclk, aux;
+	regulator_t			regulator;
+	hwreset_t			hwreset;
+	phy_t				phy;
+};
+
+static struct ofw_compat_data compat_data[] = {
+	{"rockchip,rk3568-pcie",	1},
+	{NULL,				0}
+};
+
+
+static void
+rk3568_intr(void *data)
+{
+	struct rk3568_pcie_softc *sc = data;
+
+	device_printf(sc->dev, "INTERRUPT!!\n");
+}
+
+static int
+rk3568_pcie_get_link(device_t dev, bool *status)
+{
+	struct rk3568_pcie_softc *sc = device_get_softc(dev);
+	uint32_t val;
+	
+	val = bus_read_4(sc->apb_res, PCIE_CLIENT_LTSSM_STATUS);
+	if (((val & (RDLH_LINK_UP | SMLH_LINK_UP)) ==
+	    (RDLH_LINK_UP | SMLH_LINK_UP)) &&
+	    ((val & SMLH_LTSSM_STATE_MASK) == SMLH_LTSSM_STATE_LINK_UP))
+		*status = true;
+	else
+		*status = false;
+	return (0);
+}
+
+static int
+rk3568_pcie_init_soc(device_t dev)
+{
+	struct rk3568_pcie_softc *sc = device_get_softc(dev);
+	int err, count;
+	bool status;
+
+	/* Assert reset */
+	if (hwreset_assert(sc->hwreset))
+		device_printf(dev, "Could not assert reset\n");
+
+	/* Powerup PCIe */
+	if (regulator_enable(sc->regulator))
+		device_printf(dev, "Cannot enable regulator\n");
+
+	/* Enable PHY */
+	if (phy_enable(sc->phy))
+		device_printf(dev, "Cannot enable phy\n");
+
+	/* Deassert reset */
+	if (hwreset_deassert(sc->hwreset))
+		device_printf(dev, "Could not deassert reset\n");
+
+	/* Enable clocks */
+	if ((err = clk_enable(sc->aclk_mst))) {
+		device_printf(dev, "Could not enable aclk_mst clk\n");
+		return (ENXIO);
+	}
+	if ((err = clk_enable(sc->aclk_slv))) {
+		device_printf(dev, "Could not enable aclk_slv clk\n");
+		return (ENXIO);
+	}
+	if ((err = clk_enable(sc->aclk_dbi))) {
+		device_printf(dev, "Could not enable aclk_dbi clk\n");
+		return (ENXIO);
+	}
+	if ((err = clk_enable(sc->pclk))) {
+		device_printf(dev, "Could not enable pclk clk\n");
+		return (ENXIO);
+	}
+	if ((err = clk_enable(sc->aux))) {
+		device_printf(dev, "Could not enable aux clk\n");
+		return (ENXIO);
+	}
+
+	/* Set Root Complex (RC) mode */
+	bus_write_4(sc->apb_res, PCIE_CLIENT_HOT_RESET_CTRL,
+	    (APP_LSSTM_ENABLE_ENHANCE << 16) | APP_LSSTM_ENABLE_ENHANCE);
+	bus_write_4(sc->apb_res, PCIE_CLIENT_GENERAL_CON,
+	    (DEVICE_TYPE_MASK << 16) | DEVICE_TYPE_RC);
+
+	/* Assert reset PCIe */
+	if ((err = gpio_pin_set_active(sc->reset_gpio, false)))
+		device_printf(dev, "reset_gpio set failed\n");
+
+	/* Start Link Training and Status State Machine (LTSSM) */
+	bus_write_4(sc->apb_res, PCIE_CLIENT_GENERAL_CON,
+	    (LINK_REQ_RST_GRT | LTSSM_ENABLE) << 16 |
+	    (LINK_REQ_RST_GRT | LTSSM_ENABLE));
+	DELAY(100000);
+
+	/* Release reset */
+	if ((err = gpio_pin_set_active(sc->reset_gpio, true)))
+		device_printf(dev, "reset_gpio release failed\n");
+
+	/* Wait for link up/stable */
+	for (count = 20; count; count--) {
+		rk3568_pcie_get_link(dev, &status);
+		if (status)
+			break;
+		DELAY(100000);
+		if (count == 0) {
+			device_printf(dev, "Link up timeout!\n");
+			return (ENXIO);
+		}
+	}
+
+	if ((err = pci_dw_init(dev)))
+		return (ENXIO);
+
+	/* Enable all MSG interrupts */
+	bus_write_4(sc->apb_res, PCIE_CLIENT_INTR_MASK_MSG_RX, 0x7fff0000);
+
+	/* Enable all Legacy interrupts */
+	bus_write_4(sc->apb_res, PCIE_CLIENT_INTR_MASK_LEGACY, 0x00ff0000);
+
+	/* Enable all Error interrupts */
+	bus_write_4(sc->apb_res, PCIE_CLIENT_INTR_MASK_ERR, 0x0fff0000);
+
+	return (0);
+}
+
+static int
+rk3568_pcie_detach(device_t dev)
+{
+	struct rk3568_pcie_softc *sc = device_get_softc(dev);
+
+	/* Release allocated resources */
+	if (sc->irq_handle)
+		bus_teardown_intr(dev, sc->irq_res, sc->irq_handle);
+	if (sc->phy)
+		phy_release(sc->phy);
+	if (sc->aux)
+		clk_release(sc->aux);
+	if (sc->pclk)
+		clk_release(sc->pclk);
+	if (sc->aclk_dbi)
+		clk_release(sc->aclk_dbi);
+	if (sc->aclk_slv)
+		clk_release(sc->aclk_slv);
+	if (sc->aclk_mst)
+		clk_release(sc->aclk_mst);
+	if (sc->hwreset)
+		hwreset_release(sc->hwreset);
+	if (sc->regulator)
+		regulator_release(sc->regulator);
+	if (sc->irq_res)
+		bus_release_resource(dev, SYS_RES_IRQ, sc->irq_rid,
+		    sc->irq_res);
+	if (sc->dbi_res)
+		bus_release_resource(dev, SYS_RES_MEMORY, sc->dbi_rid,
+		    sc->dbi_res);
+	if (sc->apb_res)
+		bus_release_resource(dev, SYS_RES_MEMORY, sc->apb_rid,
+		    sc->apb_res);
+	return (0);
+}
+
+static int
+rk3568_pcie_attach(device_t dev)
+{
+	struct rk3568_pcie_softc *sc = device_get_softc(dev);
+	int error;
+
+	sc->dev = dev;
+	sc->node = ofw_bus_get_node(dev);
+
+	/* Setup resources */
+	if ((error = ofw_bus_find_string_index(sc->node, "reg-names", "apb",
+	    &sc->apb_rid))) {
+		device_printf(dev, "Cannot get APB memory: %d\n", error);
+		goto fail;
+	}
+	if (!(sc->apb_res = bus_alloc_resource_any(dev, SYS_RES_MEMORY,
+	    &sc->apb_rid, RF_ACTIVE))) {
+		device_printf(dev, "Cannot allocate APB resource\n");
+		goto fail;
+	}
+	if ((error = ofw_bus_find_string_index(sc->node, "reg-names", "dbi",
+	    &sc->dbi_rid))) {
+		device_printf(dev, "Cannot get DBI memory: %d\n", error);
+		goto fail;
+	}
+	if (!(sc->dw_sc.dbi_res = bus_alloc_resource_any(dev, SYS_RES_MEMORY,
+	    &sc->dbi_rid, RF_ACTIVE))) {
+		device_printf(dev, "Cannot allocate DBI resource\n");
+		goto fail;
+	}
+
+	if (!(sc->irq_res = bus_alloc_resource_any(dev, SYS_RES_IRQ,
+	    &sc->irq_rid, RF_ACTIVE | RF_SHAREABLE))) {
+		device_printf(dev, "Cannot allocate IRQ resource\n");
+		goto fail;
+	}
+
+	/* Get regulator if present */
+	if (regulator_get_by_ofw_property(dev, 0, "vpcie3v3-supply",
+	    &sc->regulator)) {
+		device_printf(dev, "Cannot get regulator\n");
+		goto fail;
+	}
+
+	/* Get reset */
+	if (hwreset_get_by_ofw_name(dev, 0, "pipe", &sc->hwreset)) {
+		device_printf(dev, "Can not get reset\n");
+		goto fail;
+	}
+
+	/* Get GPIO reset */
+	if (OF_hasprop(sc->node, "reset-gpios")) {
+		if (gpio_pin_get_by_ofw_property(dev, sc->node, "reset-gpios",
+		    &sc->reset_gpio)) {
+			device_printf(dev, "Cannot get reset-gpios\n");
+			goto fail;
+		}
+		gpio_pin_setflags(sc->reset_gpio, GPIO_PIN_OUTPUT);
+		gpio_pin_set_active(sc->reset_gpio, true);
+	}
+
+	/* Get clocks */
+	if (clk_get_by_ofw_name(dev, 0, "aclk_mst", &sc->aclk_mst)) {
+		device_printf(dev, "Can not get aclk_mst clk\n");
+		goto fail;
+	}
+	if (clk_get_by_ofw_name(dev, 0, "aclk_slv", &sc->aclk_slv)) {
+		device_printf(dev, "Can not get aclk_slv clk\n");
+		goto fail;
+	}
+	if (clk_get_by_ofw_name(dev, 0, "aclk_dbi", &sc->aclk_dbi)) {
+		device_printf(dev, "Can not get aclk_dbi clk\n");
+		goto fail;
+	}
+	if (clk_get_by_ofw_name(dev, 0, "pclk", &sc->pclk)) {
+		device_printf(dev, "Can not get pclk clk\n");
+		goto fail;
+	}
+	if (clk_get_by_ofw_name(dev, 0, "aux", &sc->aux)) {
+		device_printf(dev, "Can not get aux clk\n");
+		goto fail;
+	}
+
+	/* Get PHY */
+	if (phy_get_by_ofw_name(dev, 0, "pcie-phy", &sc->phy)) {
+		device_printf(dev, "Cannot get 'pcie-phy'\n");
+		goto fail;
+	}
+
+	if ((error = rk3568_pcie_init_soc(dev)))
+		goto fail;
+
+	/* Enable interrupt */
+	if ((bus_setup_intr(dev, sc->irq_res, INTR_TYPE_MISC | INTR_MPSAFE,
+	    NULL, rk3568_intr, sc, &sc->irq_handle))) {
+		device_printf(dev, "unable to setup interrupt\n");
+		goto fail;
+	}
+
+	return (bus_generic_attach(dev));
+fail:
+	rk3568_pcie_detach(dev);
+	return (ENXIO);
+}
+
+static int
+rk3568_pcie_probe(device_t dev)
+{
+
+	if (!ofw_bus_status_okay(dev))
+		return (ENXIO);
+	if (!ofw_bus_search_compatible(dev, compat_data)->ocd_data)
+		return (ENXIO);
+	device_set_desc(dev, "RockChip RK3568 PCI-express controller");
+	return (BUS_PROBE_DEFAULT);
+}
+
+static device_method_t rk3568_pcie_methods[] = {
+	/* Device interface */
+	DEVMETHOD(device_probe,		rk3568_pcie_probe),
+	DEVMETHOD(device_attach,	rk3568_pcie_attach),
+	DEVMETHOD(device_detach,	rk3568_pcie_detach),
+
+	/* PCI DW interface */
+	DEVMETHOD(pci_dw_get_link,	rk3568_pcie_get_link),
+
+	DEVMETHOD_END
+};
+
+DEFINE_CLASS_1(pcib, rk3568_pcie_driver, rk3568_pcie_methods,
+    sizeof(struct rk3568_pcie_softc), pci_dw_driver);
+DRIVER_MODULE(mv_pcie, simplebus, rk3568_pcie_driver, NULL, NULL);
diff --git a/sys/arm64/rockchip/rk3568_pciephy.c b/sys/arm64/rockchip/rk3568_pciephy.c
new file mode 100644
index 000000000000..0a1880e8d831
--- /dev/null
+++ b/sys/arm64/rockchip/rk3568_pciephy.c
@@ -0,0 +1,227 @@
+/*-
+ * Copyright (c) 2021, 2022 Soren Schmidt <sos@deepcore.dk>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ *
+ * $Id: rk3568_pciephy.c 893 2022-07-26 09:47:22Z sos $
+ */
+
+#include <sys/cdefs.h>
+#include <sys/param.h>
+#include <sys/bus.h>
+#include <sys/kernel.h>
+#include <sys/module.h>
+#include <sys/mutex.h>
+#include <sys/rman.h>
+#include <machine/bus.h>
+
+#include <dev/ofw/openfirm.h>
+#include <dev/ofw/ofw_bus.h>
+#include <dev/ofw/ofw_bus_subr.h>
+
+#include <dev/fdt/simple_mfd.h>
+
+#include <dev/extres/clk/clk.h>
+#include <dev/extres/hwreset/hwreset.h>
+#include <dev/extres/regulator/regulator.h>
+#include <dev/extres/syscon/syscon.h>
+#include <dev/extres/phy/phy.h>
+
+#include <contrib/device-tree/include/dt-bindings/phy/phy.h>
+
+#include "syscon_if.h"
+#include "phydev_if.h"
+#include "phynode_if.h"
+
+#define	GRF_PCIE30PHY_CON1		0x04
+#define	GRF_PCIE30PHY_CON4		0x10
+#define	GRF_PCIE30PHY_CON6		0x18
+#define	 GRF_BIFURCATION_LANE_0_1	(1 << 0)
+#define	 GRF_BIFURCATION_LANE_2_3	(1 << 1)
+#define	 GRF_PCIE30PHY_WR_EN		(0xf << 16)
+#define	GRF_PCIE30PHY_CON9		0x24
+#define	 GRF_PCIE30PHY_DA_OCM		((1 << 15) | (1 << (15 + 16)))
+#define	GRF_PCIE30PHY_STATUS0		0x80
+#define	 SRAM_INIT_DONE			(1 << 14)
+
+static struct ofw_compat_data compat_data[] = {
+	{"rockchip,rk3568-pcie3-phy",	1},
+	{NULL, 0}
+};
+
+struct rk3568_pciephy_softc {
+	device_t	dev;
+	phandle_t	node;
+	struct resource	*mem;
+	struct phynode	*phynode;
+	struct syscon	*phy_grf;
+	clk_t		refclk_m;
+	clk_t		refclk_n;
+	clk_t		pclk;
+	hwreset_t	phy_reset;
+};
+
+
+/* PHY class and methods */
+static int
+rk3568_pciephy_enable(struct phynode *phynode, bool enable)
+{
+	device_t dev = phynode_get_device(phynode);
+	struct rk3568_pciephy_softc *sc = device_get_softc(dev);
+	int count;
+
+	if (enable) {
+		/* Deassert PCIe PMA output clamp mode */
+		SYSCON_WRITE_4(sc->phy_grf, GRF_PCIE30PHY_CON9,
+		    GRF_PCIE30PHY_DA_OCM);
+
+		/* Set bifurcation according to DT entry */
+		if (OF_hasprop(sc->node, "rockchip,bifurcation")) {
+			SYSCON_WRITE_4(sc->phy_grf, GRF_PCIE30PHY_CON6,
+			    GRF_PCIE30PHY_WR_EN | GRF_BIFURCATION_LANE_0_1);
+			SYSCON_WRITE_4(sc->phy_grf, GRF_PCIE30PHY_CON1,
+			    GRF_PCIE30PHY_DA_OCM);
+			device_printf(dev, "setup 2 x PCIeX1\n");
+		}
+		else
+			device_printf(dev, "setup 1 x PCIeX2\n");
+
+		hwreset_deassert(sc->phy_reset);
+
+		/* Poll for SRAM loaded and ready */
+		for (count = 100; count; count--) {
+			if (SYSCON_READ_4(sc->phy_grf, GRF_PCIE30PHY_STATUS0) &
+			    SRAM_INIT_DONE)
+				break;
+			DELAY(10000);
+			if (count == 0) {
+				device_printf(dev, "SRAM init timeout!\n");
+				return (ENXIO);
+			}
+		}
+	}
+	return (0);
+}
+
+static phynode_method_t rk3568_pciephy_phynode_methods[] = {
+	PHYNODEMETHOD(phynode_enable,	rk3568_pciephy_enable),
+
+	PHYNODEMETHOD_END
+};
+DEFINE_CLASS_1(rk3568_pciephy_phynode, rk3568_pciephy_phynode_class,
+    rk3568_pciephy_phynode_methods, 0, phynode_class);
+
+
+/* Device class and methods */
+static int
+rk3568_pciephy_probe(device_t dev)
+{
+
+	if (!ofw_bus_status_okay(dev))
+		return (ENXIO);
+	if (ofw_bus_search_compatible(dev, compat_data)->ocd_data == 0)
+		return (ENXIO);
+	device_set_desc(dev, "RockChip PCIe PHY");
+	return (BUS_PROBE_DEFAULT);
+}
+
+static int
+rk3568_pciephy_attach(device_t dev)
+{
+	struct rk3568_pciephy_softc *sc = device_get_softc(dev);
+	struct phynode_init_def phy_init;
+	struct phynode *phynode;
+	int rid = 0;
+
+	sc->dev = dev;
+	sc->node = ofw_bus_get_node(dev);
+
+	/* Get memory resource */
+	if (!(sc->mem = bus_alloc_resource_any(dev, SYS_RES_MEMORY, &rid,
+	    RF_ACTIVE))) {
+		device_printf(dev, "Cannot allocate memory resources\n");
+		return (ENXIO);
+	}
+
+	/* Get syncons handle */
+	if (OF_hasprop(sc->node, "rockchip,phy-grf") &&
+	    syscon_get_by_ofw_property(dev, sc->node, "rockchip,phy-grf",
+	    &sc->phy_grf))
+		return (ENXIO);
+
+	/* Get & enable clocks */
+	if (clk_get_by_ofw_name(dev, 0, "refclk_m", &sc->refclk_m)) {
+		device_printf(dev, "getting refclk_m failed\n");
+		return (ENXIO);
+	}
+	if (clk_enable(sc->refclk_m))
+		device_printf(dev, "enable refclk_m failed\n");
+	if (clk_get_by_ofw_name(dev, 0, "refclk_n", &sc->refclk_n)) {
+		device_printf(dev, "getting refclk_n failed\n");
+		return (ENXIO);
+	}
+	if (clk_enable(sc->refclk_n))
+		device_printf(dev, "enable refclk_n failed\n");
+	if (clk_get_by_ofw_name(dev, 0, "pclk", &sc->pclk)) {
+		device_printf(dev, "getting pclk failed\n");
+		return (ENXIO);
+	}
+	if (clk_enable(sc->pclk))
+		device_printf(dev, "enable pclk failed\n");
+
+	/* Get & assert reset */
+	if (hwreset_get_by_ofw_idx(dev, sc->node, 0, &sc->phy_reset)) {
+		device_printf(dev, "Cannot get reset\n");
+	}
+	else
+		hwreset_assert(sc->phy_reset);
+
+	/* Set RC/EP mode not implemented yet (RC mode only) */
+
+	bzero(&phy_init, sizeof(phy_init));
+	phy_init.id = PHY_NONE;
+	phy_init.ofw_node = sc->node;
+	if (!(phynode = phynode_create(dev, &rk3568_pciephy_phynode_class,
+	    &phy_init))) {
+		device_printf(dev, "failed to create pciephy PHY\n");
+		return (ENXIO);
+	}
+	if (!phynode_register(phynode)) {
+		device_printf(dev, "failed to register pciephy PHY\n");
+		return (ENXIO);
+	}
+	sc->phynode = phynode;
+
+	return (0);
+}
+
+static device_method_t rk3568_pciephy_methods[] = {
+	DEVMETHOD(device_probe,		rk3568_pciephy_probe),
+	DEVMETHOD(device_attach,	rk3568_pciephy_attach),
+
+	DEVMETHOD_END
+};
+
+DEFINE_CLASS_1(rk3568_pciephy, rk3568_pciephy_driver, rk3568_pciephy_methods,
+    sizeof(struct simple_mfd_softc), simple_mfd_driver);
+EARLY_DRIVER_MODULE(rk3568_pciephy, simplebus, rk3568_pciephy_driver,
+    0, 0, BUS_PASS_RESOURCE + BUS_PASS_ORDER_LATE);
diff --git a/sys/conf/files.arm64 b/sys/conf/files.arm64
index b83188b6bb28..df39a408867d 100644
--- a/sys/conf/files.arm64
+++ b/sys/conf/files.arm64
@@ -622,6 +622,8 @@ arm64/qualcomm/qcom_gcc.c			optional qcom_gcc fdt
 # RockChip Drivers
 arm64/rockchip/rk3328_codec.c			optional fdt rk3328codec soc_rockchip_rk3328
 arm64/rockchip/rk3399_emmcphy.c			optional fdt rk_emmcphy soc_rockchip_rk3399
+arm64/rockchip/rk3568_pcie.c			optional fdt pci soc_rockchip_rk3568
+arm64/rockchip/rk3568_pciephy.c			optional fdt pci soc_rockchip_rk3568
 arm64/rockchip/rk_dwc3.c			optional fdt rk_dwc3 soc_rockchip_rk3399 | fdt rk_dwc3 soc_rockchip_rk3568
 arm64/rockchip/rk_i2c.c				optional fdt rk_i2c soc_rockchip_rk3328 | fdt rk_i2c soc_rockchip_rk3399 | fdt rk_i2c soc_rockchip_rk3568
 arm64/rockchip/rk_i2s.c				optional fdt sound soc_rockchip_rk3328 | fdt sound soc_rockchip_rk3399