From nobody Mon Jan 02 17:29:57 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nm2tc6vJKz2p4GT; Mon, 2 Jan 2023 17:30:00 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Nm2tb68FRz3NhH; Mon, 2 Jan 2023 17:29:59 +0000 (UTC) (envelope-from mjguzik@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=UDU9lgx3; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2001:4860:4864:20::30 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-1433ef3b61fso34235890fac.10; Mon, 02 Jan 2023 09:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=n1xYGZwJZkum5IeY9lsvOCGj7sNJUVWyHEJcK8c8spQ=; b=UDU9lgx3kMmyeepNC6uH7OM/xjOTKARF2Sx77DV4YkuFD1eoU4/Rd0fWxPvM4GCle3 65AwdJfejx4TwfSiWZWdyoF7104DRYDMiGg31CwdsGl24g5DNHRtb0aF61XEcjk4e8y7 Wfvi4FUv+oKxnkwRQ+ZQfTTh9apiXeatEWtuNmFcKWtN3ZZ2LaJZq0ynueOaTBF2Y+NK RHklXs64X6A2onF95Yg+DKOUszCz+EwVSSTy1799fnloFYRCFnnSQ6ZqaQtTsfTGPxK3 PCSeyq6idDEW4LIUYEVFILTik7x+UhoEuOtJ9JzD0axTAdJiyH8Iz996WA45bDb/tIXT RosQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n1xYGZwJZkum5IeY9lsvOCGj7sNJUVWyHEJcK8c8spQ=; b=iwWYQdOF1105DgIpHtBTy2Lr2kGBAYYCol0khFn9pH+ncEbK6yzsrEvlx1t/DTsKO9 TJvBk6kB882jv1HStyQ3S3Vt9ku6xliE53IajS+Gb6UQbAhzXeOOao5k4kRBgsfEP6G0 045giEa3mqOLy7xn8J6whj6Evp5Ymi/HU1RK6xHiR99nwQssMQBU19ICGRFrJdWHyu2H ybNaepAZvPD8mGdRYPXXxFvAECNKaq3JnhQ+xpFG4g+6Q3n7SJ0KJL8WnF30Ag9EtQek BtuNdgpVliUHto+thoSLKnVBtCAUnxRio6MtqnOVaWH90BPyPUg4jXTN7ENvBTU4EXw6 lbrA== X-Gm-Message-State: AFqh2krD5tWoN3623VuSGsC3J8OGX9U5/h+JU4f5M1uiGh+MvhfKTHFC /2ILL1wOKDo7uasRtL3RCfxlDfA7Lmyl+CEzV53dWWqq X-Google-Smtp-Source: AMrXdXtHGKNgXMVkdnu3+8ozQFC9I/6N2WqaDPOOpbFD3tWCbK1vHPcdfIMtlZuvyKpXll9i077RpbitGuCcUcn366A= X-Received: by 2002:a05:6870:3d8d:b0:132:6942:5056 with SMTP id lm13-20020a0568703d8d00b0013269425056mr1897810oab.81.1672680598714; Mon, 02 Jan 2023 09:29:58 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Received: by 2002:ac9:77d5:0:b0:491:8368:9bdd with HTTP; Mon, 2 Jan 2023 09:29:57 -0800 (PST) In-Reply-To: <202212292056.2BTKuOIu047460@gitrepo.freebsd.org> References: <202212292056.2BTKuOIu047460@gitrepo.freebsd.org> From: Mateusz Guzik Date: Mon, 2 Jan 2023 18:29:57 +0100 Message-ID: Subject: Re: git: 68912701700c - main - ffs_suspend.c: clean up includes To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [-2.68 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-0.97)[-0.973]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_SPAM_SHORT(0.29)[0.288]; R_SPF_ALLOW(-0.20)[+ip6:2001:4860:4000::/36:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[2001:4860:4864:20::30:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2001:4860:4864::/48, country:US]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCPT_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_LAST(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4Nm2tb68FRz3NhH X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N On 12/29/22, Konstantin Belousov wrote: > The branch main has been updated by kib: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=68912701700ca3230f3e2d4b7858a038f884a327 > > commit 68912701700ca3230f3e2d4b7858a038f884a327 > Author: Konstantin Belousov > AuthorDate: 2022-12-28 18:17:53 +0000 > Commit: Konstantin Belousov > CommitDate: 2022-12-29 20:55:39 +0000 > > ffs_suspend.c: clean up includes > > Order includes alphabetically. > Remove unneeded sys/param.h, it is already included by sys/systm.h. > > Reviewed by: mckusick > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > Differential revision: https://reviews.freebsd.org/D37896 > --- > sys/ufs/ffs/ffs_suspend.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/sys/ufs/ffs/ffs_suspend.c b/sys/ufs/ffs/ffs_suspend.c > index d13097109758..e7c976b6e921 100644 > --- a/sys/ufs/ffs/ffs_suspend.c > +++ b/sys/ufs/ffs/ffs_suspend.c > @@ -33,15 +33,14 @@ > #include > __FBSDID("$FreeBSD$"); > > -#include > #include > #include > -#include > -#include > -#include > #include > +#include > #include > +#include > #include > +#include > > #include > > tinderbox fails the KCSAN et al kernels: In file included from /usr/src/sys/ufs/ffs/ffs_suspend.c:36: In file included from /usr/src/sys/sys/systm.h:44: In file included from ./machine/atomic.h:73: /usr/src/sys/sys/atomic_san.h:117:24: error: unknown type name 'uint8_t' ATOMIC_SAN_FUNCS(char, uint8_t); ^ it bisects to this commit -- Mateusz Guzik