From nobody Wed Feb 22 21:41:39 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PMV3T5mm5z3sFV7; Wed, 22 Feb 2023 21:41:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PMV3T5LGjz3RD7; Wed, 22 Feb 2023 21:41:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677102101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZEQrUa1dlcp+Y/8YCP61zCsPZU7j6mqRU0eYVI4SK7M=; b=t91SfcOQJcEIKCGmEvOItIWBGaOztaDNMQtCX0shmkN+1dmIdxW9OnXiJrRWgZUaibHZF5 XQjQEmVo7fVKwzfWFgxPdIUn6CL01wKdsoWGy+lezlMaydJm8aKDMSPScqNpH64ha7Tpvc stvHVJN5RFR/jjQL+bHOGuWODOpEYsezq/CTcHLvOd62V1S+YPLBcRAyR6hst7PU6pRICt AzIa7BTVdK49U8qT9wXGMc5Hz7aeqmYrAMNHtalpiSdA2JpHSMCwF5CmN98GQW5KXENQOa gyEoKQzNQnRfIJEtSEzS8nWnPYcONX8vfcI2qB4h0UQDApfdQHdLuG1ZQhmwHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677102101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZEQrUa1dlcp+Y/8YCP61zCsPZU7j6mqRU0eYVI4SK7M=; b=mupt6hTArpIptgr7St8s/G6gRaZ7rNLTsjySpp0nZwIfRW/4w/7S8g51h9B8sCZ68pEAFQ RQXF+QGiwbYBSCArD3FAgGgTUqYuacYIfT6Dq1NGPEjQf+E54Ws+bHR7JBLfr/vZrntUHb cZoZ4rOBuB2z739Lv392UYpNaAtB7inKThR72+k3YjE2GhS/VMbSZPp+HqHhHH6vaK8TnW 3hsi7z7NQ0nM+tKBcmvios6RC5cOOslmRIgReEc1LEBTY2YyxQ1TU1YQkeJYG4CsjRBOAi 9JRTzL6gIqLV293ahDTc3uXVfBMEXDhWJzzJiBIhqIxdf2bAK0l57+bPu7CHkg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677102101; a=rsa-sha256; cv=none; b=ybP6aiFIufOjfem1QTDHxLi6DASyVTX6X0myXlwZnOtv3akfkuFCQAzbmX4CU8v/sRqUym /rgtHGS5Zt+jMlDTiRxfXwI6iX2Y3D8tS1ui6Np412cYsblSbysPkQ8YJfxbuN77wWMmdT XAsrM7jMmaRqZhBYkEYmYyIuRYjOL1wBP8ZData6sxlz77uYaep5akLavZLephqPk62KZC Jk6IXdYYqwhny6qjKZVrB9UaOiMzLtGA5Jx1nx9VUE3hHhUFH3q2tabAEtjzjdlAtnQeKX yeIz8Ba0RlpDd1+KwY1WtIcb2YApMAKW+XH/KZdZ1Ms4uRx80gp8sGYMqhFcWQ== Received: from [IPV6:2601:648:8680:16b0:a016:f345:edc0:be49] (unknown [IPv6:2601:648:8680:16b0:a016:f345:edc0:be49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PMV3T0YWhz184F; Wed, 22 Feb 2023 21:41:40 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Wed, 22 Feb 2023 13:41:39 -0800 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: git: 29c5f8bf9a01 - main - config: drop dependency on libnv Content-Language: en-US To: Kyle Evans , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202302080610.3186AOCE091192@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202302080610.3186AOCE091192@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 2/7/23 10:10 PM, Kyle Evans wrote: > The branch main has been updated by kevans: > > URL: https://cgit.FreeBSD.org/src/commit/?id=29c5f8bf9a011d92462977bae59b4889ec5d95ad > > commit 29c5f8bf9a011d92462977bae59b4889ec5d95ad > Author: Kyle Evans > AuthorDate: 2023-02-08 06:02:56 +0000 > Commit: Kyle Evans > CommitDate: 2023-02-08 06:09:19 +0000 > > config: drop dependency on libnv > > Compile mkmakefile.c as C++ instead and use an std::unordered_map to > accomplish the same goal. > > Reviewed by: imp > Sponsored by: Klara, Inc. > Sponsored by: NetApp, Inc. > Differential Revision: https://reviews.freebsd.org/D38275 I'm not quite sure how to fix it, but I believe this change is what has broken the clang-12 cross-build jobs on GitHub's actions. The error is a mismatch in the declarations of getopt() as the Linux one adds a 'throw ()' specifier. Note that clang-13 on the newer Ubuntu 22.04 builds file. I haven't tried examining the includes on 22.04 to see what has changed to avoid the error there. Here is the error from a recent run: In file included from /usr/include/x86_64-linux-gnu/bits/getopt_posix.h:27, 14356 from /usr/include/unistd.h:869, 14357 from /home/runner/work/freebsd-src/freebsd-src/tools/build/cross-build/include/linux/unistd.h:53, 14358 from /home/runner/work/freebsd-src/freebsd-src/tools/build/cross-build/include/common/unistd.h:39, 14359 from /home/runner/work/freebsd-src/freebsd-src/usr.sbin/config/main.cc:61: 14360 /usr/include/x86_64-linux-gnu/bits/getopt_core.h:91:12: error: declaration of ‘int getopt(int, char* const*, const char*) throw ()’ has a different exception specifier 14361 91 | extern int getopt (int ___argc, char *const *___argv, const char *__shortopts) 14362 | ^~~~~~ 14363 In file included from /home/runner/work/freebsd-src/freebsd-src/tools/build/cross-build/include/linux/unistd.h:52, 14364 from /home/runner/work/freebsd-src/freebsd-src/tools/build/cross-build/include/common/unistd.h:39, 14365 from /home/runner/work/freebsd-src/freebsd-src/usr.sbin/config/main.cc:61: 14366 /home/runner/work/freebsd-src/build/home/runner/work/freebsd-src/freebsd-src/amd64.amd64/tmp/legacy/usr/include/getopt.h:69:6: note: from previous declaration ‘int getopt(int, char* const*, const char*)’ 14367 69 | int getopt(int, char * const [], const char *); 14368 | ^~~~~~ (FWIW, one odd thing here that I can't figure out yet is that it appears that our local getopt.h was #included prior to the unistd.h wrapper which I think is probably the root issue, may just need to wrap some other header?) -- John Baldwin