From nobody Mon Feb 20 21:59:35 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PLGYC21vgz3sGBT; Mon, 20 Feb 2023 21:59:43 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PLGYC1WHlz3pvc; Mon, 20 Feb 2023 21:59:43 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676930383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AVCXJkB+rB/b6WQuOgb2r94feYJeqrg1oXOw8m7YMzM=; b=Rah/jGQC6DgDvdlutWRauDVw5Hl2ndqa4B73HH1oEEjZFFy1gqz563NehbpOZTHLoPpt7C Jg+lKBuUgsoTXsPvyaTE9o7PfsX4sl2nYorAlY6dLx2cIG11ktS5PZw2Sh6pRf7s3Oa97j Er5dMycyEMa7z0KtrPDE1iCo/wzWlHWRgYalGgLq3Lrim/yhBEUiT9QFZ37OMz20aYooJj 0HsQVyT3/+EPiYbrAE0Glr+GUk6HUjyAjQU6hIASIA0cHfqVh1XfUJpV9PkAQ3h4Ms6J3P PqTfwc3FU6vTtocbxYT3HEarxqqu5DBVG4Qzq6XacWrNdlDuhnh+eVK/qcg7gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676930383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AVCXJkB+rB/b6WQuOgb2r94feYJeqrg1oXOw8m7YMzM=; b=wK79kyk+5nBlzCUfFEn8QD43O+XmpOBvzzrv4DIm47zOSnsm7BIgyshi/qPcumIirJ6znF zDGr+uKHw/HRyQqA2l/yxJJDEZ+c9ge3u7aoE0RFi3dNJ78zWOk1pQyvZ1Gi3wdflQwvWd ApRURbNvRoY7FAZVLUrWdi0IgO4ySKWzLrQU69OWk814SfLpg/ynBLp5iWS0F+hyb97sMY VetceEK/g5fW1hl+rQAYad+5vbNNmq9zKPh9Mt8sJgOa/mFJShiXKXwojazEAm3dzv/1O2 9AxsDBjecmV+H2wM1BDxLGcMrGCv4rlgUmp3IwLKRakLLaJgXYNph3otaEs8Dg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676930383; a=rsa-sha256; cv=none; b=LDw3GOEmJzR9nlV19MGP7ORoEUNEl0K0dgH6Cc45HL1D1JGzKvR3N71WmwQRqWzqXuxoby e2IHlk8jN6+8aF2MlzLLRWJRJroT9YlLB+eCOMyk+THUsEC+poyuAGhUy+iTS3u+qeRfJG MxDj7ZE0wnVEHkI+D9MW8UuGM11OMpvTXb2efSarC1ZlziRFiru07oUjNbJnEHlv346lqk PDIOC+sIG6OoSG7wkf/cW+7mh/6Zxowxb6KHkx57vFpKfLVfIG5MMBb/pfM600JJyqdp9m Ed2NuzASdk+DxCgjgUeRKX/svp7YWNax1RJUF2XeT/j9Vi3f/eWh0Q53hP+QWw== Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PLGYC0PnJzGbG; Mon, 20 Feb 2023 21:59:43 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qv1-f41.google.com with SMTP id nv15so2829823qvb.7; Mon, 20 Feb 2023 13:59:43 -0800 (PST) X-Gm-Message-State: AO0yUKWHlj4D+HItioOt7oyFShDevq+7qusOVzkYndCL0ZzO5cIA9+6n Qzc7etroMWJ7Zw0yJcGlCny4lkT166g73mY1qF4= X-Google-Smtp-Source: AK7set/kN/qsVgkD4+LwlxhepRqm+UlyaGYrbyMhCggXkz+dHZzaEz4Dxyxb2NFrY+ER9Ky+IbGycNmISCoF39/Yx7o= X-Received: by 2002:a0c:cd0c:0:b0:537:2334:7fb3 with SMTP id b12-20020a0ccd0c000000b0053723347fb3mr604480qvm.59.1676930382002; Mon, 20 Feb 2023 13:59:42 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202302201855.31KItK45079891@gitrepo.freebsd.org> <870983EF-591C-4685-A133-1E0E37CF0B98@freebsd.org> In-Reply-To: <870983EF-591C-4685-A133-1E0E37CF0B98@freebsd.org> From: Kyle Evans Date: Mon, 20 Feb 2023 15:59:35 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: cd73914b01a1 - main - kern: physmem: don't truncate addresses in DEBUG output To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-ThisMailContainsUnwantedMimeParts: N On Mon, Feb 20, 2023 at 1:41 PM Jessica Clarke wrote: > > On 20 Feb 2023, at 18:55, Kyle Evans wrote: > > > > The branch main has been updated by kevans: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=cd73914b01a1f2300e587f802383cc563f2e7103 > > > > commit cd73914b01a1f2300e587f802383cc563f2e7103 > > Author: Kyle Evans > > AuthorDate: 2023-02-20 18:54:00 +0000 > > Commit: Kyle Evans > > CommitDate: 2023-02-20 18:55:04 +0000 > > > > kern: physmem: don't truncate addresses in DEBUG output > > > > Make it consistent with the above region printing, otherwise it appears > > to be somewhat confusing. > > --- > > sys/kern/subr_physmem.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/sys/kern/subr_physmem.c b/sys/kern/subr_physmem.c > > index bb6af5a580aa..d371e1e166c5 100644 > > --- a/sys/kern/subr_physmem.c > > +++ b/sys/kern/subr_physmem.c > > @@ -149,10 +149,10 @@ physmem_dump_tables(int (*prfunc)(const char *, ...)) > > #ifdef DEBUG > > prfunc("Avail lists:\n"); > > for (i = 0; phys_avail[i] != 0; ++i) { > > - prfunc(" phys_avail[%d] 0x%08x\n", i, phys_avail[i]); > > + prfunc(" phys_avail[%d] 0x%08jx\n", i, phys_avail[i]); > > You need to actually cast them though for 32-bit. > Huh, interesting; wasn't there a compiler warning for this? armv7 and riscv both seemed to have built fine (+ DEBUG), am I misremembering that and it's just a potential source of garbage at runtime? Thanks, Kyle Evans