From nobody Wed Feb 15 21:42:12 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PHBPN3Xmzz3rNGY for ; Wed, 15 Feb 2023 21:42:16 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Received: from heemeyer.club (heemeyer.club [195.93.173.158]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PHBPM1YD1z3NL4; Wed, 15 Feb 2023 21:42:14 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of dchagin@heemeyer.club has no SPF policy when checking 195.93.173.158) smtp.mailfrom=dchagin@heemeyer.club; dmarc=none Received: from heemeyer.club (localhost [127.0.0.1]) by heemeyer.club (8.17.1/8.16.1) with ESMTP id 31FLgC1x089312; Thu, 16 Feb 2023 00:42:12 +0300 (MSK) (envelope-from dchagin@heemeyer.club) Received: (from dchagin@localhost) by heemeyer.club (8.17.1/8.16.1/Submit) id 31FLgCf1089311; Thu, 16 Feb 2023 00:42:12 +0300 (MSK) (envelope-from dchagin) Date: Thu, 16 Feb 2023 00:42:12 +0300 From: Dmitry Chagin To: Mark Millard Cc: antoine@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: c21b080f3dc2 - main - cpuset: Fix sched_[g|s]etaffinity() for better compatibility with Linux. (Just a fixed TO: address.) Message-ID: References: <18263DB1-D79D-420A-9F24-EE8C8E071C15@yahoo.com> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Result: default: False [-2.10 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; FREEMAIL_TO(0.00)[yahoo.com]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:61400, ipnet:195.93.173.0/24, country:RU]; MIME_TRACE(0.00)[0:+]; R_SPF_NA(0.00)[no SPF record]; RCVD_COUNT_THREE(0.00)[3]; RCVD_TLS_LAST(0.00)[]; FREEFALL_USER(0.00)[dchagin]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[heemeyer.club]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Queue-Id: 4PHBPM1YD1z3NL4 X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N On Mon, Feb 13, 2023 at 04:47:04PM -0800, Mark Millard wrote: > On Feb 12, 2023, at 22:05, Mark Millard wrote: > > > [Just a fixed TO: address.] > > > >>> On Sun, Feb 12, 2023 at 07:58:07PM +0000, Antoine Brodin wrote: > >>>> On Sun, Feb 12, 2023 at 11:13 AM Dmitry Chagin wrote: > >>>>> > >>>>> On Sun, Feb 12, 2023 at 01:40:59PM +0300, Dmitry Chagin wrote: > >>>>>> On Sun, Feb 12, 2023 at 09:47:15AM +0000, Antoine Brodin wrote: > >>>>>>> On Sun, Jan 29, 2023 at 1:18 PM Dmitry Chagin wrote: > >>>>>>>> > >>>>>>>> The branch main has been updated by dchagin: > >>>>>>>> > >>>>>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=c21b080f3dc2f5e91ada608d4385b7ed6538ba9b > >>>>>>>> > >>>>>>>> commit c21b080f3dc2f5e91ada608d4385b7ed6538ba9b > >>>>>>>> Author: Dmitry Chagin > >>>>>>>> AuthorDate: 2023-01-29 13:17:33 +0000 > >>>>>>>> Commit: Dmitry Chagin > >>>>>>>> CommitDate: 2023-01-29 13:17:33 +0000 > >>>>>>>> > >>>>>>>> cpuset: Fix sched_[g|s]etaffinity() for better compatibility with Linux. > >>>>>>>> > >>>>>>>> Under Linux to sched_[g|s]etaffinity() functions the value returned from a call > >>>>>>>> to gettid(2) (thread id) can be passed in the argument pid. Specifying pid as 0 > >>>>>>>> will set the attribute for the calling thread, and passing the value returned > >>>>>>>> from a call to getpid(2) (process id) will set the attribute for the main thread > >>>>>>>> of the thread group. > >>>>>>>> > >>>>>>>> Native cpuset(2) family of system calls has "which" argument to determine how > >>>>>>>> the value of id argument is interpreted, i.e., CPU_WHICH_TID is used to pass > >>>>>>>> a thread id and CPU_WHICH_PID - to pass a process id. > >>>>>>>> > >>>>>>>> For now native sched_[g|s]etaffinity() implementation is wrong as uses "which" > >>>>>>>> CPU_WHICH_PID to pass both (process and thread id) to the kernel. To fix this > >>>>>>>> adding a new "which" CPU_WHICH_TIDPID intended to handle both id's. > >>>>>>>> > >>>>>>>> Reviewed by: kib > >>>>>>>> Differential Revision: https://reviews.freebsd.org/D38209 > >>>>>>>> MFC after: 1 week > >>>>>>>> --- > >>>>>>>> lib/libc/gen/sched_getaffinity.c | 2 +- > >>>>>>>> lib/libc/gen/sched_setaffinity.c | 2 +- > >>>>>>>> lib/libc/sys/cpuset.2 | 4 +++- > >>>>>>>> sys/kern/kern_cpuset.c | 42 +++++++++++++++++++++++++++++++++++++++- > >>>>>>>> sys/sys/cpuset.h | 1 + > >>>>>>>> 5 files changed, 47 insertions(+), 4 deletions(-) > >>>>>>> > >>>>>>> > >>>>>>> Hello, > >>>>>>> > >>>>>>> This broke math/py-numpy on main and stable/13 > >>>>>>> > >>>>>>> https://pkg-status.freebsd.org/gohan03/data/main-amd64-default-baseline/p52768539d46f_scd3193f640/logs/errors/py39-numpy-1.24.1,1.log > > > > Well, can a 1400073 [2022-10-17..2022-12-09] HOST kernel running a > > 1400079 [2023-02-08..2023-02-10] jail that is using new KBI > > material not in the older kernel (CPU_WHICH_TIDPID) have problems? : > > > > =>> Building math/py-numpy > > build started at Fri Feb 10 11:40:51 UTC 2023 > > port directory: /usr/ports/math/py-numpy > > package name: py39-numpy-1.24.1,1 > > building for: FreeBSD main-amd64-default-baseline-job-04 14.0-CURRENT FreeBSD 14.0-CURRENT 1400079 amd64 > > maintained by: python@FreeBSD.org > > Makefile ident: > > Poudriere version: 3.2.8-23-ga7f8d188 > > Host OSVERSION: 1400073 > > Jail OSVERSION: 1400079 > > Job Id: 04 > > > > !!! Jail is newer than host. (Jail: 1400079, Host: 1400073) !!! > > !!! This is not supported. !!! > > !!! Host kernel must be same or newer than jail. !!! > > !!! Expect build failures. !!! > > > > > >>>>>>> https://pkg-status.freebsd.org/gohan02/data/13stable-amd64-quarterly-baseline/841610d9bfc6/logs/errors/py39-numpy-1.23.5_1,1.log > > > > Similarly, can a 1400073 [2022-10-17..2022-12-09] HOST kernel running a > > 13.2-PRERELEASE 1301511 [2023-01-10..2023-02-10] jail that is using new > > KBI material not in the older kernel (CPU_WHICH_TIDPID) have problems? : > > > > =>> Building math/py-numpy > > build started at Fri Feb 10 10:36:27 UTC 2023 > > port directory: /usr/ports/math/py-numpy > > package name: py39-numpy-1.23.5_1,1 > > building for: FreeBSD 13stable-amd64-quarterly-baseline-job-01 13.2-PRERELEASE FreeBSD 13.2-PRERELEASE 1301511 amd64 > > maintained by: python@FreeBSD.org > > Makefile ident: > > Poudriere version: 3.2.8-23-ga7f8d188 > > Host OSVERSION: 1400073 > > Jail OSVERSION: 1301511 > > > > > > > > (Looks to me like CPU_WHICH_TIDPID use for 13.* has to > > require 13.2+ .) > > (I should have used "some CPU_WHICH_TIDPID use" and the > like in various places.) > > I got my environment to be 140079 (everywhere) with ports > updated to be have py39-numpy be at 1.24.1,1 . My > poudriere-devel build result was: > > [00:25:52] [01] [00:00:00] Building math/py-numpy@py39 | py39-numpy-1.24.1,1 > [00:28:39] [01] [00:02:47] Finished math/py-numpy@py39 | py39-numpy-1.24.1,1: Success > > (It built 47 other ports first to get ready for that.) > > FYI: > > # uname -apKU > FreeBSD amd64_ZFS 14.0-CURRENT FreeBSD 14.0-CURRENT #60 main-n260797-dc1b8c9a846e-dirty: Thu Feb 9 22:17:26 PST 2023 root@amd64_ZFS:/usr/obj/BUILDs/main-amd64-nodbg-clang/usr/main-src/amd64.amd64/sys/GENERIC-NODBG amd64 amd64 1400079 1400079 > > Looks to me like, if the ABI incompatibilities are to > stay as they are, then the FreeBSD build servers need an > update for HOST OSVERSION to be more modern in order to > avoid having odd problems with building some ports. > > compat shim commited to main branch, MFC after 3 days