From nobody Wed Feb 15 16:34:53 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PH3Zz1RgKz3qWsc; Wed, 15 Feb 2023 16:35:07 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PH3Zy6VVTz3mSl; Wed, 15 Feb 2023 16:35:06 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-vk1-f172.google.com with SMTP id n22so6027060vkm.11; Wed, 15 Feb 2023 08:35:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676478906; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y2qLFpQ+fagAlZozY6/gZ1eVXvOOOJtkO+FgSl5EGBo=; b=B/qSt29gIPshaiJmKrGn2QFCpGTZIkZtZHe8n0CUvKQbMnMFzc0sSTS7ZBDCfwRSuw +CZLplnkbV1pP0VAmeQWtmH8pCpJsHqBgZ56MTcz7Lqgwo9jzOlai4EmN8o0DyKF4+Nh dTUArvLG3x5vRZxPDWiDO2Onr3JVIYkE0k05URf3rDwbfSyhZwe7VpqLamwnFjLTw9yu +RjAJDaBjCzrJWRjnZ4RL5hxIqjtSc4MbMIyhYEyBIq7RYlsz2vVevYe5NGG9ARB+3D0 0KGmCNM/tRYZwjZXHmNMN6HlAypq0ejI/OY/eLPER4jhgBlqKkhKZqfQHTdBeTaZA3k5 +2Og== X-Gm-Message-State: AO0yUKUgsLR+Ew5SFVM7WddgdrI2XMjxlcVlQGL++ASbQyIGPPWVT9pb FITrqaEnzAOUKU/KFeRryLy4iLjglnbO6sjjVR32v32A X-Google-Smtp-Source: AK7set+uLtYqTIR//bsSZDRE3CDlGk9XRhYib1cfTFB5gP+5IGCfAHcKvcpXle9fx+A6vL3bYBeBx6K1xeleYbwiCs8= X-Received: by 2002:a05:6122:1436:b0:3e1:f8b0:e35d with SMTP id o22-20020a056122143600b003e1f8b0e35dmr413190vkp.35.1676478905691; Wed, 15 Feb 2023 08:35:05 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202205241917.24OJHipu099732@gitrepo.freebsd.org> <20230215103139.c66c65a80b9be787deaa36a2@bidouilliste.com> In-Reply-To: <20230215103139.c66c65a80b9be787deaa36a2@bidouilliste.com> From: Alan Somers Date: Wed, 15 Feb 2023 09:34:53 -0700 Message-ID: Subject: Re: git: 7919c76dbdd2 - main - bsdinstall: use gpt/efiboot0 label in /etc/fstab To: Emmanuel Vadot Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4PH3Zy6VVTz3mSl X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Wed, Feb 15, 2023 at 2:31 AM Emmanuel Vadot wrote: > > > Hello Alan, > > On Tue, 24 May 2022 19:17:44 GMT > Alan Somers wrote: > > > The branch main has been updated by asomers: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=7919c76dbdd20161247d1bfb647110d87ca5ee0f > > > > commit 7919c76dbdd20161247d1bfb647110d87ca5ee0f > > Author: Alan Somers > > AuthorDate: 2022-05-24 18:24:12 +0000 > > Commit: Alan Somers > > CommitDate: 2022-05-24 19:17:10 +0000 > > > > bsdinstall: use gpt/efiboot0 label in /etc/fstab > > > > Otherwise, boot will hang if the numbering of disks has changed since > > initial install. > > > > MFC after: 2 weeks > > Sponsored by: Axcient > > Reviewed by: brd > > Differential Revision: https://reviews.freebsd.org/D35309 > > So, I understand the initial problem but this causes a new one. > efibootmgr is now confused when you ask to print the unix path of the > ESP because the device resolved is still ada0p1 (for example) and since > it's not mounted anymore as the label is used we can't discover the > path to the mounted ESP. > Since it's now in 13.2 we've just noticed that at work. > We will parse glabel but it's really horrible to parse and it be good > to have efibootmgr -E -p working again on a fresh install. > > Cheers, > > -- > Emmanuel Vadot Annoying. Could you please open a bugzilla PR so we don't lose track of this?