Re: git: c21b080f3dc2 - main - cpuset: Fix sched_[g|s]etaffinity() for better compatibility with Linux.

Reply: Mark Millard : "Re: git: c21b080f3dc2 - main - cpuset: Fix sched_[g|s]etaffinity() for better compatibility with Linux. (Just a fixed TO: address.)"
Go to: [ bottom of page ] [ top of archives ] [ this month ]
From: Mark Millard <marklmi_at_yahoo.com>
Date: Mon, 13 Feb 2023 05:55:46 UTC

> > On Sun, Feb 12, 2023 at 07:58:07PM +0000, Antoine Brodin wrote:
> > > On Sun, Feb 12, 2023 at 11:13 AM Dmitry Chagin <dchagin@heemeyer.club> wrote:
> > > >
> > > > On Sun, Feb 12, 2023 at 01:40:59PM +0300, Dmitry Chagin wrote:
> > > > > On Sun, Feb 12, 2023 at 09:47:15AM +0000, Antoine Brodin wrote:
> > > > > > On Sun, Jan 29, 2023 at 1:18 PM Dmitry Chagin <dchagin@freebsd.org> wrote:
> > > > > > >
> > > > > > > The branch main has been updated by dchagin:
> > > > > > >
> > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=c21b080f3dc2f5e91ada608d4385b7ed6538ba9b
> > > > > > >
> > > > > > > commit c21b080f3dc2f5e91ada608d4385b7ed6538ba9b
> > > > > > > Author: Dmitry Chagin <dchagin@FreeBSD.org>
> > > > > > > AuthorDate: 2023-01-29 13:17:33 +0000
> > > > > > > Commit: Dmitry Chagin <dchagin@FreeBSD.org>
> > > > > > > CommitDate: 2023-01-29 13:17:33 +0000
> > > > > > >
> > > > > > > cpuset: Fix sched_[g|s]etaffinity() for better compatibility with Linux.
> > > > > > >
> > > > > > > Under Linux to sched_[g|s]etaffinity() functions the value returned from a call
> > > > > > > to gettid(2) (thread id) can be passed in the argument pid. Specifying pid as 0
> > > > > > > will set the attribute for the calling thread, and passing the value returned
> > > > > > > from a call to getpid(2) (process id) will set the attribute for the main thread
> > > > > > > of the thread group.
> > > > > > >
> > > > > > > Native cpuset(2) family of system calls has "which" argument to determine how
> > > > > > > the value of id argument is interpreted, i.e., CPU_WHICH_TID is used to pass
> > > > > > > a thread id and CPU_WHICH_PID - to pass a process id.
> > > > > > >
> > > > > > > For now native sched_[g|s]etaffinity() implementation is wrong as uses "which"
> > > > > > > CPU_WHICH_PID to pass both (process and thread id) to the kernel. To fix this
> > > > > > > adding a new "which" CPU_WHICH_TIDPID intended to handle both id's.
> > > > > > >
> > > > > > > Reviewed by: kib
> > > > > > > Differential Revision: https://reviews.freebsd.org/D38209
> > > > > > > MFC after: 1 week
> > > > > > > ---
> > > > > > > lib/libc/gen/sched_getaffinity.c | 2 +-
> > > > > > > lib/libc/gen/sched_setaffinity.c | 2 +-
> > > > > > > lib/libc/sys/cpuset.2 | 4 +++-
> > > > > > > sys/kern/kern_cpuset.c | 42 +++++++++++++++++++++++++++++++++++++++-
> > > > > > > sys/sys/cpuset.h | 1 +
> > > > > > > 5 files changed, 47 insertions(+), 4 deletions(-)
> > > > > >
> > > > > >
> > > > > > Hello,
> > > > > >
> > > > > > This broke math/py-numpy on main and stable/13
> > > > > >
> > > > > > https://pkg-status.freebsd.org/gohan03/data/main-amd64-default-baseline/p52768539d46f_scd3193f640/logs/errors/py39-numpy-1.24.1,1.log

Well, can a 1400073 [2022-10-17..2022-12-09] HOST kernel running a
1400079 [2023-02-08..2023-02-10] jail that is using new KBI
material not in the older kernel (CPU_WHICH_TIDPID) have problems? :

=>> Building math/py-numpy
build started at Fri Feb 10 11:40:51 UTC 2023
port directory: /usr/ports/math/py-numpy
package name: py39-numpy-1.24.1,1
building for: FreeBSD main-amd64-default-baseline-job-04 14.0-CURRENT FreeBSD 14.0-CURRENT 1400079 amd64
maintained by: python@FreeBSD.org
Makefile ident: 
Poudriere version: 3.2.8-23-ga7f8d188
Host OSVERSION: 1400073
Jail OSVERSION: 1400079
Job Id: 04

!!! Jail is newer than host. (Jail: 1400079, Host: 1400073) !!!
!!! This is not supported. !!!
!!! Host kernel must be same or newer than jail. !!!
!!! Expect build failures. !!!


> > > > > > https://pkg-status.freebsd.org/gohan02/data/13stable-amd64-quarterly-baseline/841610d9bfc6/logs/errors/py39-numpy-1.23.5_1,1.log

Similarly, can a 1400073 [2022-10-17..2022-12-09] HOST kernel running a
13.2-PRERELEASE 1301511 [2023-01-10..2023-02-10] jail that is using new
KBI material not in the older kernel (CPU_WHICH_TIDPID) have problems? :

=>> Building math/py-numpy
build started at Fri Feb 10 10:36:27 UTC 2023
port directory: /usr/ports/math/py-numpy
package name: py39-numpy-1.23.5_1,1
building for: FreeBSD 13stable-amd64-quarterly-baseline-job-01 13.2-PRERELEASE FreeBSD 13.2-PRERELEASE 1301511 amd64
maintained by: python@FreeBSD.org
Makefile ident: 
Poudriere version: 3.2.8-23-ga7f8d188
Host OSVERSION: 1400073
Jail OSVERSION: 1301511



(Looks to me like CPU_WHICH_TIDPID use for 13.* has to
require 13.2+ .)

===
Mark Millard
marklmi at yahoo.com