From nobody Mon Feb 13 01:52:47 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFS5x3CvFz3py3p for ; Mon, 13 Feb 2023 01:52:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFS5x0wywz3l7c for ; Mon, 13 Feb 2023 01:52:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x633.google.com with SMTP id hx15so28319053ejc.11 for ; Sun, 12 Feb 2023 17:52:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FT5aMJrFrMFhpHcN9mGpTOScP5Gp3OclSmKb+zlJUGY=; b=bTBWG3TkwO8psREX7KDgT9mt+mrKxH83kV7kGVikjrDxY60gPn7p+E2QD7crMu+6d+ FYpF+jDqywq4S6ldmDjlikHnJ5vr8gqPajyDTK9P9/2SZg1GJoFhQT3JV8n7nQaA+bJ0 2j/VXryDjKyhiIDZq+N33NY62Jpxk0SDldJCmX9ObZPjYJTRontAVZ6yokeTyIbsxKRz oM6kuHCVDMr6slA0QoaPvFY8N0kUMbeC3KrbR2HTgMFjRqlUA3EjGldfMA3s8lxBVgpq +LJbeQX6o6Xd5aVQvNe6QD2adG+Fwna/tMP1dBxzAeyCyWxysquG/qUHbPFDe/C71uxw OcHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FT5aMJrFrMFhpHcN9mGpTOScP5Gp3OclSmKb+zlJUGY=; b=Agy3kYm9YzLu9wYE+Hjos1LwZ8HX9iWWnJZG+wjR6aNJa0Xqt68/kB8VeinUQYm71W VSohoyBOYjQA9F1a99iX1gmJCSuyrt9DHXsBO9+lMF6wBW1ph0AyxN3c5n+jeOMTqWkR 1uXtYxCnx5r+cJOVaSPa5WF5IeuLz7mujhJb3bwWrFVnjHC2zZT1LY1wNrq0LhH7vujm 7XHwLPBbScGIEG6LwzQjDa4m2EBCqRS+gd7ayCEwWN3w25+rIwt006bdgBTXSnER1ID1 ambRlOOoHOLGB/sFAE69B1aSYIHT/de8Wy3kRVARE7EV7sTMfUHGlfspONhuhuAMoAs+ G9OA== X-Gm-Message-State: AO0yUKWKrE74JDEu9Ypl40et5V4or+iPB4qLr/7KeSyhMlYxVCwjRuuU uPeUNa2eTrm8ihauq9d9ueGQQPnuZWADTZrb7aUrHw== X-Google-Smtp-Source: AK7set8H2qKfrG4wFnRRBUIO7QJCxHit17sbKGcEDgOEpbi1TJrPs9trEAlk9PwK6txhuQudCVyb3P7CbbUqytl7xso= X-Received: by 2002:a17:906:8403:b0:8b0:7c88:e869 with SMTP id n3-20020a170906840300b008b07c88e869mr2150482ejx.2.1676253171093; Sun, 12 Feb 2023 17:52:51 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202302122113.31CLD2av012258@gitrepo.freebsd.org> <72B4A01A-521D-4739-B1DD-6A19E98771EE@freebsd.org> <05AA573A-9692-40C3-8BF6-D52864BAB337@freebsd.org> In-Reply-To: From: Warner Losh Date: Sun, 12 Feb 2023 18:52:47 -0700 Message-ID: Subject: Re: git: eca005d8531f - main - zlib: silence K&R warns To: Mateusz Guzik Cc: Jessica Clarke , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="000000000000d124d105f48b1a39" X-Rspamd-Queue-Id: 4PFS5x0wywz3l7c X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000d124d105f48b1a39 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Feb 12, 2023 at 3:12 PM Mateusz Guzik wrote: > On 2/12/23, Warner Losh wrote: > > On Sun, Feb 12, 2023 at 2:54 PM Mateusz Guzik wrote= : > > > >> On 2/12/23, Warner Losh wrote: > >> > On Sun, Feb 12, 2023 at 2:40 PM Mateusz Guzik > >> > wrote: > >> > > >> >> On 2/12/23, Jessica Clarke wrote: > >> >> > On 12 Feb 2023, at 21:23, Mateusz Guzik wrote= : > >> >> >> > >> >> >> On 2/12/23, Jessica Clarke wrote: > >> >> >>> On 12 Feb 2023, at 21:13, Mateusz Guzik wrote= : > >> >> >>>> > >> >> >>>> The branch main has been updated by mjg: > >> >> >>>> > >> >> >>>> URL: > >> >> >>>> > >> >> > >> > https://cgit.FreeBSD.org/src/commit/?id=3Deca005d8531fd153f46f941f3101e73= cdf181a0b > >> >> >>>> > >> >> >>>> commit eca005d8531fd153f46f941f3101e73cdf181a0b > >> >> >>>> Author: Mateusz Guzik > >> >> >>>> AuthorDate: 2023-02-12 21:12:34 +0000 > >> >> >>>> Commit: Mateusz Guzik > >> >> >>>> CommitDate: 2023-02-12 21:12:34 +0000 > >> >> >>>> > >> >> >>>> zlib: silence K&R warns > >> >> >>>> > >> >> >>>> Sponsored by: Rubicon Communications, LLC ("Netgate") > >> >> >>>> --- > >> >> >>>> sys/conf/files | 18 +++++++++++------- > >> >> >>>> sys/modules/zlib/Makefile | 2 ++ > >> >> >>>> 2 files changed, 13 insertions(+), 7 deletions(-) > >> >> >>>> > >> >> >>>> diff --git a/sys/conf/files b/sys/conf/files > >> >> >>>> index 9171b434a7bf..53f90f7afc22 100644 > >> >> >>>> --- a/sys/conf/files > >> >> >>>> +++ b/sys/conf/files > >> >> >>>> @@ -4099,28 +4099,32 @@ libkern/strtouq.c standard > >> >> >>>> libkern/strvalid.c standard > >> >> >>>> libkern/timingsafe_bcmp.c standard > >> >> >>>> contrib/zlib/adler32.c optional crypto | geom_uzip= | > >> >> >>>> \ > >> >> >>>> - mxge | ddb_ctf | gzio | zfs | zlib > >> >> >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ > >> >> >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" > >> >> >>> > >> >> >>> This doesn=E2=80=99t exist pre-Clang 15. > >> >> >>> > >> >> >> > >> >> >> this is main-only and it already has llvm15. the build requireme= nt > >> >> >> is > >> >> >> top of the branch, so I don't see a problem. > >> >> >> > >> >> >> if you ran into trouble cross-compiling, you should probably > update > >> >> >> that env instead of expecting working around the warn in the tre= e > >> >> >> for > >> >> >> older compilers > >> >> > > >> >> > That is not our policy. Please fix this. > >> >> > > >> >> > >> >> Are you sure about that? I distinctly recall the supported path to > get > >> >> top of the latest stable branch first, from there you should be abl= e > >> >> to build the toolchain and the kernel. > >> >> > >> >> afaics the above change did not affect it > >> >> > >> >> If you insist, I can look for the exact paragraph in the docs. > >> >> > >> > > >> > The fix is trivial. > >> > > >> > https://reviews.freebsd.org/D38550 > >> > > >> > Please focus your efforts on commenting on the above and testing it > >> > out. > >> > > >> > >> there is no warn with it > >> > >> but where is it stated that a compiler older than the newest in the > >> tree is supported for kernel builds? > >> > > > > As a project we've always benefitted from flexibility when it's trivial > to > > be flexible. > > > > Look, I just want the build to be warn-free again and I don't care how > zlib is handled for that purpose. > > I do note though that if "compiler flexibility" if you will is to be > expected, it should be stated somewhere. Again, I only recall the > opposite -- top of main needed to build the kernel. > % cd src % find . -name Makefile\* -o -name \*.mk | xargs grep clang | wc 760 2843 57563 % find . -name Makefile\* -o -name \*.mk | xargs grep gcc | wc 337 1760 25053 % find . -name Makefile\* -o -name \*.mk | xargs grep COMPILER_VERSION | wc 79 478 6061 over 1000 clang or gcc specific bits speaks for itself. Warner > > Warner > > > > > >> > > >> > > >> >> > Jess > >> >> > > >> >> >>> Jess > >> >> >>> > >> >> >>>> contrib/zlib/compress.c optional crypto | geom_uzip= | > >> >> >>>> \ > >> >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >> >>>> - compile-with "${NORMAL_C} -Wno-cast-qual" > >> >> >>>> + compile-with "${NORMAL_C} -Wno-cast-qual > >> >> >>>> -Wno-deprecated-non-prototype" > >> >> >>>> contrib/zlib/crc32.c optional crypto | geom_uzip= | > >> >> >>>> \ > >> >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >> >>>> compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" > >> >> >>>> contrib/zlib/deflate.c optional crypto | geom_uzip= | > >> >> >>>> \ > >> >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >> >>>> - compile-with "${NORMAL_C} -Wno-cast-qual" > >> >> >>>> + compile-with "${NORMAL_C} -Wno-cast-qual > >> >> >>>> -Wno-deprecated-non-prototype" > >> >> >>>> contrib/zlib/inffast.c optional crypto | geom_uzip= | > >> >> >>>> \ > >> >> >>>> - mxge | ddb_ctf | gzio | zfs | zlib > >> >> >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ > >> >> >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" > >> >> >>>> contrib/zlib/inflate.c optional crypto | geom_uzip= | > >> >> >>>> \ > >> >> >>>> - mxge | ddb_ctf | gzio | zfs | zlib > >> >> >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ > >> >> >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" > >> >> >>>> contrib/zlib/inftrees.c optional crypto | geom_uzip= | > >> >> >>>> \ > >> >> >>>> - mxge | ddb_ctf | gzio | zfs | zlib > >> >> >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ > >> >> >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" > >> >> >>>> contrib/zlib/trees.c optional crypto | geom_uzip= | > >> >> >>>> \ > >> >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >> >>>> compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" > >> >> >>>> contrib/zlib/uncompr.c optional crypto | geom_uzip= | > >> >> >>>> \ > >> >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >> >>>> - compile-with "${NORMAL_C} -Wno-cast-qual" > >> >> >>>> + compile-with "${NORMAL_C} -Wno-cast-qual > >> >> >>>> -Wno-deprecated-non-prototype" > >> >> >>>> contrib/zlib/zutil.c optional crypto | geom_uzip= | > >> >> >>>> \ > >> >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >> >>>> compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" > >> >> >>>> diff --git a/sys/modules/zlib/Makefile > >> >> >>>> b/sys/modules/zlib/Makefile > >> >> >>>> index 6391255e512b..178d3a3f7ab7 100644 > >> >> >>>> --- a/sys/modules/zlib/Makefile > >> >> >>>> +++ b/sys/modules/zlib/Makefile > >> >> >>>> @@ -25,4 +25,6 @@ CWARNFLAGS.crc32.c+=3D${NO_WSTRICT_PROTOTYPE= S} # > >> >> >>>> crc32.c:586 > >> >> >>>> CWARNFLAGS.trees.c+=3D${NO_WSTRICT_PROTOTYPES} # trees.c:232 > >> >> >>>> CWARNFLAGS.zutil.c+=3D${NO_WSTRICT_PROTOTYPES} # zutil.c:27,32 > >> >> >>>> > >> >> >>>> +CWARNFLAGS+=3D-Wno-deprecated-non-prototype > >> >> >>>> + > >> >> >>>> .include > >> >> >>> > >> >> >>> > >> >> >> > >> >> >> > >> >> >> -- > >> >> >> Mateusz Guzik > >> >> > > >> >> > > >> >> > >> >> > >> >> -- > >> >> Mateusz Guzik > >> >> > >> > > >> > >> > >> -- > >> Mateusz Guzik > >> > > > > > -- > Mateusz Guzik > --000000000000d124d105f48b1a39 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sun, Feb 12, 2023 at 3:12 PM Mateu= sz Guzik <mjguzik@gmail.com>= wrote:
On 2/12/= 23, Warner Losh <imp= @bsdimp.com> wrote:
> On Sun, Feb 12, 2023 at 2:54 PM Mateusz Guzik <mjguzik@gmail.com> wrote:
>
>> On 2/12/23, Warner Losh <imp@bsdimp.com> wrote:
>> > On Sun, Feb 12, 2023 at 2:40 PM Mateusz Guzik <mjguzik@gmail.com>
>> > wrote:
>> >
>> >> On 2/12/23, Jessica Clarke <jrtc27@freebsd.org> wrote:
>> >> > On 12 Feb 2023, at 21:23, Mateusz Guzik <mjguzik@gmail.com> w= rote:
>> >> >>
>> >> >> On 2/12/23, Jessica Clarke <jrtc27@freebsd.org> wrote: >> >> >>> On 12 Feb 2023, at 21:13, Mateusz Guzik <= mjg@FreeBSD.org> wrote:
>> >> >>>>
>> >> >>>> The branch main has been updated by mjg:=
>> >> >>>>
>> >> >>>> URL:
>> >> >>>>
>> >>
>> https://c= git.FreeBSD.org/src/commit/?id=3Deca005d8531fd153f46f941f3101e73cdf181a0b
>> >> >>>>
>> >> >>>> commit eca005d8531fd153f46f941f3101e73cd= f181a0b
>> >> >>>> Author:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik= <mjg@FreeBSD.org>
>> >> >>>> AuthorDate: 2023-02-12 21:12:34 +0000 >> >> >>>> Commit:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik= <mjg@FreeBSD.org>
>> >> >>>> CommitDate: 2023-02-12 21:12:34 +0000 >> >> >>>>
>> >> >>>>=C2=A0 =C2=A0zlib: silence K&R warns<= br> >> >> >>>>
>> >> >>>>=C2=A0 =C2=A0Sponsored by:=C2=A0 =C2=A0Ru= bicon Communications, LLC ("Netgate")
>> >> >>>> ---
>> >> >>>> sys/conf/files=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 | 18 +++++++++++-------
>> >> >>>> sys/modules/zlib/Makefile |=C2=A0 2 ++ >> >> >>>> 2 files changed, 13 insertions(+), 7 del= etions(-)
>> >> >>>>
>> >> >>>> diff --git a/sys/conf/files b/sys/conf/f= iles
>> >> >>>> index 9171b434a7bf..53f90f7afc22 100644<= br> >> >> >>>> --- a/sys/conf/files
>> >> >>>> +++ b/sys/conf/files
>> >> >>>> @@ -4099,28 +4099,32 @@ libkern/strtouq.= c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 standard
>> >> >>>> libkern/strvalid.c=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0standard
>> >> >>>> libkern/timingsafe_bcmp.c=C2=A0 standard=
>> >> >>>> contrib/zlib/adler32.c=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip |
>> >> >>>> \
>> >> >>>> -=C2=A0 mxge | ddb_ctf | gzio | zfs | zl= ib
>> >> >>>> +=C2=A0 mxge | ddb_ctf | gzio | zfs | zl= ib \
>> >> >>>> +=C2=A0 compile-with "${NORMAL_C} -= Wno-deprecated-non-prototype"
>> >> >>>
>> >> >>> This doesn=E2=80=99t exist pre-Clang 15.
>> >> >>>
>> >> >>
>> >> >> this is main-only and it already has llvm15. the= build requirement
>> >> >> is
>> >> >> top of the branch, so I don't see a problem.=
>> >> >>
>> >> >> if you ran into trouble cross-compiling, you sho= uld probably update
>> >> >> that env instead of expecting working around the= warn in the tree
>> >> >> for
>> >> >> older compilers
>> >> >
>> >> > That is not our policy. Please fix this.
>> >> >
>> >>
>> >> Are you sure about that? I distinctly recall the supporte= d path to get
>> >> top of the latest stable branch first, from there you sho= uld be able
>> >> to build the toolchain and the kernel.
>> >>
>> >> afaics the above change did not affect it
>> >>
>> >> If you insist, I can look for the exact paragraph in the = docs.
>> >>
>> >
>> > The fix is trivial.
>> >
>> > https://reviews.freebsd.org/D38550
>> >
>> > Please focus your efforts on commenting on the above and test= ing it
>> > out.
>> >
>>
>> there is no warn with it
>>
>> but where is it stated that a compiler older than the newest in th= e
>> tree is supported for kernel builds?
>>
>
> As a project we've always benefitted from flexibility when it'= s trivial to
> be flexible.
>

Look, I just want the build to be warn-free again and I don't care how<= br> zlib is handled for that purpose.

I do note though that if "compiler flexibility" if you will is to= be
expected, it should be stated somewhere. Again, I only recall the
opposite -- top of main needed to build the kernel.
% cd src
% find . -name Makefile\* -o -name \*.mk | = xargs grep clang | wc
=C2=A0 =C2=A0 =C2=A0760 =C2=A0 =C2=A02843 =C2=A0 5= 7563
% find . -name Makefile\* -o -name \*.mk | xargs grep gcc | wc
= =C2=A0 =C2=A0 =C2=A0337 =C2=A0 =C2=A01760 =C2=A0 25053
% find . -name Ma= kefile\* -o -name \*.mk | xargs grep COMPILER_VERSION | wc
=C2=A0 =C2=A0= =C2=A0 79 =C2=A0 =C2=A0 478 =C2=A0 =C2=A06061
=C2=A0
over 1000 clang or gcc specific bits speaks for itself.
<= br>
Warner
> Warner
>
>
>> >
>> >
>> >> > Jess
>> >> >
>> >> >>> Jess
>> >> >>>
>> >> >>>> contrib/zlib/compress.c=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 optional crypto | geom_uzip |
>> >> >>>> \
>> >> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs= | zlib \
>> >> >>>> -=C2=A0 compile-with "${NORMAL_C} -= Wno-cast-qual"
>> >> >>>> +=C2=A0 compile-with "${NORMAL_C} -= Wno-cast-qual
>> >> >>>> -Wno-deprecated-non-prototype"
>> >> >>>> contrib/zlib/crc32.c=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip |
>> >> >>>> \
>> >> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs= | zlib \
>> >> >>>>=C2=A0 =C2=A0 compile-with "${NORMAL= _C} ${NO_WSTRICT_PROTOTYPES}"
>> >> >>>> contrib/zlib/deflate.c=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip |
>> >> >>>> \
>> >> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs= | zlib \
>> >> >>>> -=C2=A0 compile-with "${NORMAL_C} -= Wno-cast-qual"
>> >> >>>> +=C2=A0 compile-with "${NORMAL_C} -= Wno-cast-qual
>> >> >>>> -Wno-deprecated-non-prototype"
>> >> >>>> contrib/zlib/inffast.c=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip |
>> >> >>>> \
>> >> >>>> -=C2=A0 mxge | ddb_ctf | gzio | zfs | zl= ib
>> >> >>>> +=C2=A0 mxge | ddb_ctf | gzio | zfs | zl= ib \
>> >> >>>> +=C2=A0 compile-with "${NORMAL_C} -= Wno-deprecated-non-prototype"
>> >> >>>> contrib/zlib/inflate.c=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip |
>> >> >>>> \
>> >> >>>> -=C2=A0 mxge | ddb_ctf | gzio | zfs | zl= ib
>> >> >>>> +=C2=A0 mxge | ddb_ctf | gzio | zfs | zl= ib \
>> >> >>>> +=C2=A0 compile-with "${NORMAL_C} -= Wno-deprecated-non-prototype"
>> >> >>>> contrib/zlib/inftrees.c=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 optional crypto | geom_uzip |
>> >> >>>> \
>> >> >>>> -=C2=A0 mxge | ddb_ctf | gzio | zfs | zl= ib
>> >> >>>> +=C2=A0 mxge | ddb_ctf | gzio | zfs | zl= ib \
>> >> >>>> +=C2=A0 compile-with "${NORMAL_C} -= Wno-deprecated-non-prototype"
>> >> >>>> contrib/zlib/trees.c=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip |
>> >> >>>> \
>> >> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs= | zlib \
>> >> >>>>=C2=A0 =C2=A0 compile-with "${NORMAL= _C} ${NO_WSTRICT_PROTOTYPES}"
>> >> >>>> contrib/zlib/uncompr.c=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip |
>> >> >>>> \
>> >> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs= | zlib \
>> >> >>>> -=C2=A0 compile-with "${NORMAL_C} -= Wno-cast-qual"
>> >> >>>> +=C2=A0 compile-with "${NORMAL_C} -= Wno-cast-qual
>> >> >>>> -Wno-deprecated-non-prototype"
>> >> >>>> contrib/zlib/zutil.c=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip |
>> >> >>>> \
>> >> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs= | zlib \
>> >> >>>>=C2=A0 =C2=A0 compile-with "${NORMAL= _C} ${NO_WSTRICT_PROTOTYPES}"
>> >> >>>> diff --git a/sys/modules/zlib/Makefile >> >> >>>> b/sys/modules/zlib/Makefile
>> >> >>>> index 6391255e512b..178d3a3f7ab7 100644<= br> >> >> >>>> --- a/sys/modules/zlib/Makefile
>> >> >>>> +++ b/sys/modules/zlib/Makefile
>> >> >>>> @@ -25,4 +25,6 @@ CWARNFLAGS.crc32.c+=3D= ${NO_WSTRICT_PROTOTYPES} #
>> >> >>>> crc32.c:586
>> >> >>>> CWARNFLAGS.trees.c+=3D${NO_WSTRICT_PROTO= TYPES} # trees.c:232
>> >> >>>> CWARNFLAGS.zutil.c+=3D${NO_WSTRICT_PROTO= TYPES} # zutil.c:27,32
>> >> >>>>
>> >> >>>> +CWARNFLAGS+=3D-Wno-deprecated-non-proto= type
>> >> >>>> +
>> >> >>>> .include <bsd.kmod.mk>
>> >> >>>
>> >> >>>
>> >> >>
>> >> >>
>> >> >> --
>> >> >> Mateusz Guzik <mjguzik gmail.com>
>> >> >
>> >> >
>> >>
>> >>
>> >> --
>> >> Mateusz Guzik <mjguzik gmail.com>
>> >>
>> >
>>
>>
>> --
>> Mateusz Guzik <mjguzik gmail.com>
>>
>


--
Mateusz Guzik <mjguzik gmail.com>
--000000000000d124d105f48b1a39--