Re: git: 4378cc5cfb5c - main - Reapply: <type_traits>: Avoid instantiating a pointer type in std::decay<>

From: Dima Panov <fluffy_at_FreeBSD.org>
Date: Sat, 11 Feb 2023 15:44:36 UTC 
Moin-moin!

This fixes build of devel/boost-libs on amd64/i386 but not on aarch64.

Just for note -- your own (from github) test branch with llvm15 imported is able to build boost on aarch64 too; so it looks like missed something else on import to main tree.

On 09.02.2023 19:28, Dimitry Andric wrote:
> The branch main has been updated by dim:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=4378cc5cfb5cf928e287c0143efb120d5558c4a0
> 
> commit 4378cc5cfb5cf928e287c0143efb120d5558c4a0
> Author:     Dimitry Andric <dim@FreeBSD.org>
> AuthorDate: 2023-02-09 09:33:42 +0000
> Commit:     Dimitry Andric <dim@FreeBSD.org>
> CommitDate: 2023-02-09 16:28:32 +0000
> 
>      Reapply: <type_traits>: Avoid instantiating a pointer type in std::decay<>
>      
>        GCC expands the pointer type in this conditional expression even for
>        template types _Up that are not arrays.  This raises an error when
>        std::decay<> is used with reference types (as is done in LLVM's
>        sources).  Using add_pointer<> causes GCC to only instantiate a
>        pointer type for array types.
>      
>        A similar change to this commit (albeit reworked due to upstream
>        changes) has been merged to libc++ in commit
>        26068c6e60324ed866a1ca2afb5cb5eb0aaf015b.
Sincerely,
Dima (fluffy@FreeBSD.org, https://t.me/FluffyBSD)
(desktop, kde, x11, office, ports-secteam)@FreeBSD team