From nobody Thu Feb 09 16:28:51 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PCMkW6QgHz3pnB8; Thu, 9 Feb 2023 16:28:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PCMkW5v7gz4Lxr; Thu, 9 Feb 2023 16:28:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675960131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qYYWb8Hm0YBPzE+t/SnTACki4023DE6jvWwlY1nA+7g=; b=iDLga4dv+nzLC6SUXREoTd4q5+DSw7ll7pLujlNVqLrxDwbigRLiuS15If1+eD4xn57qHq nfHiByv3nEIEprajMg1jthlCVPyS7BJqxDVEX8LsH7kXtbP2Qu9deDZ3BeVtbjd9Xssk2L em0mMMPV7oc/TMTiIQc63Yx6SdYFm8z54ykA8VdLVeVMCom3mZcqHxyZYNrrSsH3HmZ2pF sCIRQnYi7y3ZA/DWCZuAarhFe6ib6naJtSwHkOQDvS0FuSUyCsrOIhxsg1kh55z5ILPLVb 0rsIMXU7HlrsYC/a7hwgim/xH47hsG7rnTMB5Bl8fzyIv2ZuqMWVTVcNr2pSaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675960131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qYYWb8Hm0YBPzE+t/SnTACki4023DE6jvWwlY1nA+7g=; b=RmVqBtCJOHRWcCQm78A8Sq5L9621RDNJBXGLQCA8vEFSkVi4EO0R0iIesz9/Y+dMZv3xLb kfiRGIbVb2HBNVr1Nirfom9nGvpfmK4RWOnOvX3PWJZlg5vTbHP4xD70ub+jcslLhzlDxJ uUp5cAm1XqG8xrWEXob0RmvBdr5uSWhNNSnixLhRjb8tofdg2U4xeDNGyQiRReqEIbPvDB 8S7zDfjF2SDkSel6uhA2R2tnBzi/zebd1aj8SVwx8qBiOP01nwkx+VOdEvgU1UHuJzlumH PnyarhOyNhNSejP6W3/pMffs/246RnWKIfWkVqux0Kmp21NHMW9h6WS+Uzjxag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675960131; a=rsa-sha256; cv=none; b=jteeqBsm7/qswI/lP5iNiCwiou1HUcipR49lCAkKGf0bOoEmOGdyd4mRndD44NKgC5b1Dt RvdiA/AaeFAgyRPu6QmkQSVSXxvA8LB+WCMTIdWpZ1fEFqT2DUQCCmK7bAgxSiH0+09gUG mm6etQw0xlcpp7MQeBfG+eDo6n71Wzod9+XH08+QDmA4PhqdIdDVnDAy5zmlY1UBAWJ+xr TjBXzh+Ilw8i7sHNwbDv7fcQNJKKv8F6LE6QfTdTRawrlo62xtfrpZ/I8ZEleMsWC63WyU kkJ9MhWOX+/g8AjyJsF/ZGWp58aQMr6qldtKPrV7kx8tBaiNJLZRmAsv9SCLVA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PCMkW4xFKzjy1; Thu, 9 Feb 2023 16:28:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 319GSp9n024065; Thu, 9 Feb 2023 16:28:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 319GSpbg024064; Thu, 9 Feb 2023 16:28:51 GMT (envelope-from git) Date: Thu, 9 Feb 2023 16:28:51 GMT Message-Id: <202302091628.319GSpbg024064@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dimitry Andric Subject: git: 4378cc5cfb5c - main - Reapply: : Avoid instantiating a pointer type in std::decay<> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4378cc5cfb5cf928e287c0143efb120d5558c4a0 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=4378cc5cfb5cf928e287c0143efb120d5558c4a0 commit 4378cc5cfb5cf928e287c0143efb120d5558c4a0 Author: Dimitry Andric AuthorDate: 2023-02-09 09:33:42 +0000 Commit: Dimitry Andric CommitDate: 2023-02-09 16:28:32 +0000 Reapply: : Avoid instantiating a pointer type in std::decay<> GCC expands the pointer type in this conditional expression even for template types _Up that are not arrays. This raises an error when std::decay<> is used with reference types (as is done in LLVM's sources). Using add_pointer<> causes GCC to only instantiate a pointer type for array types. A similar change to this commit (albeit reworked due to upstream changes) has been merged to libc++ in commit 26068c6e60324ed866a1ca2afb5cb5eb0aaf015b. In file included from /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/__compare/ordering.h:13, from /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/__compare/common_comparison_category.h:12, from /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/tuple:168, from /usr/src/contrib/llvm-project/llvm/include/llvm/ADT/DenseMapInfo.h:20, from /usr/src/contrib/llvm-project/llvm/include/llvm/ADT/DenseMap.h:17, from /usr/src/contrib/llvm-project/llvm/lib/Transforms/Scalar/GVNHoist.cpp:36: /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/type_traits: In instantiation of 'struct std::__1::__decay': /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/type_traits:1591:89: required from 'struct std::__1::decay' /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/__utility/pair.h:132:16: required by substitution of 'template::type>::value && (! std::__1::is_same::type, std::__1::pair > >::value)), std::__1::pair >::_CheckTupleLikeConstructor, std::__1::__check_tuple_constructor_fail>::type::__enable_implicit<_Tuple>(), void>::type* > constexpr std::__1::pair >::pair(_Tuple&&) [with _Tuple = llvm::CHIArg&&; typename std::__1::enable_if::type>::value && (! std::__1::is_same::type, std::__1::pair > >::value)), std::__1::pair >::_CheckTupleLikeConstructor, std::__1::__check_tuple_constructor_fail>::type::__enable_implicit<_Tuple>(), void>::type* = ]' /usr/src/contrib/llvm-project/llvm/lib/Transforms/Scalar/GVNHoist.cpp:892:51: required from here /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/type_traits:1582:30: error: forming pointer to reference type 'std::__1::remove_extent::type' {aka 'llvm::CHIArg&'} 1582 | >::type type; | ^~~~ Reviewed by: dim Differential Revision: https://reviews.freebsd.org/D36898 This reapplies commit c36de97088a2b9141cdaf2fae2a7f41bf820ffa0, which I accidentally overwrote in the llvm 15 merge. (It turns out upstream did not merge this to their 15.x branch.) MFC after: 2 weeks --- contrib/llvm-project/libcxx/include/__type_traits/decay.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/llvm-project/libcxx/include/__type_traits/decay.h b/contrib/llvm-project/libcxx/include/__type_traits/decay.h index d47ad03fe008..2af0c1ca42c3 100644 --- a/contrib/llvm-project/libcxx/include/__type_traits/decay.h +++ b/contrib/llvm-project/libcxx/include/__type_traits/decay.h @@ -37,7 +37,7 @@ public: typedef _LIBCPP_NODEBUG typename conditional < is_array<_Up>::value, - typename remove_extent<_Up>::type*, + typename add_pointer::type>::type, typename conditional < is_function<_Up>::value,