Re: git: 356deeb2e7f6 - main - kyua/qemu: When running in qemu, don't teset sendfile
- In reply to: Alan Somers : "Re: git: 356deeb2e7f6 - main - kyua/qemu: When running in qemu, don't teset sendfile"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 08 Feb 2023 23:36:25 UTC
On Wed, Feb 8, 2023 at 4:34 PM Alan Somers <asomers@freebsd.org> wrote: > On Wed, Feb 2, 2022 at 2:28 PM Warner Losh <imp@freebsd.org> wrote: > > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=356deeb2e7f64c5b3fff8e28f4b4fcc8b9cbf7bc > > > > commit 356deeb2e7f64c5b3fff8e28f4b4fcc8b9cbf7bc > > Author: Warner Losh <imp@FreeBSD.org> > > AuthorDate: 2022-02-02 21:27:51 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2022-02-02 21:27:51 +0000 > > > > kyua/qemu: When running in qemu, don't teset sendfile > > > > qemu's bsd-user doesn't implement sendfile, so just skip those tests > > that use it. > > > > Sponsored by: Netflix > > --- > > lib/libc/tests/sys/sendfile_test.c | 54 > ++++++++++++++++++++++++++++++++++++++ > > tests/sys/kern/sendfile_test.sh | 12 +++++++++ > > 2 files changed, 66 insertions(+) > > Should you also check for qemu in tests/sys/fs/fusefs/read.cc ? There > are also some test cases there that use sendfile. > Likely a good idea... It will be a while, though, until I get back to this... So if somebody else gets there first... Warner