From nobody Thu Feb 02 15:17:25 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P72TL16wKz3flBr; Thu, 2 Feb 2023 15:17:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P72TL0VMcz3Hxs; Thu, 2 Feb 2023 15:17:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675351046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YDcJpGIZMiB0K9smgmNAvL0xwKsUFL6JVirDMDH1WJM=; b=qdFtjr5XPzDssB6DCuk1OBfhKAw9W6fkojC9SIvrniOrkevHLyPTHxzO6UIllILDxsBzLa 0QQhejiIiRBsSBUP0Gw93H8B2Zw/CDWW/RCIcPpHdJU/CfiaJpyykOCKpnttyHM4ja93Y8 oAvHa7oAJMZ4OTRppEQVDRg2k0kvsrxHvFANeBhhwtU4hY/kxlm25r09lhUK+TA0RazAov Pmp3AKst2mVo+8OwKtTsPUvbx/gWURiP2KQ6HfAinZbYWIVLO2THfEKV6v1lbBYoJ0Vxqo DYkqixE9Gdt9It1O724QAXCmvy/fgzIwiMAf/ear3czaHseePHCe8FqQ5qyn7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675351046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YDcJpGIZMiB0K9smgmNAvL0xwKsUFL6JVirDMDH1WJM=; b=a/sdHVH9QHVUnFK1uI/a1skz0GEZU9/Q4FvuEXHvefOP26HrC2ckqPBdfapNLdPUyh45D2 Eir4Q6x5heHpSdX/4hTB3dA5flLsDA0+76X7LtU9R1UOdX4lJR6oPuWei39I7ufgS+B0sg DWhb9i9AXYio/I3xWHx/dyfDDN1eJCNvFICseJLsx77T8NS4BNUOY25sdpcS54hqEUsla2 pim/GZBWpa4DS8MU1OgJOkB5t03Ss6fyV0OOWx3qkm3BjHCB01szOABpCXPxCADchSPPU/ 6v3b6/XuGwWx3Fvlm+guNBOR1poKCk+qaWdSO71Iqb/4VO03LqjZlLvdUR97Fw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675351046; a=rsa-sha256; cv=none; b=siGpXSde9UC9X+lJ3tGfVG8OE8Sm5mX+txKcdGqEovKZhoVKh+aNUYDcx0ncLJZ1PQSoVl pECRZFxLJmEe/1fAjnZ+sf9+wh/HXnYdk/Jov6y0uxSwpqRSKVgV7nVAB2u+jPBUoq0Egq +2Sj8rTkiqen8iVoncUNW6cG4T4r6TmKXAEdM2mewchC/Wft9FlHT6LQH/07wDHqbFtC2N IbKelrgegY52l2PR0Z4FkpDCwoBpRaiV6U7xTsZe2WK+2qrK8cp/1ElQ1LpCCLroUtTOHO BfXOnk3Q7ICBR0G2SkTIi9fPe/Ap3WVGvi02CpNEAIoHkk8LRru89jrFKW1PKw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P72TK6ZJRz107s; Thu, 2 Feb 2023 15:17:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 312FHP7p020966; Thu, 2 Feb 2023 15:17:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 312FHPAK020965; Thu, 2 Feb 2023 15:17:25 GMT (envelope-from git) Date: Thu, 2 Feb 2023 15:17:25 GMT Message-Id: <202302021517.312FHPAK020965@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: 8de48df35c3b - main - ixgbe: Do not count L3/L4 checksum errors as input errors List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8de48df35c3bf4800176b7aa54c75a01864d458b Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=8de48df35c3bf4800176b7aa54c75a01864d458b commit 8de48df35c3bf4800176b7aa54c75a01864d458b Author: Andrew Gallatin AuthorDate: 2023-02-02 15:02:44 +0000 Commit: Andrew Gallatin CommitDate: 2023-02-02 15:14:12 +0000 ixgbe: Do not count L3/L4 checksum errors as input errors NIC input errors have traditionally indicated problems at the link level (crc errors, runts, etc). People tend to build monitoring infrastructure around such errors in order to monitor for bad network hardware. When L3/L4 checksum errors are included in the category of input errors, it breaks such monitoring, as these errors can originate anywhere on the internet, and do not necessarily indicate faulty local network hardware. Reviewed by: erj, glebius Differential Revision: https://reviews.freebsd.org/D38346 Sponsored by: Netflix --- sys/dev/ixgbe/if_ix.c | 5 ----- sys/dev/ixgbe/ixgbe.h | 1 - 2 files changed, 6 deletions(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 4f6faeec4296..8df0e59a8346 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -1577,19 +1577,14 @@ ixgbe_update_stats_counters(struct ixgbe_softc *sc) * Aggregate following types of errors as RX errors: * - CRC error count, * - illegal byte error count, - * - checksum error count, * - missed packets count, * - length error count, * - undersized packets count, * - fragmented packets count, * - oversized packets count, * - jabber count. - * - * Ignore XEC errors for 82599 to workaround errata about - * UDP frames with zero checksum. */ IXGBE_SET_IERRORS(sc, stats->crcerrs + stats->illerrc + - (hw->mac.type != ixgbe_mac_82599EB ? stats->xec : 0) + stats->mpc[0] + stats->rlec + stats->ruc + stats->rfc + stats->roc + stats->rjc); } /* ixgbe_update_stats_counters */ diff --git a/sys/dev/ixgbe/ixgbe.h b/sys/dev/ixgbe/ixgbe.h index 0f81a0a2c2da..83a51b4d15e7 100644 --- a/sys/dev/ixgbe/ixgbe.h +++ b/sys/dev/ixgbe/ixgbe.h @@ -507,7 +507,6 @@ struct ixgbe_softc { "\nSum of the following RX errors counters:\n" \ " * CRC errors,\n" \ " * illegal byte error count,\n" \ - " * checksum error count,\n" \ " * missed packet count,\n" \ " * length error count,\n" \ " * undersized packets count,\n" \