From nobody Thu Feb 02 07:43:31 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P6rPf6JkTz3cB0Q for ; Thu, 2 Feb 2023 07:43:34 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P6rPf1H9lz3J6p for ; Thu, 2 Feb 2023 07:43:34 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com; dmarc=none Received: by mail-wm1-f54.google.com with SMTP id k8-20020a05600c1c8800b003dc57ea0dfeso3069170wms.0 for ; Wed, 01 Feb 2023 23:43:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jRKwkJRLOvKbYmAAfG36JmRByCtbyvzlxd+eNqry3Z0=; b=Cp11aRehiugLvm0dFkGtkis59KtZXloX8zQ/0g082pZA+j43VDfokHDidn8rN5he77 wIgvwtKq7tvCWTs2I7AQi43G/xDd+XF8inB/mSG3RcnNI2ReC5z0Xkr+xFTjoHfDTsJu Vg7kydBqdjzhKf/UwG5sBCLmkv+KvtIT2EIdUAlMPVJWVT+X+ZY0tMSJk+GKkHv1hj0u yofoT4pOuyXWdFIS1e5XfY8+sCsMMBL8DtGTJWUyp9jcANSx54Owc+G3giHqhYCVBuNI cTkITabG7iMJjKS09hmMO2i2wJcxT5cJMtOE1HosFELcqeqLmKf2mnzzzaOB9ZtmUabF P7tA== X-Gm-Message-State: AO0yUKV1RYkf/YQzaZLwjOH7FM3reoPWi8oyOSRys44OG/UehNUuq7lx +EwoYK9owic8eVeFqcTBI+jl1g== X-Google-Smtp-Source: AK7set/bFQYfJ+Wh6zXnKyUdG7hcPnTkNOVUnIgGwDLoPeSmI/gjsW0Z+l4W9UNVWgtoruCU0kM5XA== X-Received: by 2002:a05:600c:1e8d:b0:3df:deb5:6ff5 with SMTP id be13-20020a05600c1e8d00b003dfdeb56ff5mr493107wmb.24.1675323812328; Wed, 01 Feb 2023 23:43:32 -0800 (PST) Received: from smtpclient.apple (global-5-143.n-2.net.cam.ac.uk. [131.111.5.143]) by smtp.gmail.com with ESMTPSA id h14-20020a05600c314e00b003db0b0cc2afsm4278810wmo.30.2023.02.01.23.43.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Feb 2023 23:43:31 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 1e0853ee8403 - main - sys/kbio.h: support Unicode key codes in vt keymap files From: Jessica Clarke In-Reply-To: Date: Thu, 2 Feb 2023 07:43:31 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <84830C1A-149F-4B05-99DC-1E0B50C8B59A@freebsd.org> References: <202302011630.311GUmt1068106@gitrepo.freebsd.org> To: =?utf-8?Q?Stefan_E=C3=9Fer?= X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spamd-Result: default: False [-2.32 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.82)[-0.824]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; TO_DN_EQ_ADDR_SOME(0.00)[]; DMARC_NA(0.00)[freebsd.org]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.54:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FREEFALL_USER(0.00)[jrtc27]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; MID_RHS_MATCH_FROM(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.54:from] X-Rspamd-Queue-Id: 4P6rPf1H9lz3J6p X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N On 1 Feb 2023, at 16:40, Jessica Clarke wrote: >=20 > On 1 Feb 2023, at 16:30, Stefan E=C3=9Fer wrote: >>=20 >> The branch main has been updated by se: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D1e0853ee84031e4131a0b8cc8737696f= 199d3d4c >>=20 >> commit 1e0853ee84031e4131a0b8cc8737696f199d3d4c >> Author: Stefan E=C3=9Fer >> AuthorDate: 2023-02-01 16:24:18 +0000 >> Commit: Stefan E=C3=9Fer >> CommitDate: 2023-02-01 16:24:18 +0000 >>=20 >> sys/kbio.h: support Unicode key codes in vt keymap files >>=20 >> Some keyboard definitions return Unicode characters that cannot be >> represented in the 8 bits provided by an u_char. >>=20 >> Extend then width of the keycode entries to 16 bits to allow for = all >> keycodes currently defined in share/vt/keymaps/*,kbd. >>=20 >> Reported by: yuri@aetern.org >> MFC after: 3 days >> --- >> sys/sys/kbio.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/sys/sys/kbio.h b/sys/sys/kbio.h >> index 7f17bda76c51..b0779f5ed114 100644 >> --- a/sys/sys/kbio.h >> +++ b/sys/sys/kbio.h >> @@ -200,7 +200,7 @@ typedef struct okeymap okeymap_t; >>=20 >> struct acc_t { >> u_char accchar; >> - u_char map[NUM_ACCENTCHARS][2]; >> + u_short map[NUM_ACCENTCHARS][2]; >=20 > This breaks ABI for [GP]IO_DEADKEYMAP. Ping. This is important, especially with the MFC after. This should be reverted and re-landed with compat IMO. Jess >> }; >>=20 >> struct accentmap {