From nobody Fri Dec 29 07:35:46 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T1ccb1Z0Wz55WWl; Fri, 29 Dec 2023 07:35:59 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T1ccZ6wf5z4dtM; Fri, 29 Dec 2023 07:35:58 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-4b739b49349so673841e0c.1; Thu, 28 Dec 2023 23:35:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703835357; x=1704440157; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p7YCokxFPBzIQQkVkb0YO+CxI3aMdhPPbtt3kUUDOoQ=; b=fPkf3WoOMDJD5mqRt83up8Aly+vKGDqtPAJJKs8VutvSA43NduqCqYRLaqlMezf2WC 6tZUIdvH7C+Vm4pKUGOjpUcAbCfsVsBdfUkIZmssxNOuJhj2Jk5uiDWtpacgG9MyeiXF opbc0Mg+NCx9EAjxJbGolewb9X/QfUdqXEMmlHbkuFs1xlnDlUyzW72KR62EkzIEgsxR qln0QSqU4ipQ+ZDRLn0HdxGLRwddum+GzWBdkbVbRn5TJDHYZYSaoiNUOEsUg4LZxIUi SjYiHgaUUufe9bHkqG8aSDmZCxuPywLq5SD18axN55AnM2ua5hd1GuXzK/KYQsmf2Ywj QizQ== X-Gm-Message-State: AOJu0YzxgL/mcx8ohrgpiJf+XC7OhAzEW8efe9ARzWGbsWmi5J97sTNW /ymX1ewnG8eiZg/APqs7yf/ytIg1Xa1oENrQpp/7wfsbkx8= X-Google-Smtp-Source: AGHT+IGnHqtdgBEZ6DQRT5kQMcseBekfIHxNNfhd4jKt5dcJrw/xP6uSd0oBw77Mh51A2uxmEujdcwLv6nVoHtGPBoQ= X-Received: by 2002:a05:6122:d07:b0:4b6:e848:bf1b with SMTP id az7-20020a0561220d0700b004b6e848bf1bmr4004344vkb.29.1703835357606; Thu, 28 Dec 2023 23:35:57 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202312270143.3BR1hMQf085312@gitrepo.freebsd.org> In-Reply-To: From: Antoine Brodin Date: Fri, 29 Dec 2023 07:35:46 +0000 Message-ID: Subject: Re: git: a8b70cf26030 - main - netpfil: Use accessor functions and named constants for all tcphdr flags To: Gleb Smirnoff Cc: Richard Scheffenegger , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4T1ccZ6wf5z4dtM On Thu, Dec 28, 2023 at 10:37=E2=80=AFPM Gleb Smirnoff wrote: > > Antoine, > > On Thu, Dec 28, 2023 at 08:48:36PM +0000, Antoine Brodin wrote: > A> > netpfil: Use accessor functions and named constants for all tcph= dr flags > A> > > ... > A> This breaks some ports: > A> /usr/include/netinet/tcp.h:82:8: error: unknown type name 'inline' > > Definitely some ports that use some strange compilers :) > > Can you please give at least port names? Some examples: https://pkg-status.freebsd.org/gohan04/data/mainamd64PR275986-default-foo/2= 023-12-28_20h35m41s/logs/errors/nspr-4.35.log https://pkg-status.freebsd.org/gohan04/data/mainamd64PR275986-default-foo/2= 023-12-28_20h35m41s/logs/errors/opusfile-0.12_1.log Antoine