From nobody Thu Dec 14 17:48:50 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Srfwh3wYgz52nQ7; Thu, 14 Dec 2023 17:48:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Srfwh3L9Qz3fPf; Thu, 14 Dec 2023 17:48:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1702576132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SvoH2upjyu+nxatEXX7RZ/UHvaoxrq5+YVmPS2L7DJw=; b=q0rL3TFQhPstZ3Hs1Tw6yq7BjnjFpSUZwOi38Xqm2wwAuCIn1HElm/HYt9WNweZcm2+9lw Eyorvw6Fu6WEgPTuE1r1NZlhBM0G0AEeJUTOoRvDjNBgoavMkqzogh+1wbFoPboiQcxghN AbzStkJA6f82b7l8U7UXDXg2LVlEiFkXz7v5etvUVA/WNadE5NUeCZ+j0n4CEBYAbHp5Im p7YtWjsHN82WciRva4lQ0LrofSRNZD3bdci8JjEsy49+memjNyYVTkIyQ2EQijs2ic+ivd YVdHalBKLKYaVRDopxhBHKkKtHq10eJhs8cMV4Gw1DnHwolT2W73EI41qwosbg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1702576132; a=rsa-sha256; cv=none; b=bWQNzWhpqxjRbR86PTYJUYwigUFT5NIQToVaH50cSB/0TKkagoC7lxg8kYdrWBdB0ngGXI 8nSPTRkoXfkLhTFjCzQI3CxIotNbOlavPSKVMwXgydGvC00Pb4oo20YQir8rpIgIbKuX3u 9AnOVo7Ld9IFR18wpKaA6V31mAsVzYu9tgEr5/yIdHKjoM5h6AhKULr7OQN+8hUa3CzLKJ In9dOxFKdY4RQH75Dz5PoLDDIQTdGcdiFXgnAIh4IP4Om0sn7bJb3ZPPPWzMYqmuA01kpT 422Yg9DW0dHFlpA6bpU5n2f4tMXfkZSXAZhxLQr4VziiX3rmd9RL9aUdTKrpOQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1702576132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SvoH2upjyu+nxatEXX7RZ/UHvaoxrq5+YVmPS2L7DJw=; b=R2hBjPR4qligNzu4jP3yp8WUdtjO15a2epL9Ckji8eR6Toxl1bK238P8AnoX1MOVU0R7/v 8b0Bq6z3DZhbdD4C9Xua1xTOZ7SBhqa2ktYP+K4yDntLIdqoI/Ailta22a1uqgvaGMwDQH shkVPGRXmUWb/pRNpHWgr0V/lUF9KePFmUg9UUy0VMX5eYzROP6WD500iX6dL3CmttAJed vX5ub8sr4PwTyz2LBY6gxu6BsdGHcs1V76pu2H3gRLW7dvrxe0qjDumHlNCJn2SjDWdUWn Yf2Uin+Mxn174v/6YOc6FQraAn6q3iYGZSQK8oHEOhz64zfft2Z0I5vwiy0uZA== Received: from [IPV6:2601:648:8384:fd00:655e:b60a:b20c:6a5f] (unknown [IPv6:2601:648:8384:fd00:655e:b60a:b20c:6a5f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Srfwg6S57zpXd; Thu, 14 Dec 2023 17:48:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <92a185f3-ab96-4dd0-b455-a3e28aa595f6@FreeBSD.org> Date: Thu, 14 Dec 2023 09:48:50 -0800 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 0840bdbf2a07 - main - Don't try and run kldxref for arm kernels Content-Language: en-US To: Jessica Clarke , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202312141644.3BEGiQKZ081497@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202312141644.3BEGiQKZ081497@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/14/23 8:44 AM, Jessica Clarke wrote: > The branch main has been updated by jrtc27: > > URL: https://cgit.FreeBSD.org/src/commit/?id=0840bdbf2a07b68e29267bc49057ca6df2351360 > > commit 0840bdbf2a07b68e29267bc49057ca6df2351360 > Author: Jessica Clarke > AuthorDate: 2023-12-14 16:40:08 +0000 > Commit: Jessica Clarke > CommitDate: 2023-12-14 16:40:08 +0000 > > Don't try and run kldxref for arm kernels > > Surprisingly, kldxref does not currently support arm, and unhelpfully > this means it silently does nothing rather than give an error, so the > linker.hints entry added to the METALOG for -DNO_ROOT builds (and > pkgbase ones) refers to a file that doesn't exist. Ideally it would be > supported (and ideally the METALOG handling would be less fragile, but > without integrating it into kldxref the only real option would be to > just run find(1) to get the list of linker.hints files, which feels a > little backwards), but for now just paper over this by skipping the > build step on arm. > > Reported by: bapt > Fixes: ff7c12c1f17e ("Make kldxref a bootstrap tool and use unconditionally") > --- > sys/conf/kmod.mk | 3 ++- > sys/modules/Makefile | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) I think before the libelf changes it was creating a file, but with only a single version record. Now it defers emitting the version record until it emits at least one "real" record since it doesn't know which endianness to use until it has successfully opened and parsed a file. As a result it is now leaving the file empty rather than with the version record. It should not be hard to add ef_arm.c to fix for arm. Another fun project btw would be for someone to add a "read" mode to kldxref to read a linker.hints file and dump the contents in a human readable fashion similar to the output one gets from 'kldxref -d'. -- John Baldwin