From nobody Thu Dec 14 00:06:48 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SrCMJ3DdXz54WT7; Thu, 14 Dec 2023 00:06:52 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SrCMJ2gxfz4Gk3; Thu, 14 Dec 2023 00:06:52 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1702512412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YrdSxXNSqK88CmCEw2kMoFwQ5Zz2nKu+nuRFbZb9FDU=; b=gForuEnnWpMEviEglQCZGOs7NMP3aJiRsV7Voc/4E8+LFbrcLiRBRAhO9/njM9Y4uj5LjF z4wbee4pircls1FVbGNlodyw5yfDGkNUm7qxiqsStxMZF/zrzikRxiTS/IFQyGUVx4RS+s kzldRehJDccnwOy0YxCYIFKzfmqWplGYbIGxiPI4mdggDJfUZo/TNSa9I/2/YH47sQAZHA 3m83F5MMOyqqeKWwLE9rLiW5W78XnV0sm0pmIgTDewZLQ/axPPj5Skku2yL8zLspw48VLe 8uIPSyurGJ53DP5JgwvZwoGApRGvAi+pMUDUdeeAeMI9fjI+fF0eB5kS+1Fhvw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1702512412; a=rsa-sha256; cv=none; b=o6QnDOlNItgcEszYqvKSlxNRbaedV8oVqiFtnFQByzKtiKYi+mV0fGXRPcZ1idVeZ56+OD opFjmHOcjZhbwgUAsFo9Ah/aCeoua3TUm9XPdmIxAAfx27Z9ZfUsUt3XM5ezBgaDmuhvjH SVgh9vzO5je00IzdBywgHqMl2GUJGBquEixGDvAKIv16jyIkhJxm8Yxb920CnIYNDnX+OU 1bcVOl28ef1yJtvfUV0U0as/gcDSe1QGSZNQk9IrrnMnPPps117acKgzBHLN4JXbHv0Hvl gYoW/Jus2msYdThdTd6oTKuoqJk7JCFTyqCAvrMmjraiGq7zsYkXK+ouGObj1w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1702512412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YrdSxXNSqK88CmCEw2kMoFwQ5Zz2nKu+nuRFbZb9FDU=; b=qvZjmHDZU5LjPz8scXlPiZTO+8TgAh+jfqX5VcNKlVDvbPtQlqBOZh0SsFjYxeu72iNt1n t3HLKWDjDXVJMQi6v52O4NkErSdul3Kee0R0w7BjOsXkdOdFWtb1xVZUCxRPTNVn/TsF59 W53ig6cHq2IU/QIaHlZ02LDwytYNqBBo0ViwaeIHzcNXiPPPO6ac3oX17xpu/oRHW++r2j gpN7aYUevaDPZML56+zjMR+UmpPjG5NLSxiVp8J1N+4Ohe6CTbmnMwo8ZrQgPbWt41ivLj WrcQCVpaBoYwSXU7HChSUVEEN2vpQlOkokvD/7TX6G+i4SgvFIt8+PU2M7C9OQ== Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:13b:39f::9f:25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE Root Certificate Authority" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SrCMJ0LyGz16h; Thu, 14 Dec 2023 00:06:52 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id E329F8D4A162; Thu, 14 Dec 2023 00:06:50 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 8F9142D029D6; Thu, 14 Dec 2023 00:06:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id uVvgu2sJiH-P; Thu, 14 Dec 2023 00:06:49 +0000 (UTC) Received: from strong-iwl0.sbone.de (strong-iwl0.sbone.de [IPv6:fde9:577b:c1a9:4902:b66b:fcff:fef3:e3d2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 4FE712D029D2; Thu, 14 Dec 2023 00:06:49 +0000 (UTC) Date: Thu, 14 Dec 2023 00:06:48 +0000 (UTC) From: "Bjoern A. Zeeb" To: =?UTF-8?Q?Jean-S=C3=A9bastienP=C3=A9dron?= cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 509707e8b6b7 - main - linuxkpi: Add `sysfs_create_link()` in In-Reply-To: <202312131828.3BDISllg019034@gitrepo.freebsd.org> Message-ID: References: <202312131828.3BDISllg019034@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="1098556516-735906049-1702512409=:54546" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1098556516-735906049-1702512409=:54546 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Wed, 13 Dec 2023, Jean-SébastienPédron wrote: > The branch main has been updated by dumbbell: > > URL: https://cgit.FreeBSD.org/src/commit/?id=509707e8b6b7326c7f4793b6e291f0a8e6939412 > > commit 509707e8b6b7326c7f4793b6e291f0a8e6939412 > Author: Jean-Sébastien Pédron > AuthorDate: 2023-12-08 21:54:29 +0000 > Commit: Jean-Sébastien Pédron > CommitDate: 2023-12-13 18:18:46 +0000 > > linuxkpi: Add `sysfs_create_link()` in > > [Why] > The amdgpu DRM driver started to use it in Linux 5.18. > > [How] > The function is a no-op as I'm not sure how to implement this with > sysctls yet. > > Reviewed by: manu > Approved by: manu > Differential Revision: https://reviews.freebsd.org/D43022 > --- > sys/compat/linuxkpi/common/include/linux/sysfs.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/sys/compat/linuxkpi/common/include/linux/sysfs.h b/sys/compat/linuxkpi/common/include/linux/sysfs.h > index 3dc1a18fdbd3..8b4160453a3a 100644 > --- a/sys/compat/linuxkpi/common/include/linux/sysfs.h > +++ b/sys/compat/linuxkpi/common/include/linux/sysfs.h > @@ -152,6 +152,15 @@ sysfs_remove_file(struct kobject *kobj, const struct attribute *attr) > sysctl_remove_name(kobj->oidp, attr->name, 1, 1); > } > > +static inline int > +sysfs_create_link(struct kobject *kobj __unused, > + struct kobject *target __unused, const char *name __unused) > +{ > + /* TODO */ We've started to add these as pr_debug("%s: TODO\n", __func__); as that way they will at least show up if linuxkpi.debug is turned on rather than being silent NOPs. That said, is the link supposed to go away along with the "file" if removed or do both need to be removed independently? > + return (0); > +} > + > static inline int > sysfs_create_files(struct kobject *kobj, const struct attribute * const *attrs) > { > -- Bjoern A. Zeeb r15:7 --1098556516-735906049-1702512409=:54546--