From nobody Thu Dec 07 23:24:35 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SmVk23Ccgz53nPR; Thu, 7 Dec 2023 23:25:14 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from mx0b-00273201.pphosted.com (mx0a-00273201.pphosted.com [208.84.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Sectigo RSA Organization Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SmVk20FSLz3Z9c; Thu, 7 Dec 2023 23:25:13 +0000 (UTC) (envelope-from sjg@juniper.net) Authentication-Results: mx1.freebsd.org; none Received: from pps.filterd (m0108157.ppops.net [127.0.0.1]) by mx0a-00273201.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B7MoLr9018971; Thu, 7 Dec 2023 15:25:10 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=to : cc : subject : in-reply-to : references : from : mime-version : content-type : content-id : date : message-id; s=PPS1017; bh=+DNpN9/H8TD2R66pkWF8gbtB5/qpe+IzK/uYPWdsKmE=; b=IX/Q62WV4hRJwNHLZ3BEr1J6n1+bD7FSKLWWlZpfEGV106XvYLrPh1oydEqL9GhKnf1U Yb1Umx+pKP7YT7q9RezBTqfxHuT8VPz+ucST1dfrNpdLhtJHsCOqFnmjxie6g8UzJoGd JIHa5cPLUIOqV79RI4b49dOb9JCx+PQEml/ltkPABVeUxqP7mYE9CqGho7gJB7NBRy29 G/o+aC6v9GhKQVX/NR9HG8tsCOcBNYDsCYRlfVZl4KeRKo3nOmAqCme8oqXrPGlAA8dB JbFL8CWl7eGA7c/8PTRncUIxneSOLZ8o7W9EgVEbetmHbCggrr2NKEoTtMtA/zjKDYhh Eg== Received: from cy4pr02cu008.outbound.protection.outlook.com (mail-westcentralusazlp17012025.outbound.protection.outlook.com [40.93.6.25]) by mx0a-00273201.pphosted.com (PPS) with ESMTPS id 3uuf8hh569-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Dec 2023 15:25:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dqJBszYxlHnjBLAtsquXs8EY9p/ERcDbnOh+ecR/O1H2phnNAAnsVms5OsvucFN+P2uLobOMrhvKGJHzid7g9yV57EqKAgoIVcXvPpEq5zFAR7fGyVS2hrB60lXJ0siXfNrFm1IpFSilkO2CawqpdBb7cfn0POsLbsoVt12AM5SO58FxXz+Ck/6YJSnsmoouu0lHwQh+XcOlQLa59hD/Rt3I64QrSGtzFAKvqJcnXc+svev2ZK7dshDkCRkQ5KVfyLx5Xc8tRqeL0ednVbt20a7y5d2+ZaVVkzSvMaOhF/zS6qv9bbNFz8J08HI7TEi9agW3FiixDuCnoYaWKOQmcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+DNpN9/H8TD2R66pkWF8gbtB5/qpe+IzK/uYPWdsKmE=; b=DoYtDZzFAiC9vUKsF9+zj5Weheh218tDdlPvJhKoDLxg8FcaedH+cTBjfBWfCGsqJXmOvoWNKfkFRpWTld59909gxtW7J+JLcBP8qzMPJTRT+AuzGeY8aXJXX4fI4jbWYGHT0adwOckm1bUiyMSVpRkaVPQc82wSv9dCTpSC/Uils8EGkwT7viEgwFR+UjHLLsdTAO33ZMZdBisVjg6PJTF6Z6R5gaWvCjowGQPkfH9RRv1/k3TWg8Fhmmrd3Jdq9cMF3MbE7KSljiBAB5kDFv4ZQtYlIxwjol9Nck9zh4PalB1K4ZNC0WQEjNfo3MpDrEtywpn8Si3j8u/PGm0UaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 66.129.242.15) smtp.rcpttodomain=freebsd.org smtp.mailfrom=juniper.net; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=juniper.net; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+DNpN9/H8TD2R66pkWF8gbtB5/qpe+IzK/uYPWdsKmE=; b=V3XZJFfk7YLbK9qLmBeMlDy6IEbhLgptAw+4XYlYg2PH1rBodtvaxy3470ghC6VXvl9dtsYMWieIVLVmCpHNttMhkyqNiwW0/PJQ0VCunMRsDoDnNBjhv4OXr+FA+1KLUvTBVX8tg6GRZpBR4hQNWW9roV6WXKP4yk3QQTUW6Qw= Received: from BN9PR03CA0948.namprd03.prod.outlook.com (2603:10b6:408:108::23) by LV3PR05MB10500.namprd05.prod.outlook.com (2603:10b6:408:218::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.27; Thu, 7 Dec 2023 23:25:07 +0000 Received: from BN8NAM12FT073.eop-nam12.prod.protection.outlook.com (2603:10b6:408:108:cafe::b6) by BN9PR03CA0948.outlook.office365.com (2603:10b6:408:108::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.29 via Frontend Transport; Thu, 7 Dec 2023 23:25:07 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 66.129.242.15) smtp.mailfrom=juniper.net; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.242.15 as permitted sender) Received: from p-exchfe-eqx-02.jnpr.net (66.129.242.15) by BN8NAM12FT073.mail.protection.outlook.com (10.13.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.17 via Frontend Transport; Thu, 7 Dec 2023 23:25:06 +0000 Received: from p-exchbe-eqx-01.jnpr.net (10.104.9.14) by p-exchfe-eqx-02.jnpr.net (10.104.9.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Thu, 7 Dec 2023 17:25:05 -0600 Received: from p-mailhub01.juniper.net (10.104.20.6) by p-exchbe-eqx-01.jnpr.net (10.104.9.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39 via Frontend Transport; Thu, 7 Dec 2023 17:25:05 -0600 Received: from kaos.jnpr.net (kaos.jnpr.net [172.23.255.201]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id 3B7NP55E032260; Thu, 7 Dec 2023 15:25:05 -0800 (envelope-from sjg@juniper.net) Received: by kaos.jnpr.net (Postfix, from userid 1377) id 643654DA17; Thu, 7 Dec 2023 15:24:35 -0800 (PST) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id 63B534D7EA; Thu, 7 Dec 2023 15:24:35 -0800 (PST) To: Warner Losh CC: Jessica Clarke , src-committers , "" , "" , Subject: Re: git: 83d0b8c089d8 - main - bsdinstall generate opt_osname.h in include In-Reply-To: References: <202312070235.3B72ZoZp043061@gitrepo.freebsd.org> <71239.1701921562@kaos.jnpr.net> <58331.1701924865@kaos.jnpr.net> Comments: In-reply-to: Warner Losh message dated "Wed, 06 Dec 2023 23:16:24 -0700." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6+git; nmh 1.8; GNU Emacs 28.2 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <38758.1701991475.1@kaos.jnpr.net> Date: Thu, 7 Dec 2023 15:24:35 -0800 Message-ID: <43001.1701991475@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM12FT073:EE_|LV3PR05MB10500:EE_ X-MS-Office365-Filtering-Correlation-Id: bf1a46d9-7358-4135-e8b9-08dbf77bbf2c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AylTq2bKvh2E3EVvQFZisTDY5GNXEOQjc4r282MUKJpKqTO9iLc1sZVH6JBsgcURUhdD9E7X994Yh8HvnaPX/wUhl0zrWMepDvn4Q/1WX29noeoc/R0+3SJlcWLC99du8T36UXe39Py7CbLGOBBAihbxWkDiGOcNDlGJIpnbHqNLqw9sQKpAi/hUmEEuCwBxXPMJIsgjn354yOKxWe72E3JoCmvvix+R2r+sPgqgVqlEBaQliL7rv1TXFxVBRkOfSVac6sYtcYOc5HYxVEZc5EYH3QNQ4aaMZWDBDfbpB2pwTd5h2FSc2an8bizmzlHf5XqfHn2veOfShfyr741yCu04GLo2MtFnEM0sF51kZoNQSQDxSjuRf0dMt5b2RKhxEP35cr9nSb+ydx/r0h7J3T2EPbg+pA7S33stJZbQL1d4pb0aKzCpeDjRaZAg8jbMq7R9Nqm/nThQN3Vf/8AOqQM7tYG2Eicc3taA0g276GLMrB/UrbXZvs6xgee44295jr1KVtWJLzqeNj4pseRjtOcnMTQ1hlNW7iBjiYL5KVHyJuLri2wIbAT1VF3v1o4ifO+aaNnsqW98NyYKBl44sbHrxtv6yI0A4rH98/LJtW60vBF8kIaOXsEpvgr7/zURiQFqwZ2b+QnDL4Df94v48qGJrcUJX5Q75dmnnadZDbAkGyiLcMIzyE9uYjr0h1WV4pBx+JJ8I+Uov/HZWUCzQSFwpXyJ+xWC3+x1k9UYSIcxyjELHnsWvQq+SS4fhSDNrVvHPXfmx6FwCj55uQDh0SHFe/+5VTyZGSRBblFTHjLIgKEG1Kmd6uMl8bLxmkAV X-Forefront-Antispam-Report: CIP:66.129.242.15;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:p-exchfe-eqx-02.jnpr.net;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(136003)(396003)(39860400002)(346002)(376002)(230922051799003)(186009)(64100799003)(82310400011)(1800799012)(451199024)(36840700001)(40470700004)(46966006)(4744005)(5660300002)(2906002)(41300700001)(36860700001)(54906003)(70586007)(86362001)(82740400003)(47076005)(107886003)(26005)(70206006)(356005)(478600001)(81166007)(336012)(7126003)(6266002)(9686003)(7696005)(83380400001)(8936002)(8676002)(6916009)(4326008)(316002)(40480700001)(40460700003)(55016003)(36900700001);DIR:OUT;SFP:1102; X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 23:25:06.2080 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bf1a46d9-7358-4135-e8b9-08dbf77bbf2c X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4;Ip=[66.129.242.15];Helo=[p-exchfe-eqx-02.jnpr.net] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM12FT073.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR05MB10500 X-Proofpoint-GUID: ElnkUjkj5SrYEVeqZtJLbDagu6cLK27h X-Proofpoint-ORIG-GUID: ElnkUjkj5SrYEVeqZtJLbDagu6cLK27h X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-07_17,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 phishscore=0 clxscore=1015 priorityscore=1501 mlxlogscore=335 adultscore=0 bulkscore=0 spamscore=0 mlxscore=0 suspectscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312070198 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:26211, ipnet:208.84.65.0/24, country:US] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4SmVk20FSLz3Z9c Warner Losh wrote: > > > The reason I did it using a file is so that make(1) would detect a > > > change a rebuild if you change the value and do another build. > > A fair point. Of course moot if using META_MODE. > The other benefit of the header is only the files that include it will > be rebuilt when the value changes whereas (with META_MODE) everything > will be rebuilt if value is in CFLAGS. > > That can be mitigated by using per object CFLAGS, but all in all the > header is a simpler solution. > > This name never changes on practice. We shouldn't optimize for a rare > case that causes build races. Who would ever change it in the same > tree? Also a fair point. I'm happy to do it either way - so long as we avoid circular dependencies.