From nobody Sat Dec 02 11:53:21 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sj7c53JBlz539YT; Sat, 2 Dec 2023 11:53:25 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sj7c52kgjz4Qb9; Sat, 2 Dec 2023 11:53:25 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701518005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8Q/geZ4c65oOTPI8I1OKr06SAghOSCmLGMKsYPKEquw=; b=stIlcLfyq9Wie46UfWUiQ0xKeVdk25AVsAvq+W6F3HefTP559/zxKhMUwsdQP0XbIaxPRj Igi+scft7RfFa1x6XDFPGtnQA52goAdpNg3r222Lng9FOMnIlRlwQ+s37XVGxuwq1NkFp2 K866Y3LYyr65JJn1ZZkQi59jp3CPukdY+6WyzohE9gTkhKg/GBVnELBu+J44Fc78tsdaSV pIgRMARjPEhaEN8QSesMJO6KMubI/H0t4P6nFLPnkrlsnFP/fAMkAdCbZUno07QNcwbxp3 +6CuU4azgHhxe1Ruiqen3vfqn1EEVJ+RWD0/IISJxcqzlGrZXL/TbPvM74H5vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701518005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8Q/geZ4c65oOTPI8I1OKr06SAghOSCmLGMKsYPKEquw=; b=rMThplhCPJgMGbofWR+Iv6DEhrbtfy6RU+701TPjQW9is2CL3ugwxfuArSnANhnFOsq8V6 VzC/H0k/TM7LxT8gG0UlG5oeu5rHgYwRP4sJaXd7sRSewLswGSNntziNG7GNgNx7z+r5HJ 6YjaKWNOjHBWT9X7UlWTYQQqsjkoqkWMlI+HBo/maHA22m2mkQiDH4/GHzmEQ0BV8DNVTw 1VVBcn8Tgi9xUUWhpesvMnIIk233/DuKVSg/9dlqQrokgqA4gBGX3LF5HZjePDqrlJnYA9 96f09S6pOHFCswLTFFha+aJn+G5k4TbrwcbnjtaRiCTdHjjwShZgY171matLTA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701518005; a=rsa-sha256; cv=none; b=fMqH0XXKJora4Dt0yDZIDb0a7rpoqmCf2lnj5b6dPFKTpWfzILnxd+UMmXmEVvGWR7V0k+ PeaFG68hL9vgADzlVuJS8jPNVPZnNMW5A1Z7oo/eW9nWwAU8ERp/OV5s4ZI/kRJf0hsZ9/ v8EBoERJM/koXQ7wikfhj9GnV3fm7dM+srt6pHdMu5yGfzEvSYT/vwqMh1KqPj2NxcgLbC k7j0sdnQxWpZdYmTZO+mmXMMSau11qNB5PVT4sB1eZ7CKFerju3gdPcF645peACQ4jONn5 9ujF3hXMumbEKdGGo2wDYW/bH6UjNnBM/3U6qZBUXsl7McSv6IiXWNukj8OWdQ== Received: from mx1.sbone.de (cross.sbone.de [195.201.62.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE Root Certificate Authority" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Sj7c50bdNz1B3Z; Sat, 2 Dec 2023 11:53:25 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id B37228D4A162; Sat, 2 Dec 2023 11:53:23 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 29DFE2D029D7; Sat, 2 Dec 2023 11:53:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id cJMxDJZPviTv; Sat, 2 Dec 2023 11:53:22 +0000 (UTC) Received: from strong-iwl0.sbone.de (strong-iwl0.sbone.de [IPv6:fde9:577b:c1a9:4902:b66b:fcff:fef3:e3d2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 12A4B2D029D2; Sat, 2 Dec 2023 11:53:22 +0000 (UTC) Date: Sat, 2 Dec 2023 11:53:21 +0000 (UTC) From: "Bjoern A. Zeeb" To: Gleb Smirnoff cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: be7c095ac99a - main - unix/dgram: bump maximum datagram size limit to 8k In-Reply-To: <202312012337.3B1NbuZg092076@gitrepo.freebsd.org> Message-ID: References: <202312012337.3B1NbuZg092076@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII On Fri, 1 Dec 2023, Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: https://cgit.FreeBSD.org/src/commit/?id=be7c095ac99ad29fd72b780c7d58949a38656c66 > > commit be7c095ac99ad29fd72b780c7d58949a38656c66 > Author: Gleb Smirnoff > AuthorDate: 2023-12-01 23:37:29 +0000 > Commit: Gleb Smirnoff > CommitDate: 2023-12-01 23:37:29 +0000 > > unix/dgram: bump maximum datagram size limit to 8k > > This is important for wpa_supplicant operation on a crowded network. This also unbreaks syslogd again as previously fixed based on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260126 > Note: we actually need an API to increase maximum datagram size on a > socket. Previously SO_SNDBUF magically acted like that, but that was > an undocumented "feature". > > Also move the comment to the proper line. Previously it was the receive > buffer that imposed the limit. Now notion of buffer size and maximum > datagram are separate. > > Reviewed by: bz, tuexen, karels I discussed this but not approved this change. We seem to be likely the only OS now enforcing (the slightly increasesd) 1988s limits after everyone else got the behaviour from us that we were running on for 34 years. I still think that is not the right direction. > Differential Revision: https://reviews.freebsd.org/D42830 > PR: 274990 > --- > sys/kern/uipc_usrreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sys/kern/uipc_usrreq.c b/sys/kern/uipc_usrreq.c > index 069294e1c963..8f5560e0f30b 100644 > --- a/sys/kern/uipc_usrreq.c > +++ b/sys/kern/uipc_usrreq.c > @@ -154,8 +154,8 @@ static struct task unp_defer_task; > #endif > static u_long unpst_sendspace = PIPSIZ; > static u_long unpst_recvspace = PIPSIZ; > -static u_long unpdg_maxdgram = 2*1024; > -static u_long unpdg_recvspace = 16*1024; /* support 8KB syslog msgs */ > +static u_long unpdg_maxdgram = 8*1024; /* support 8KB syslog msgs */ > +static u_long unpdg_recvspace = 16*1024; > static u_long unpsp_sendspace = PIPSIZ; /* really max datagram size */ > static u_long unpsp_recvspace = PIPSIZ; > > -- Bjoern A. Zeeb r15:7