From nobody Wed Aug 23 00:31:19 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RVnFw00Gyz4qgyn for ; Wed, 23 Aug 2023 00:31:32 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RVnFv1rlgz4gFQ for ; Wed, 23 Aug 2023 00:31:31 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20221208.gappssmtp.com header.s=20221208 header.b=RspwnWl+; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2a00:1450:4864:20::636) smtp.mailfrom=wlosh@bsdimp.com; dmarc=none Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-991c786369cso673452166b.1 for ; Tue, 22 Aug 2023 17:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20221208.gappssmtp.com; s=20221208; t=1692750690; x=1693355490; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=H3nSdXldIUTriMy0CFD7SCxAbR+Qk9QNvkiqdLha/E0=; b=RspwnWl+l1bxLHwCNWqT2w/LANeZqn7AeJwYelAvGninCb7517/RMt/n1Z6dxjJ2kX 7gZewSvZ8nWO/W9MEGrWRM+xipDre3w/LxNT2CwjvALjVVMq9qZUARkd3xA/6tSKeDoC DLfzbQ/PsAHs9/I1d+xzkNLSUtD8a7b3Yn//FSJlg1BkXwmzdioiDR0o59AXthw+kr8b jz5i0mkiCKo1X82/34hdhcOFt0nxmrAzGdA/bTs6G+AnxxilArC3t9BY0K2CCmy9BU0J kdGvSAxYobEaqgu2psCN+04X5iuMvbfeyS5cmmWOngk5OXKwLiz5rk+Zg7lQW6KIoCWt YdQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692750690; x=1693355490; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=H3nSdXldIUTriMy0CFD7SCxAbR+Qk9QNvkiqdLha/E0=; b=jjIUCu1Sejwyf8nazjBDlhywbpnBA27b0iPD/udxw5EIzg9uwAnRWvYUuJ148XwSuj eRqOjMoQ5zSm6Vdi8dMVQ8BtssSzfYyX2PYJPEOQTrgMLxQMPi2ipJmGXYLEOI/i6MrX 5LqoDdGM3T2sSkIx3i/egX3OUdxyE+PSd5tuuXFSFgHOIjW0Tn4KciVdGWZk2K7UnCsW 4Xy/aiWQPhpcSvUPVxvNKdklbPV3h/xb1w76UWiWalEeQosa7Hs8CUv7fvy36JLTNrei I9boT00mmZ7ew/meygTU2Mywnn6IYCTiX9ccGTV40IpeX3VhrixLNsThiP89u+Q83O1U azBw== X-Gm-Message-State: AOJu0YyDt6ERK22Q3+hXWtimeBYWeKR/EnNlp3Yq1s/IP3ZNsPoOyena HAVEVzIyRKrfNvoahvJXpSDzVfHcLIy5iIoILZzZJooxz3Qm43zR X-Google-Smtp-Source: AGHT+IEcKwAOm/FMM3QAd5DmgsTj5Ix9Po7gy++csKlfOHoHLZqYgSoXyiR6qAAStfhGpDcWFcrQ4JR79XVMVavyPjI= X-Received: by 2002:a17:906:28d:b0:99c:3b4:940f with SMTP id 13-20020a170906028d00b0099c03b4940fmr9528571ejf.27.1692750690209; Tue, 22 Aug 2023 17:31:30 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202211042255.2A4MtqVv032693@gitrepo.freebsd.org> <419530F4-DB8F-46EA-BF45-C130BCF8A3DE@FreeBSD.org> <05979953-C089-4D56-99E3-BBBF066FE277@FreeBSD.org> In-Reply-To: From: Warner Losh Date: Tue, 22 Aug 2023 18:31:19 -0600 Message-ID: Subject: Re: git: 91fcacc35597 - main - if_bnxt: Add support for VLAN on Thor To: Kevin Bowling Cc: Kristof Provost , Sumit Saxena , Warner Losh , "" , "" , src-committers Content-Type: multipart/alternative; boundary="0000000000009562ad06038c3b84" X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20221208.gappssmtp.com:s=20221208]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; R_SPF_NA(0.00)[no SPF record]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::636:from]; DKIM_TRACE(0.00)[bsdimp-com.20221208.gappssmtp.com:+]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; DMARC_NA(0.00)[bsdimp.com]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com] X-Spamd-Bar: -- X-Rspamd-Queue-Id: 4RVnFv1rlgz4gFQ --0000000000009562ad06038c3b84 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Aug 22, 2023, 6:26 PM Warner Losh wrote: > > > On Tue, Aug 22, 2023, 5:59 PM Kevin Bowling > wrote: > >> On Tue, Aug 22, 2023 at 3:39=E2=80=AFPM Kevin Bowling >> wrote: >> > >> > >> > >> > On Tue, Aug 22, 2023 at 2:07 PM Kristof Provost wrote= : >> >> >> >> On 27 Jun 2023, at 11:17, Kristof Provost wrote: >> >> >> >> On 4 Nov 2022, at 23:55, Warner Losh wrote: >> >> >> >> The branch main has been updated by imp: >> >> >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=3D91fcacc355971f74aa26fc7861020d= c3a2a2d717 >> >> >> >> commit 91fcacc355971f74aa26fc7861020dc3a2a2d717 >> >> Author: Sumit Saxena >> >> AuthorDate: 2022-11-04 22:24:32 +0000 >> >> Commit: Warner Losh >> >> CommitDate: 2022-11-04 22:24:32 +0000 >> >> >> >> if_bnxt: Add support for VLAN on Thor >> >> >> >> Reviewed by: imp >> >> Differential Revision: https://reviews.freebsd.org/D36443 >> >> --- >> >> sys/dev/bnxt/bnxt.h | 3 +- >> >> sys/dev/bnxt/bnxt_hwrm.c | 110 >> ++++++++++++++++++++++++++++------------------- >> >> sys/dev/bnxt/bnxt_hwrm.h | 7 ++- >> >> sys/dev/bnxt/if_bnxt.c | 7 ++- >> >> 4 files changed, 74 insertions(+), 53 deletions(-) >> >> >> >> This commit appears to have broken vlan on these interfaces. >> >> My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (i= n >> a Dell T640, if that helps). >> >> >> >> A simple vlan creation on top of one: >> >> ifconfig vlan create >> >> ifconfig vlan0 vlan 201 vlandev bnxt0 >> >> >> >> Results in a loss of connectivity. The kernel logs this, which I >> assume is related: >> >> >> >> `bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS >> error.` >> >> >> >> After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128) I >> can create vlan interfaces on top of bnxt0 without losing connectivity. >> >> >> >> >> >> Should we revert this before 14.0? >> >> >> >> There=E2=80=99s also a report of what I think is the same issue in >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269133 >> >> >> >> There=E2=80=99s a proposed patch there, but it did not work for me. >> > >> > >> > In markj=E2=80=99s analysis he mentions the issue of the reinit. >> > >> > It sounds like there are multiple bugs in this driver but one quick >> band aid may be to mark the driver as not needing re-init for VLAN >> modifications.. that sounds unlikely and was probably an accident when t= he >> if reset functionality was added. You can check e1000 for that. >> >> Here's what I mean as a patch https://reviews.freebsd.org/D41558 >> >> > Note I don=E2=80=99t have this hw and haven=E2=80=99t audited the code= so this could be >> noise but it=E2=80=99s an easy thing to check. >> > > Is there a good bug we can post that link to for someone to test? > Duh.. posted to bug above and https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222680 Warner > Warner > >> > >> >> Best regards, >> >> Kristof >> > --0000000000009562ad06038c3b84 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Aug 22, 2023, 6:26 PM Warner Losh <imp@bsdimp.com> wrote:


On Tue, Aug 22, 2023, 5:59 PM Ke= vin Bowling <kevin.bowling@kev009.com> wrote:
On Tue, Aug 22, 2023 at 3:39=E2=80=AFPM Kevin Bo= wling <kevin.bowling@kev009.com> wrote:
>
>
>
> On Tue, Aug 22, 2023 at 2:07 PM Kristof Provost <kp@freebsd.= org> wrote:
>>
>> On 27 Jun 2023, at 11:17, Kristof Provost wrote:
>>
>> On 4 Nov 2022, at 23:55, Warner Losh wrote:
>>
>> The branch main has been updated by imp:
>>
>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D91fcacc355971f7= 4aa26fc7861020dc3a2a2d717
>>
>> commit 91fcacc355971f74aa26fc7861020dc3a2a2d717
>> Author: Sumit Saxena <sumit.saxena@broadcom.c= om>
>> AuthorDate: 2022-11-04 22:24:32 +0000
>> Commit: Warner Losh <imp@FreeBSD.org>
>> CommitDate: 2022-11-04 22:24:32 +0000
>>
>> if_bnxt: Add support for VLAN on Thor
>>
>> Reviewed by: imp
>> Differential Revision: https://revi= ews.freebsd.org/D36443
>> ---
>> sys/dev/bnxt/bnxt.h | 3 +-
>> sys/dev/bnxt/bnxt_hwrm.c | 110 ++++++++++++++++++++++++++++-------= ------------
>> sys/dev/bnxt/bnxt_hwrm.h | 7 ++-
>> sys/dev/bnxt/if_bnxt.c | 7 ++-
>> 4 files changed, 74 insertions(+), 53 deletions(-)
>>
>> This commit appears to have broken vlan on these interfaces.
>> My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet,= (in a Dell T640, if that helps).
>>
>> A simple vlan creation on top of one:
>> ifconfig vlan create
>> ifconfig vlan0 vlan 201 vlandev bnxt0
>>
>> Results in a loss of connectivity. The kernel logs this, which I a= ssume is related:
>>
>> `bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS e= rror.`
>>
>> After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128= ) I can create vlan interfaces on top of bnxt0 without losing connectivity.=
>>
>>
>> Should we revert this before 14.0?
>>
>> There=E2=80=99s also a report of what I think is the same issue in= https://bugs.freebs= d.org/bugzilla/show_bug.cgi?id=3D269133
>>
>> There=E2=80=99s a proposed patch there, but it did not work for me= .
>
>
> In markj=E2=80=99s analysis he mentions the issue of the reinit.
>
> It sounds like there are multiple bugs in this driver but one quick ba= nd aid may be to mark the driver as not needing re-init for VLAN modificati= ons.. that sounds unlikely and was probably an accident when the if reset f= unctionality was added.=C2=A0 You can check e1000 for that.

Here's what I mean as a patch https://re= views.freebsd.org/D41558

> Note I don=E2=80=99t have this hw and haven=E2=80=99t audited the code= so this could be noise but it=E2=80=99s an easy thing to check.

Is there a = good bug we can post that link to for someone to test?

Duh.. posted = to bug above and

= Warner


Warner
>
>> Best regards,
>> Kristof
--0000000000009562ad06038c3b84--