Re: git: 1384a0b940e8 - main - kern/subr_unit.c: fix non-debug build

From: Cy Schubert <Cy.Schubert_at_cschubert.com>
Date: Fri, 18 Aug 2023 15:39:54 UTC
In message <ZN-G2RGztwlgAuGj@kib.kiev.ua>, Konstantin Belousov writes:
> On Fri, Aug 18, 2023 at 07:43:45AM -0700, Cy Schubert wrote:
> > In message <202308181337.37IDbMwl051912@gitrepo.freebsd.org>, Konstantin 
> > Belous
> > ov writes:
> > > The branch main has been updated by kib:
> > >
> > > URL: https://cgit.FreeBSD.org/src/commit/?id=1384a0b940e87876d36d50ad5858
> 1c24
> > > dc642714
> > >
> > > commit 1384a0b940e87876d36d50ad58581c24dc642714
> > > Author:     Konstantin Belousov <kib@FreeBSD.org>
> > > AuthorDate: 2023-08-18 13:36:06 +0000
> > > Commit:     Konstantin Belousov <kib@FreeBSD.org>
> > > CommitDate: 2023-08-18 13:37:16 +0000
> > >
> > >     kern/subr_unit.c: fix non-debug build
> > >     
> > >     Sponsored by:   The FreeBSD Foundation
> > >     MFC after:      1 week
> > > ---
> > >  sys/kern/subr_unit.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/sys/kern/subr_unit.c b/sys/kern/subr_unit.c
> > > index 3d45a0c1c5cb..7a23f216d98e 100644
> > > --- a/sys/kern/subr_unit.c
> > > +++ b/sys/kern/subr_unit.c
> > > @@ -353,7 +353,7 @@ check_unrhdr(struct unrhdr *uh, int line)
> > >  	struct unr *up;
> > >  	struct unrb *ub;
> > >  	int w;
> > > -	u_int y, z;
> > > +	u_int y __diagused, z __diagused;
> > 
> > It still doesn't like it.
> How do you build it?
> Is it kernel?  If yes, which kernel config?

It's not in kernel. It's in tests.

===> tests/sys/kern (all)
(cd /opt/src/git-src/tests/sys/kern &&  DEPENDFILE=.depend.coredump_phnum_he
lper  NO_SUBDIR=1 make -f /opt/src/git-src/tests/sys/kern/Makefile 
_RECURSING_PROGS=t  PROG=coredump_phnum_helper )
(cd /opt/src/git-src/tests/sys/kern &&  DEPENDFILE=.depend.pdeathsig_helper 
 NO_SUBDIR=1 make -f /opt/src/git-src/tests/sys/kern/Makefile 
_RECURSING_PROGS=t  PROG=pdeathsig_helper )
(cd /opt/src/git-src/tests/sys/kern &&  DEPENDFILE=.depend.sendfile_helper  
NO_SUBDIR=1 make -f /opt/src/git-src/tests/sys/kern/Makefile 
_RECURSING_PROGS=t  PROG=sendfile_helper )
(cd /opt/src/git-src/tests/sys/kern &&  DEPENDFILE=.depend.subr_unit_test  
NO_SUBDIR=1 make -f /opt/src/git-src/tests/sys/kern/Makefile 
_RECURSING_PROGS=t  PROG=subr_unit_test )
rm -f .depend.subr_unit_test
echo subr_unit_test.full: /export/obj/opt/src/git-src/amd64.amd64/tmp/usr/li
b/libc.a  >> .depend.subr_unit_test
cc -target x86_64-unknown-freebsd14.0 --sysroot=/export/obj/opt/src/git-src/
amd64.amd64/tmp -B/export/obj/opt/src/git-src/amd64.amd64/tmp/usr/bin  -O2 
-pipe -pipe -fno-common   -fPIE -g -gz=zlib -MD  -MF.depend.subr_unit_test.s
ubr_unit.o -MTsubr_unit.o -std=gnu99 -Wno-format-zero-length 
-fstack-protector-strong -Wsystem-headers -Werror -Wall -Wno-format-y2k -W 
-Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes 
-Wpointer-arith -Wno-uninitialized -Wno-pointer-sign -Wdate-time 
-Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable 
-Wno-error=unused-but-set-parameter -Wno-tautological-compare 
-Wno-unused-value -Wno-parentheses-equality -Wno-unused-function 
-Wno-enum-conversion -Wno-unused-local-typedef -Wno-address-of-packed-member
  -Qunused-arguments -Wno-missing-prototypes -c /opt/src/git-src/sys/kern/su
br_unit.c -o subr_unit.o
/opt/src/git-src/sys/kern/subr_unit.c:356:9: error: expected ';' at end of 
declaration
        u_int y __diagused, z __diagused;
               ^
               ;
/opt/src/git-src/sys/kern/subr_unit.c:359:2: error: use of undeclared 
identifier 'z'
        z = 0;
        ^
/opt/src/git-src/sys/kern/subr_unit.c:361:3: error: use of undeclared 
identifier 'z'
                z++;
                ^
/opt/src/git-src/sys/kern/subr_unit.c:367:4: error: use of undeclared 
identifier 'z'
                        z++;
                        ^
/opt/src/git-src/sys/kern/subr_unit.c:377:11: error: use of undeclared 
identifier 'z'
        KASSERT (z == uh->alloc,
                 ^
/opt/src/git-src/sys/kern/subr_unit.c:379:17: error: use of undeclared 
identifier 'z'
            uh->alloc, z, line));
                       ^
6 errors generated.
*** Error code 1

Stop.
make[6]: stopped in /opt/src/git-src/tests/sys/kern
*** Error code 1

Stop.
make[5]: stopped in /opt/src/git-src/tests/sys/kern
*** Error code 1

Stop.
make[4]: stopped in /opt/src/git-src/tests/sys
*** Error code 1

Stop.
make[3]: stopped in /opt/src/git-src/tests
*** Error code 1

Stop.
make[2]: stopped in /opt/src/git-src
      277.70 real       126.62 user        65.55 sys
*** Error code 1

Stop.
make[1]: stopped in /opt/src/git-src
*** Error code 1

Stop.
make: stopped in /opt/src/git-src


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy@nwtime.org>    Web:  https://nwtime.org

			e^(i*pi)+1=0