From nobody Mon Aug 07 22:47:10 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RKWfQ4XQgz4mT3r; Mon, 7 Aug 2023 22:47:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RKWfQ3Y1Xz4R9q; Mon, 7 Aug 2023 22:47:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691448430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+GV1h/hPj7ExMZYDr+TgvLxldaPImYNcKpvf7NFRqtg=; b=osEmn9K8yyX3Dm7as2G2MCTV2YyuGC6qBFSxslbzPA2WdW3UvH4f0HglBJ25+co3O0XwW2 +IyiUw+eSP16aR+3AC8NwhwbaXdH8sQYX7gRL1hJx+3Pjo0vb4dqurCfC0pSLCwfCf1HNu ltbBIpzqrMovXh6dxA6PO3on80OVzqtV/F+SjtBKNu50LMitnV1mrEumcFCSaADeqW47Wj Uziuc7RIxsXsm6pRyFHRvtU9IHGa5QifSrjSwmKgPj0PnxnL8Kr0R1AvG6EJZ/rIs0JX9W UI+/YjFOQHQNXSKB7UvxZFzsLjWqjxeCEFVX5nb0zzasTXbFMkJrUrPsCkyCvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691448430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+GV1h/hPj7ExMZYDr+TgvLxldaPImYNcKpvf7NFRqtg=; b=vuUNbwZTCRKG/XdI0WHtjuMaFvZ/pAleb5QFmpnhsydn/Pcx+hi7YbkO0De6rmEISZ7cOk 65OGRHt/tidhDqrbnWXfTfxXs8NdH2P6zx/BFD+g7RkDqiADjvGZQ2ETATCzzW9ST0mY+l 8Z4+G50nbfbmm3Nwxl3/X2zEE5v5hWoQumNDNqk5WJrPqz8hcRGaewmlF6aoBBUgo0bH8A KXrIWruF2yChvvFbz4GCgwj2vKcnHebUAVi0GDxifc+9qSQ3XiJL+sZp4vjNIKP5a4bqoU VZpc5ae9Wo8ng0TygQmS/BAShnAWbbQzNVWxSmVeQWes3dxwhb/XmT7V1+Hzqw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1691448430; a=rsa-sha256; cv=none; b=cVbDXr+D/wf1wfShQ0as5mYY9Rz0Gia2KQ9LzmzJ4He27cPrBByAU2+hsEUGXpD62jiRrp vUkRDJZFNDI5JfNSzHdlFvvOzaQFDDvT1ZU4nzqoTaJNihdH1qdXFayMbBMcdBwRQJLh1c Zv1/b45CluJkFIojmPMcUdj005J6LozYHp62VpVZqcR2tya2cBTF0mAerGaSjWUvjPoEQb vVjp6M8Q2ehVIn8NIUO3q4KQEEVrI5W40EZiPvw6EPfHxrycWgkN4Fow12FrxgNbPiAEnd rsy2teh8myGgb0IvcH+YKZpqff1ANT1du/U4D/NVxrpGB//savIMgFgKCFdXaQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RKWfQ2Yzsz19Dl; Mon, 7 Aug 2023 22:47:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 377MlA99059116; Mon, 7 Aug 2023 22:47:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 377MlAsV059115; Mon, 7 Aug 2023 22:47:10 GMT (envelope-from git) Date: Mon, 7 Aug 2023 22:47:10 GMT Message-Id: <202308072247.377MlAsV059115@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Eric Joyner Subject: git: 7f527d48124b - main - iflib: Fix white space and reduce some line lengths List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: erj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7f527d48124bd03fcfb946ce2d5d0c7bc71e099d Auto-Submitted: auto-generated The branch main has been updated by erj: URL: https://cgit.FreeBSD.org/src/commit/?id=7f527d48124bd03fcfb946ce2d5d0c7bc71e099d commit 7f527d48124bd03fcfb946ce2d5d0c7bc71e099d Author: Eric Joyner AuthorDate: 2023-08-04 17:53:29 +0000 Commit: Eric Joyner CommitDate: 2023-08-07 22:46:48 +0000 iflib: Fix white space and reduce some line lengths This helps align some of the code with the rest of the style used in iflib, but as marius@ points out, this is not style(9). Signed-off-by: Eric Joyner Reviewed by: kbowling@ MFC after: 3 days Sponsored by: Intel Corporation Differential Revision: https://reviews.freebsd.org/D41324 --- sys/net/iflib.c | 18 ++++++++++-------- sys/net/iflib.h | 7 +++++-- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/sys/net/iflib.c b/sys/net/iflib.c index 9e6964d73764..f4c0e5d54cab 100644 --- a/sys/net/iflib.c +++ b/sys/net/iflib.c @@ -211,6 +211,7 @@ struct iflib_ctx { #define isc_legacy_intr ifc_txrx.ift_legacy_intr #define isc_txq_select ifc_txrx.ift_txq_select #define isc_txq_select_v2 ifc_txrx.ift_txq_select_v2 + eventhandler_tag ifc_vlan_attach_event; eventhandler_tag ifc_vlan_detach_event; struct ether_addr ifc_mac; @@ -1953,7 +1954,7 @@ iflib_rxsd_alloc(iflib_rxq_t rxq) lowaddr = DMA_WIDTH_TO_BUS_LOWADDR(scctx->isc_dma_width); fl = rxq->ifr_fl; - for (int i = 0; i < rxq->ifr_nfl; i++, fl++) { + for (int i = 0; i < rxq->ifr_nfl; i++, fl++) { fl->ifl_size = scctx->isc_nrxd[rxq->ifr_fl_offset]; /* this isn't necessarily the same */ /* Set up DMA tag for RX buffers. */ err = bus_dma_tag_create(bus_get_dma_tag(dev), /* parent */ @@ -6280,7 +6281,8 @@ iflib_irq_alloc_generic(if_ctx_t ctx, if_irq_t irq, int rid, } void -iflib_softirq_alloc_generic(if_ctx_t ctx, if_irq_t irq, iflib_intr_type_t type, void *arg, int qid, const char *name) +iflib_softirq_alloc_generic(if_ctx_t ctx, if_irq_t irq, iflib_intr_type_t type, + void *arg, int qid, const char *name) { device_t dev; struct grouptask *gtask; @@ -6777,16 +6779,16 @@ iflib_add_device_sysctl_pre(if_ctx_t ctx) SYSCTL_ADD_U16(ctx_list, oid_list, OID_AUTO, "override_ntxqs", CTLFLAG_RWTUN, &ctx->ifc_sysctl_ntxqs, 0, - "# of txqs to use, 0 => use default #"); + "# of txqs to use, 0 => use default #"); SYSCTL_ADD_U16(ctx_list, oid_list, OID_AUTO, "override_nrxqs", CTLFLAG_RWTUN, &ctx->ifc_sysctl_nrxqs, 0, - "# of rxqs to use, 0 => use default #"); + "# of rxqs to use, 0 => use default #"); SYSCTL_ADD_U16(ctx_list, oid_list, OID_AUTO, "override_qs_enable", CTLFLAG_RWTUN, &ctx->ifc_sysctl_qs_eq_override, 0, "permit #txq != #rxq"); SYSCTL_ADD_INT(ctx_list, oid_list, OID_AUTO, "disable_msix", - CTLFLAG_RWTUN, &ctx->ifc_softc_ctx.isc_disable_msix, 0, - "disable MSI-X (default 0)"); + CTLFLAG_RWTUN, &ctx->ifc_softc_ctx.isc_disable_msix, 0, + "disable MSI-X (default 0)"); SYSCTL_ADD_U16(ctx_list, oid_list, OID_AUTO, "rx_budget", CTLFLAG_RWTUN, &ctx->ifc_sysctl_rx_budget, 0, "set the RX budget"); @@ -6798,8 +6800,8 @@ iflib_add_device_sysctl_pre(if_ctx_t ctx) CTLFLAG_RDTUN, &ctx->ifc_sysctl_core_offset, 0, "offset to start using cores at"); SYSCTL_ADD_U8(ctx_list, oid_list, OID_AUTO, "separate_txrx", - CTLFLAG_RDTUN, &ctx->ifc_sysctl_separate_txrx, 0, - "use separate cores for TX and RX"); + CTLFLAG_RDTUN, &ctx->ifc_sysctl_separate_txrx, 0, + "use separate cores for TX and RX"); SYSCTL_ADD_U8(ctx_list, oid_list, OID_AUTO, "use_logical_cores", CTLFLAG_RDTUN, &ctx->ifc_sysctl_use_logical_cores, 0, "try to make use of logical cores for TX and RX"); diff --git a/sys/net/iflib.h b/sys/net/iflib.h index 21630297981f..a97d243c0bb0 100644 --- a/sys/net/iflib.h +++ b/sys/net/iflib.h @@ -453,11 +453,14 @@ int iflib_device_iov_add_vf(device_t, uint16_t, const nvlist_t *); int iflib_device_register(device_t dev, void *softc, if_shared_ctx_t sctx, if_ctx_t *ctxp); int iflib_device_deregister(if_ctx_t); -int iflib_irq_alloc(if_ctx_t, if_irq_t, int, driver_filter_t, void *filter_arg, driver_intr_t, void *arg, const char *name); +int iflib_irq_alloc(if_ctx_t, if_irq_t, int, driver_filter_t, void *filter_arg, + driver_intr_t, void *arg, const char *name); int iflib_irq_alloc_generic(if_ctx_t ctx, if_irq_t irq, int rid, iflib_intr_type_t type, driver_filter_t *filter, void *filter_arg, int qid, const char *name); -void iflib_softirq_alloc_generic(if_ctx_t ctx, if_irq_t irq, iflib_intr_type_t type, void *arg, int qid, const char *name); +void iflib_softirq_alloc_generic(if_ctx_t ctx, if_irq_t irq, + iflib_intr_type_t type, void *arg, int qid, + const char *name); void iflib_irq_free(if_ctx_t ctx, if_irq_t irq);