Re: git: dedc71fd3890 - main - libc: unsplit log message to to make it greppable in src
Date: Sat, 05 Aug 2023 11:38:57 UTC
On 5 Aug 2023, at 04:11, Jessica Clarke <jrtc27@freebsd.org> wrote: > > On 5 Aug 2023, at 02:00, Ed Maste <emaste@FreeBSD.org> wrote: >> >> The branch main has been updated by emaste: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=dedc71fd3890803a81047a0c480b95a327bd7214 >> >> commit dedc71fd3890803a81047a0c480b95a327bd7214 >> Author: Ed Maste <emaste@FreeBSD.org> >> AuthorDate: 2023-04-17 15:58:59 +0000 >> Commit: Ed Maste <emaste@FreeBSD.org> >> CommitDate: 2023-08-05 00:59:30 +0000 >> >> libc: unsplit log message to to make it greppable in src >> >> Also use __func__ rather than hardcoding the function name. This code >> now fits in 80 columns without splitting the log message. > > This doesn’t match the commit? Indeed, during the review I noted that __func__ would not expand to the expected value ("__cxa_thread_call_dtors"), so that part was actually removed. Now the effective result only unsplits the message line. I guess this is a case of Phabricator or arc making it difficult to adjust the commit message before 'landing'. -Dimitry