From nobody Tue Aug 01 22:26:08 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RFqT16VG9z4pwvF; Tue, 1 Aug 2023 22:26:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RFqSx47bmz3hXX; Tue, 1 Aug 2023 22:26:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690928769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8xV6k8lOnpo1BQXFTjchysbb3ib1YY+XNyJ8UJGYBRY=; b=e6YLq+qRsgfyZhMB3c57lrXz80azgqj+1+kKfeolcKaaCz4xS8gXMnyYaz3lK4jfZEUiUm //V0Ydyhj26QhcN4HOVRz+D4aqKB0tRcrbM1WAme6NIANXmbI0JtEj5DfVYr+UjG2HP/wO Ex5H6ysYy00+MHFQQceus3XXGNZQ2EToFxj7EUbXhvNTwSID7O6a3IJmnkguG+4r8j7inL T+cC1wQwLElkRAa2deoofNME4eEANDZg4tiA+wHsLLbQhm69vwbsEdpUh3m3wnV2NEwTuv qjIUw6YcAfxnRUD1e7eKvifhvc/eaYfkLh8ai5PVvGWKJBSE3d42FF301+Q+rQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690928769; a=rsa-sha256; cv=none; b=KyE6qqgDHUnNWluUnU8U7if9CKuzqxh41b/VLNeUErnAKjFJDJeqnavYdo/3srVBqQLAOZ taMsf7GfeMEVpUJA0UJAVhWuJpKXWMdtWBgaPcfntm94GztpXmMVaDvoO4Kz0X7L+QgSzJ iqtDvMWErpHJyZn7uY027vNit4+eQFvpK3FSVd7E9V20Cx3hhsY6/2ayW8ocgS97QkTQch ykxacfOjcuZXFPIZyl1moi5vYTG8nOi5eB6NX52uWQKS9gxeo7sFoYkYpBgNVv1A+5qgZ8 5IJsMuQBoIz9HRAreLNBPvPzy+/xTTiH4rWORj/EbBVUK6tpdeL50NXEoZPHtQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690928769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8xV6k8lOnpo1BQXFTjchysbb3ib1YY+XNyJ8UJGYBRY=; b=Fr320p7lNl1SVmC3zbKmcHm+U5OnX/noVlZ9BXA23DRLezRpDcuiyav7+zzUwGx5QGKGv+ IoaDktIfbRBlQGhGGpmst6ha5ayg1LJC3up3yBnt5YjrCjT5CJp8U/3XsTTQW9afdWJaXC eT232HR0f0+OJrGgSkBtjG7Z9/Q3LYyqFQSkRo2LgxLXLk345zF/jL8XIZeViy/xvxTC9v nV7GDo5bN3ESwarEBeWnP0PW3QnFI2IdNfZ1f9TQ+MxDtespeY1aT/z9NygyJ25aysETT5 HgbNHT56ZosWdIUJBXZskr2nZ5xlyOLAu9NRLBa+2Cg+87ABcwbIB3YeGbcc2Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RFqSx07PwzvSl; Tue, 1 Aug 2023 22:26:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 371MQ8jf045585; Tue, 1 Aug 2023 22:26:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 371MQ8oa045584; Tue, 1 Aug 2023 22:26:08 GMT (envelope-from git) Date: Tue, 1 Aug 2023 22:26:08 GMT Message-Id: <202308012226.371MQ8oa045584@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 32734eb14c5c - main - mmc_xpt: Remove dubious end of mmc_print_ident List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 32734eb14c5cc3aa4ad576ba746830c73fb8eb54 Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=32734eb14c5cc3aa4ad576ba746830c73fb8eb54 commit 32734eb14c5cc3aa4ad576ba746830c73fb8eb54 Author: John Baldwin AuthorDate: 2023-08-01 22:20:53 +0000 Commit: John Baldwin CommitDate: 2023-08-01 22:20:53 +0000 mmc_xpt: Remove dubious end of mmc_print_ident The end of this function finishes the passed in sbuf, calls printf manually on the contents, and then clears it. The caller then tries to print the resulting sbuf. This works currently but will not work for future callers that pass in an external sbuf to be appended to. Reviewed by: mav Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D41260 --- sys/cam/mmc/mmc_xpt.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/cam/mmc/mmc_xpt.c b/sys/cam/mmc/mmc_xpt.c index 30b1b7f867e7..8fee7b4cad58 100644 --- a/sys/cam/mmc/mmc_xpt.c +++ b/sys/cam/mmc/mmc_xpt.c @@ -466,10 +466,6 @@ mmc_print_ident(struct mmc_params *ident_data, struct sbuf *sb) sbuf_printf(sb, "Number of functions: %u\n", ident_data->sdio_func_count); } - - sbuf_finish(sb); - printf("%s", sbuf_data(sb)); - sbuf_clear(sb); } static void