From nobody Sun Apr 30 03:08:35 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q8BBS2TS5z48d2g; Sun, 30 Apr 2023 03:08:48 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q8BBR1m0Fz4JW7; Sun, 30 Apr 2023 03:08:47 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1a6817adde4so14566135ad.0; Sat, 29 Apr 2023 20:08:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682824125; x=1685416125; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6fKDJ8nqdNbk865qkoXKits4Sz7VuX5ulhT9wmZ0qHg=; b=rW9kS/u+9QUETb9PW2sJ/Nr9F85e1jnvdT+/Mfxsj8VKdU0VzOUNu8nKTc6duxkFbY lm/E7/fiuduD20wXBUNPCokjn7pRdmhD/+sTgxaEgemBo9o45NtQD+xS5cR08GVecrND i8bWlFq/fOkxOX6HbItJgBzASIOdfFbUcsshr+tz1uayvnmespbdIaikF3AY/cJgiZzO 1xLTBWutMOy4k3QAFDYsHVE0jIH4s7TAA3UElCk0fc/yTktzoSkw1YfNAaTFomTzJluG oh4yqDSImLWZGSoG4Dw+oYROW5SEfdxCBNWL5B2HSHbUwdlRYX8cZLIsZ0bySttIXw7r g28A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682824125; x=1685416125; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6fKDJ8nqdNbk865qkoXKits4Sz7VuX5ulhT9wmZ0qHg=; b=l4hHTI8tbV6usJbNVGmOEutcfg4wiKcXCjmEMGGx5jXKlrgPFAz4wDgHyQWkEv1H3T 9eM0leIkpydS8Of0kUQOnNDUyMj/FBGj4ECZ8lplJo/FwNtaPWig+cfF2ilrx7i4hmnx gF8ULZGLhi6hbLyu/ieF7XdEfm+pCfa4+KutFd4SvBwrsmiCRnEbCKK4TuZZsl1esNrP hFL8Pa5kmQvSXkcTL5tKrZJ02voajAvKLvLavoBCoxVOCgn8nCn+703QrwXRVwpI28BZ OVHMtl8yRoJvdUq5suv+rVyGxSaWz97SmqNjehILSB+eMtlETtOWFOhkp59uGEjwTkEV EEKw== X-Gm-Message-State: AC+VfDzbSV8OpaObOc3o2M/pqReAMZIFFsiAQiAzH5cOVRksUqJJby7a e4EZmj7lHFAJYvQgfJ7ziPZj8YhpTuz2xerR50Evh/kbxQ== X-Google-Smtp-Source: ACHHUZ528jEZzcYEE9HZloKSYyS0tYLjkkoph50EWJbkwR/6+XdMJR/9cYprczAQvqAPt6eWJdsFh/4VZtIImIBxsFA= X-Received: by 2002:a17:902:d50c:b0:1a6:955c:6329 with SMTP id b12-20020a170902d50c00b001a6955c6329mr11662059plg.22.1682824125198; Sat, 29 Apr 2023 20:08:45 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202304300055.33U0txC4076743@gitrepo.freebsd.org> <164F1299-0F3D-424C-8A76-C0FD8239B31C@freebsd.org> In-Reply-To: <164F1299-0F3D-424C-8A76-C0FD8239B31C@freebsd.org> From: Rick Macklem Date: Sat, 29 Apr 2023 20:08:35 -0700 Message-ID: Subject: Re: git: 6995e6b3237e - main - Fix printf format conflict To: Jessica Clarke Cc: Kirk McKusick , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4Q8BBR1m0Fz4JW7 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Sat, Apr 29, 2023 at 7:55=E2=80=AFPM Jessica Clarke = wrote: > > On 30 Apr 2023, at 03:54, Rick Macklem wrote: > > > > On Sat, Apr 29, 2023 at 7:17=E2=80=AFPM Jessica Clarke wrote: > >> > >> CAUTION: This email originated from outside of the University of Guelp= h. Do not click links or open attachments unless you recognize the sender a= nd know the content is safe. If in doubt, forward suspicious emails to IThe= lp@uoguelph.ca. > >> > >> > >> On 30 Apr 2023, at 01:55, Kirk McKusick wrote: > >>> > >>> The branch main has been updated by mckusick: > >>> > >>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D6995e6b3237e9be9ae6f68= af13edd3db4b668ab8 > >>> > >>> commit 6995e6b3237e9be9ae6f68af13edd3db4b668ab8 > >>> Author: Kirk McKusick > >>> AuthorDate: 2023-04-30 00:55:15 +0000 > >>> Commit: Kirk McKusick > >>> CommitDate: 2023-04-30 00:55:15 +0000 > >>> > >>> Fix printf format conflict > >>> > >>> MFC after: 1 week > >>> --- > >>> sbin/dumpfs/dumpfs.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/sbin/dumpfs/dumpfs.c b/sbin/dumpfs/dumpfs.c > >>> index 01b475a03fea..743734660e57 100644 > >>> --- a/sbin/dumpfs/dumpfs.c > >>> +++ b/sbin/dumpfs/dumpfs.c > >>> @@ -245,7 +245,7 @@ dumpfs(const char *name, int dosb) > >>> default: > >>> goto err; > >>> } > >>> - printf("old_cpg\t%d\tsize_cg\t%jd\tCGSIZE\t%jd\n", > >>> + printf("old_cpg\t%d\tsize_cg\t%d\tCGSIZE\t%d\n", > >>> afs.fs_old_cpg, sizeof(struct cg), CGSIZE(&afs)); > >> > >> size_t is not an int on 64-bit architectures; you want %zu. > > Since size_t is 32 bits on some arches, don't you need to use %ju > > and (uintmax_t)sizeof(struct cg)? > > No. %zu is size_t by definition. That=E2=80=99s the point of its existenc= e. Yep, I see that in "man 3 printf". As they say, you learn something every d= ay. rick > > Jess > > > rick > > > >> > >> Jess > >> > >>> printf("sblkno\t%d\tcblkno\t%d\tiblkno\t%d\tdblkno\t%d\n", > >>> afs.fs_sblkno, afs.fs_cblkno, afs.fs_iblkno, afs.fs_dblkno); >