From nobody Wed Apr 26 20:22:45 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q69KM5Xxrz47FnR; Wed, 26 Apr 2023 20:22:47 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q69KM3HMPz4KxQ; Wed, 26 Apr 2023 20:22:47 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682540567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cjyO8zVB+nqgDsnRJzSYYXRDaK6H0BVkoDgoTB21nfA=; b=MgyQwPR+fpe0/JuJlyb7NhJM9gyEX+S1aPC9ITzepE0yc6aozuQREWeeOvRiACIEijNbGr fP6AFT26bsB5VD56Fh5ITrW2xB2Y/qy/aVkt2f+1/GDcDU/pnQ3xnTDhZQWW1A5MU/eb+U /UFnSQIC4HIFv9eiGkJFjqwO22yltysM+AdDUPjAkzbSWMo+2SPjFZ9/VZhR2MbsJ9weYo URs6snAQbZv2Al1afJ2IDXVHRdZ9wnfqlCKqR5bTmJ8g46ia65LQSVMJ5eq8fT8AYVkXE7 2MwxEqJbE+Zl8VUFJPqfgD/dei0CAzDRK/bpAeVDWKoIjxe/VxXOzxTk87ldmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682540567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cjyO8zVB+nqgDsnRJzSYYXRDaK6H0BVkoDgoTB21nfA=; b=l+vzJpzethIxoX3gkWnhxILLLfUwTVn/dQra0WpMawrT5SlF0SuTrPgJIFxQds/RnflNT/ a4gV9gZkIS+UT+4TNr+fdXuxtPxJ/c4cFQiF6W8wv+Jmw/JX5QNxUzJ4SMWMK8qnKG85dP a7hhJy6ohVY7o5/if817+C+91ehR7qPHDwzmMAX3SlS4LoLyU5UNIM34LfDvf8sIKLRg4B bYdgW9CCYZqIFOQ8PJLtm11O7Ln6A25xmIcbTGERP5+Hxlz6LqXe48x5x4kSP0UsEvXtvF bkKMiBCP8Tm7F78PdEvXZ9ssQGUKEsRGFqTq19NBooRjXKYOugMATidjNxUKFw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682540567; a=rsa-sha256; cv=none; b=jYyDHxxef5llDppklp00uNXaGoW/c33+mKAGCvCm4bQsrp4ZEYqNPqEyHwjq5JTekhFXDP UuHdzHPZj7cjiodGTnIu8vbaCD8wcif1BB0q2qF6+9VxU/sASxUavVwQvWIFo1PyIal6FI PgI6HX+KyqRFfIqwVRV3sFkBpUI1ByYO74g+kvn5NaKxa7qcIjLz/36/zpr2KWWXzQgJPH eV2GGQJ8Z54yEsi15jSl8XwPUYyXeUE925yDUl/rtSWi8pIJd1x8h9vqhKKLCgkDbNQP0H JDsprHIMP/FtRoJJlSlZ+RIQMuKJs9mCEEBrxyQlUpQb8TTOOO6YpJrR35T6Dg== Received: from [IPV6:2601:648:8680:16b0:4873:5c14:f13a:ffd7] (unknown [IPv6:2601:648:8680:16b0:4873:5c14:f13a:ffd7]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Q69KL6qwhzkFf; Wed, 26 Apr 2023 20:22:46 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <8edff70f-c09f-462c-5821-cb44aebc4723@FreeBSD.org> Date: Wed, 26 Apr 2023 13:22:45 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: git: 2d7842d0bfb4 - main - arp/ndp: Use valid prototypes for function declarations with no arguments. Content-Language: en-US From: John Baldwin To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202304262019.33QKJ2hF081036@gitrepo.freebsd.org> In-Reply-To: <202304262019.33QKJ2hF081036@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 4/26/23 1:19 PM, John Baldwin wrote: > The branch main has been updated by jhb: > > URL: https://cgit.FreeBSD.org/src/commit/?id=2d7842d0bfb4257c5b1aba5c1e6f79e47735d71c > > commit 2d7842d0bfb4257c5b1aba5c1e6f79e47735d71c > Author: John Baldwin > AuthorDate: 2023-04-26 20:18:53 +0000 > Commit: John Baldwin > CommitDate: 2023-04-26 20:18:53 +0000 > > arp/ndp: Use valid prototypes for function declarations with no arguments. > --- > usr.sbin/arp/arp_netlink.c | 2 +- > usr.sbin/ndp/ndp_netlink.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) There is not a valid reason for writing new 1980's C code in 2023. It's one thing to be updating legacy code to use proper function prototypes. It's another thing to be comitting brand new code to the tree that's from the stone age. -- John Baldwin