From nobody Wed Apr 26 05:47:12 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q5nv630Csz47GM1 for ; Wed, 26 Apr 2023 05:47:14 +0000 (UTC) (envelope-from 01000187bc19fc3c-4cc0374f-28b5-42a8-8ee1-9d0b98d29063-000000@amazonses.com) Received: from a8-56.smtp-out.amazonses.com (a8-56.smtp-out.amazonses.com [54.240.8.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q5nv55D8Pz4P6q for ; Wed, 26 Apr 2023 05:47:13 +0000 (UTC) (envelope-from 01000187bc19fc3c-4cc0374f-28b5-42a8-8ee1-9d0b98d29063-000000@amazonses.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=ae7m2yrxjw65l2cqdpjxuucyrvy564tn; d=tarsnap.com; t=1682488032; h=Message-ID:Date:MIME-Version:Subject:To:References:From:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=wv7eam+6+vXwDpPDHF3/wiSw80D/a8PxKk89wQ6oYbs=; b=VpfZ4VidOyUpz/GZYyR0ZrtS9A6w8olxVpQlTCzHa83DDY7b0OA8OrM0k14j95mi qeCXowgxYiHIcnyqkh5jgsi/KqGP6ZtVJAwj8DVRh+vj/Ak4z3BoTGmKxjrmhij3Pa3 /XKuKd9mxFFQKimzjNUUrecGf5FlNGWrEWQZI70Q= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=224i4yxa5dv7c2xz3womw6peuasteono; d=amazonses.com; t=1682488032; h=Message-ID:Date:MIME-Version:Subject:To:References:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Feedback-ID; bh=wv7eam+6+vXwDpPDHF3/wiSw80D/a8PxKk89wQ6oYbs=; b=aXJpGh54cvmV3YA00VpxxU2do0zOpxQiyRCsTo68Y5GFoKXz/KkrnMI/j655YtjZ JnfIxrEFvzvN+UP5j2M13LRSF2hxvsOlU3SMjcvc0l9fnRt8n7cM/97Pthj/biRBpZr wUu3sCDko4YZMPlHVQ8ebsBwz7GqAqxuMktlWZqg= Message-ID: <01000187bc19fc3c-4cc0374f-28b5-42a8-8ee1-9d0b98d29063-000000@email.amazonses.com> Date: Wed, 26 Apr 2023 05:47:12 +0000 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: git: 3a5855dd220b - main - gbde: stop rebuilding sha512 bits Content-Language: en-US To: Kyle Evans , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202304260536.33Q5aqPA029814@gitrepo.freebsd.org> From: Colin Percival In-Reply-To: <202304260536.33Q5aqPA029814@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Feedback-ID: 1.us-east-1.Lv9FVjaNvvR5llaqfLoOVbo2VxOELl7cjN0AOyXnPlk=:AmazonSES X-SES-Outgoing: 2023.04.26-54.240.8.56 X-Rspamd-Queue-Id: 4Q5nv55D8Pz4P6q X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:14618, ipnet:54.240.8.0/21, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 4/25/23 22:36, Kyle Evans wrote: > In the early days of gbde, it linked against libmd. Shortly after > conception, phk replaced ARC4 with SHA-512, but libmd did not have SHA2 > at the time thus he built a copy of sha2.c for gbde. > > Fast forward 3 years, cperciva adds SHA2 to libmd -- this makes gbde's > build of sha2.c redundant, but it's (understandably) overlooked. Let's > simplify the gbde build now and just assume that libmd includes the most > optimal implementation. Slight correction: I added *sha256* to libmd in 2005 (FreeBSD 6.0); markm added sha512 to libmd in 2011 (FreeBSD 9.0). -- Colin Percival FreeBSD Deputy Release Engineer & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid